Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWC Bug with JSX transpilation -- unterminated string constant #32553

Closed
arackaf opened this issue Dec 15, 2021 · 2 comments · Fixed by #32566
Closed

SWC Bug with JSX transpilation -- unterminated string constant #32553

arackaf opened this issue Dec 15, 2021 · 2 comments · Fixed by #32566
Labels
SWC Related to minification/transpilation in Next.js.

Comments

@arackaf
Copy link

arackaf commented Dec 15, 2021

What version of Next.js are you using?

12

What version of Node.js are you using?

14

What browser are you using?

n/a

What operating system are you using?

MacOS

How are you deploying your application?

N/A

Describe the Bug

I'd just like to surface this SWC bug here. If you're on Next 12, this can easily bit you, leaving you searching in vane for answers in the Next GitHub issues.

swc-project/swc#2896

Expected Behavior

JSX accepts strings with single quotes

To Reproduce

See linked GH issue.

@arackaf arackaf added the bug Issue was opened via the bug report template. label Dec 15, 2021
@timneutkens timneutkens added SWC Related to minification/transpilation in Next.js. kind: bug and removed bug Issue was opened via the bug report template. labels Dec 16, 2021
@kdy1 kdy1 mentioned this issue Dec 16, 2021
@kodiakhq kodiakhq bot closed this as completed in #32566 Dec 16, 2021
kodiakhq bot pushed a commit that referenced this issue Dec 16, 2021
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`


This applies

 - swc-project/swc#3051

Fixes #32553

 - swc-project/swc#3023

Fixes #32470
@timneutkens
Copy link
Member

Thanks for the report! We've fixed the bug and released a new canary version: https://github.com/vercel/next.js/releases/tag/v12.0.8-canary.8

It'll take a bit (~30mins) before it's published to npm.

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`


This applies

 - swc-project/swc#3051

Fixes vercel#32553

 - swc-project/swc#3023

Fixes vercel#32470
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
SWC Related to minification/transpilation in Next.js.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants