Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11 breaks when importing components with next/dynamic #36146

Closed
1 task done
jaspersorrio opened this issue Apr 14, 2022 · 3 comments · Fixed by #36159
Closed
1 task done

IE11 breaks when importing components with next/dynamic #36146

jaspersorrio opened this issue Apr 14, 2022 · 3 comments · Fixed by #36159
Labels
bug Issue was opened via the bug report template.

Comments

@jaspersorrio
Copy link

jaspersorrio commented Apr 14, 2022 •
edited

Verify canary release

  • I verified that the issue exists in Next.js canary release

Provide environment information

Operating System:
  Platform: linux
  Arch: x64
  Version: #1 SMP Wed Oct 28 23:40:43 UTC 2020
Binaries:
  Node: 12.22.4
  npm: 6.14.14
  Yarn: N/A
  pnpm: N/A
Relevant packages:
  next: 12.1.6-canary.0
  react: 18.0.0
  react-dom: 18.0.0

What browser are you using? (if relevant)

IE11 21H2 (OS Build 19044.1645)

How are you deploying your application? (if relevant)

No response

Describe the Bug

  1. With IE11 import any component with "next/dynamic"
  2. Page will not render correctly, JS will stop working (onClick etc)

Expected Behavior

  1. With IE11 import any component with "next/dynamic"
  2. Page renders correctly, JS continues to work (onClick etc)

To Reproduce

  1. Git Clone https://github.com/jaspersorrio/next-js-ie11-bug

  2. npm install && npm run dev

  3. Open IE 11

  4. [GET] http://localhost:3000 <-- Will error

  5. [GET] http://localhost:3000/without-dynamic <-- Works fine

@jaspersorrio jaspersorrio added the bug Issue was opened via the bug report template. label Apr 14, 2022
jaspersorrio referenced this issue Apr 14, 2022
@ijjk @kodiakhq
Update to pre-compile use-subscription (#35746)
23be63d 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@ijjk ijjk mentioned this issue Apr 14, 2022
Merged
3 tasks
@kodiakhq kodiakhq bot closed this as completed in #36159 Apr 14, 2022
kodiakhq bot pushed a commit that referenced this issue Apr 14, 2022
@ijjk
Update to target es5 for use-subscription (#36159)
cb526f5 
This ensures we use the `es5` target when pre-compiling the `use-subscription` dependency similar to our other pre-compiled browser dependencies. 

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

Fixes: #36146
@ijjk
Copy link
Member

ijjk commented Apr 14, 2022

Hi, this has been updated in v12.1.6-canary.1 of Next.js, please update and give it a try!

@jaspersorrio
Copy link
Author

jaspersorrio commented Apr 17, 2022 •
edited

Hey @ijjk, i've tested 12.1.6-canary.1 and it works well!

Thanks for the quick fix, appreciate it!

Looking forward to the official release!

@trm217 trm217 mentioned this issue Apr 22, 2022
Merged
8 tasks
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to target es5 for use-subscription ijjk/next.js
2 participants
@jaspersorrio @ijjk