Setting swcMinify: true in production causes a client-side exception

[daanboer]

Verify canary release

• I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: linux
      Arch: x64
      Version: #1-NixOS SMP Wed Feb 22 11:57:12 UTC 2023
    Binaries:
      Node: 18.14.2
      npm: 9.5.0
      Yarn: N/A
      pnpm: 7.26.3
    Relevant packages:
      next: 13.2.4-canary.5
      eslint-config-next: N/A
      react: 18.2.0
      react-dom: 18.2.0

Which area(s) of Next.js are affected? (leave empty if unsure)

SWC minifier (swcMinify: true)

Link to the code that reproduces this issue

https://github.com/daanboer/next-citationjs-repro

To Reproduce

Setup and run the example code using:

pnpm install
pnpm build
pnpm start

Then visit localhost:3000. This will issue a client-side exception, and the formatted citation is not shown.

Describe the Bug

Using the @citation-js/core, and @citation-js/plugin-csl packages to format a CSL-json document results in a client-side exception when combined with swcMinify: true. Disabling swcMinify results in the desired behavior and the formatted citation is shown without any errors. This bug only occurs in production, enabling swcMinify in the dev environment works just fine.

Expected Behavior

The generated page should not issue any errors and show a formatted citation.

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

[LunaTK]

Having a same issue.

[avitorio]

Hey @daanboer and @LunaTK , I'm currently experiencing this. Did you all find a solution? My package breaks on next.js if swcMinify isn't set to false...

[daanboer]

Hey @daanboer and @LunaTK , I'm currently experiencing this. Did you all find a solution? My package breaks on next.js if swcMinify isn't set to false...

Nope, sadly I haven't found a solution, and the issue still persists.

[LunaTK]

Me neither. Still using next.js with swcMinify disabled :(

Seems like the bug is due to the duplicated identifier from minified code.

[kcrwfrd]

We started experiencing a TypeError from another package after upgrading to 14.2.3 ... if we set swcMinify: false or downgrade to 14.1.4, it works fine.

[daanboer]

Yes, this problem seems to have returned in 14.2.~. I have updated the reproduction example to the 14.3.0 canary. It now uses the app router and the error has moved to the build step. This issue starts to become more pressing, as swcMinify is being deprecated in the near future.

[huozhi]

@kcrwfrd @daanboer could you share a reproduction repo about your issue?

[daanboer]

@huozhi sure, a reproduction example can be found here: https://github.com/daanboer/next-citationjs-repro.

[huozhi]

Sorry for duplicated tagging, forgot to mention we're already investigating that one. Asking @\kcrwfrd 's case to see if it's a different case 🙏 thanks!

[kcrwfrd]

Sorry for duplicated tagging, forgot to mention we're already investigating that one. Asking @\kcrwfrd 's case to see if it's a different case 🙏 thanks!

My encounter with the bug involved another package so I don't have it isolated very well, but I can put something together @huozhi

[kcrwfrd]

@huozhi okay I just successfully put together a reproduction: https://github.com/kcrwfrd/next-swc-minify-bug-reproduction

Thanks for looking into it 🙏🏼

[kdy1]

swc-project/swc#8956 will fix this issue, and the issue reported by @kcrwfrd will be fixed by swc-project/swc#8957.
I'll close this with swc_core update PRs.

Thank you for reporting and creating a repro! Fixing a minifier bug is nearly impossible without a good repro.

[daanboer]

@kdy1 Thank you for treating this issue. I have updated the reproduction example to use the latest canary release (14.3.0-canary.70), but the problem still persists. Is this to be expected?

[github-actions]

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.