Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky css test and remove unused tests deps #47806

Merged
merged 5 commits into from Apr 1, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 1, 2023

  • use check to wait for css change
  • remove unused swr deps and update them to latest
  • remove swr esm test in app-dir/app/ since it's already covered in app-dir/app-external/

@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team labels Apr 1, 2023
@ijjk
Copy link
Member

ijjk commented Apr 1, 2023

Failing test suites

Commit: c589f14

pnpm testheadless test/e2e/app-dir/app/standalone.test.ts

  • output: standalone with app dir > should handle trace files correctly for route groups (nodejs only)
  • output: standalone with app dir > should work correctly with output standalone
Expand output

● output: standalone with app dir › should handle trace files correctly for route groups (nodejs only)

next build failed with code/signal 1

  77 |           if (code || signal)
  78 |             reject(
> 79 |               new Error(`next build failed with code/signal ${code || signal}`)
     |               ^
  80 |             )
  81 |           else resolve()
  82 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:79:15)

● output: standalone with app dir › should work correctly with output standalone

next build failed with code/signal 1

  77 |           if (code || signal)
  78 |             reject(
> 79 |               new Error(`next build failed with code/signal ${code || signal}`)
     |               ^
  80 |             )
  81 |           else resolve()
  82 |         })

  at ChildProcess.<anonymous> (lib/next-modes/next-start.ts:79:15)

Read more about building and testing Next.js in contributing.md.

pnpm testheadless test/e2e/app-dir/app-css/index.test.ts

  • app dir css > Suspensey CSS > should timeout if the resource takes too long
Expand output

● app dir css › Suspensey CSS › should timeout if the resource takes too long

TIMED OUT: /background = rgb\(0, 0, 0\)/

background = rgba(0, 0, 0, 0)

undefined

  569 |
  570 |   if (hardError) {
> 571 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  572 |   }
  573 |   return false
  574 | }

  at check (lib/next-test-utils.js:571:11)
  at Object.<anonymous> (e2e/app-dir/app-css/index.test.ts:517:11)

Read more about building and testing Next.js in contributing.md.

@huozhi huozhi marked this pull request as ready for review April 1, 2023 23:36
@ijjk ijjk merged commit 5c6b8ac into vercel:canary Apr 1, 2023
6 of 37 checks passed
@huozhi huozhi deleted the fix/flaky-css-test branch April 2, 2023 08:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants