router.push("/") broken when intercepting routes as modal with parallel routes

[pedro757]

Verify canary release

• I verified that the issue exists in the latest Next.js canary release

Provide environment information

    Operating System:
      Platform: linux
      Arch: x64
      Version: #1 SMP PREEMPT_DYNAMIC Sun Jun  4 12:31:46 UTC 2023
    Binaries:
      Node: 18.16.0
      npm: 9.6.7
      Yarn: N/A
      pnpm: 8.6.1
    Relevant packages:
      next: 13.4.7
      eslint-config-next: 13.4.7
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.1.3

Which area(s) of Next.js are affected? (leave empty if unsure)

No response

Link to the code that reproduces this issue or a replay of the bug

https://codesandbox.io/p/sandbox/fast-bush-qlpdwm?file=%2Fapp%2Fhome%2Fpage.tsx

To Reproduce

use push("/") in a modal

Describe the Bug

This is what I get

Expected Behavior

I expect it to actually redirect me to the path I telling it to redirect

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

[m10rten]

Relatable issue here:
When having a modal in @modal folder that is a intercepted version of another page eg: signin modal, intercepted from /signin.
Whenever I press a <Link href="terms" /> it does not remove the modal, even though I set this in my Dialog from @shadcn ui:

"use client";

import { useRouter } from "next/navigation";
import SigninContent from "@/app/(auth)/signin/content";
import { Dialog, DialogContent } from "@/components/ui/dialog";

export default function SigninModalContent() {
  const router = useRouter();
  const handleOnOpenChange = (open: boolean) => {
    if (!open) {
      router.back();
    }
  };
  return (
    <Dialog open={true} onOpenChange={handleOnOpenChange}>
      <DialogContent>
        <SigninContent />
      </DialogContent>
    </Dialog>
  );
}

[m10rten]

Relatable issue here: When having a modal in @modal folder that is a intercepted version...

I think I did something

  useEffect(() => {
    if (path !== "/signin") {
      setOpen(false);
    } else {
      setOpen(true);
    }
  }, [path]);

[m10rten]

To comment on main issue, I've seen a default.tsx with return null; in many projects, that could be the case.

[BrunoFerreira95]

Check the import
import { useRouter } from 'next/router'
or
import { useRouter } from 'next/navigation'

maybe be valide.
A new update in the docs about the defalut.tsx was release.

[TheLexoPlexx]

Probably the same issue here: I fixed it through push to the parent directory first. I don't know why that works: https://github.com/TheLexoPlexx/senator/blob/ca7385cda942c2dced692bcf014783db6b8c9e86/app/einsatzplanung/%5Bid%5D/%40user/add/setUsersForm.tsx#L24C3-L25

next 13.4.19

[pedro757]

This issue still persist in v13.5.2

[david0178418]

Seems related to #49662

As noted by others in the ticket, routing back is working. But pushing new state does not. Even using the native (navigation || history).back() will unmount the modal. But history.pushState(...) does not, which I'd imagine Link is using under the hood with simple linking fallback when js is not enabled.

[jchamale]

Happening to me as well, I'm intercepting a route like /member/menu/card and in this dialog I want to move to /member/menu/information. The intercept route never closes the dialog.

[samcx]

@pedro757 Thank you for submitting an issue!

I don't think this is an issue anymore with router.back() or router.push(), but I believe router.refresh() is still broken → #51714.

Let me know if you can confirm so we can close this issue in favor of the one I shared (the other one you created)!

[pedro757]

Hey @samcx ! Thanks for addressing this issue, I just updated the code sandbox to the latest canary v14.0.5-canary.45 and I see the background component (not the modal) disappears when refreshing, idk if that's the expected behavior. Other than that I believe router.back() androuter.refresh() are working good considering this sandbox. I haven't used this functionality in a real project though.

You can check out the code sandbox to make sure that's the expected behavior.

If everything is alright I guess you can close both issues in next release.

[samcx]

@pedro757 I can confirm this is a separate 🐛 with router.refresh()—the /home/add should not disappear after router.refresh(). I have shared this with the team to take a look!

[github-actions]

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.