Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate links in shared documentation #51733

Merged
merged 12 commits into from Jun 28, 2023
Merged

Add separate links in shared documentation #51733

merged 12 commits into from Jun 28, 2023

Conversation

tyler-lutz
Copy link
Contributor

What?

  • Added separate links for the app and pages router in the shared documentation.
  • Added comment at the top of all shared documentation.
  • Fixed typos in pages documentation comment.

Why?

  • To limit the switching between the different routers in shared documentation when clicking the links.

@tyler-lutz
Add separate links in shared documentation
d559ca6 
Use the PagesOnly and AppOnly components to add separate links in shared documentation in order to limit switching between router documentation when clicking these links.
I also added comments at the beginning of the shared documentation files stating they are shared.
@tyler-lutz
Merge branch 'vercel:canary' into 06-23-Separate-links-in-shared-docs
9cd65a9
@ijjk ijjk added area: documentation Font (next/font) Related to Next.js Font Optimization. labels Jun 24, 2023
@ijjk
Copy link
Member

ijjk commented Jun 24, 2023 •
edited by styfle

Allow CI Workflow Run

  • approve CI run for commit: c64677b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@tyler-lutz tyler-lutz mentioned this pull request Jun 24, 2023
Closed
tyler-lutz and others added 3 commits June 27, 2023 15:29
@tyler-lutz
Update assetPrefix.mdx
d867bd4 
- Remove getServerSideProps and getStaticProps from AppOnly documentation.
@styfle
Merge branch 'canary' into 06-23-Separate-links-in-shared-docs
377915f
@tyler-lutz
Fix broken links
4bcdcd0
@vercel vercel deleted a comment from ijjk Jun 28, 2023
@styfle styfle requested review from a team and leerob as code owners June 28, 2023 22:53
@styfle styfle added CI approved Approve running CI for fork and removed Font (next/font) Related to Next.js Font Optimization. labels Jun 28, 2023
@styfle styfle mentioned this pull request Jun 28, 2023
Closed
@kodiakhq kodiakhq bot merged commit 1f19a5b into vercel:canary Jun 28, 2023
60 checks passed
@tyler-lutz tyler-lutz deleted the 06-23-Separate-links-in-shared-docs branch June 29, 2023 03:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim

@timeyoutakeit timeyoutakeit Awaiting requested review from timeyoutakeit timeyoutakeit is a code owner automatically assigned from vercel/devex

@Nutlope Nutlope Awaiting requested review from Nutlope Nutlope is a code owner automatically assigned from vercel/devex

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
CI approved Approve running CI for fork locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tyler-lutz @ijjk @styfle