Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify bench scripts to not conflict with dev task #54600

Merged
merged 3 commits into from Aug 26, 2023
Merged

modify bench scripts to not conflict with dev task #54600

merged 3 commits into from Aug 26, 2023

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Aug 26, 2023

I don't believe these benches were intended to run as part of the monorepo dev task. This renames the dev task to dev-application similar to build-application (which I assume was aliased for a similar reason)

Fixes #54592

@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team labels Aug 26, 2023
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@ztanner ztanner marked this pull request as ready for review August 26, 2023 16:11
@kodiakhq kodiakhq bot merged commit 40b3226 into canary Aug 26, 2023
51 of 54 checks passed
@kodiakhq kodiakhq bot deleted the fix/dev branch August 26, 2023 22:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm dev not working with next.js source code
2 participants