Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CacheNode.data → .lazyData #59473

Merged
merged 1 commit into from Dec 11, 2023
Merged

Rename CacheNode.data → .lazyData #59473

merged 1 commit into from Dec 11, 2023

Conversation

acdlite
Copy link
Contributor

@acdlite acdlite commented Dec 11, 2023 •
edited

CacheNode.data is used to lazily kick off a request during render, and represents the result of the entire Flight response. It doesn't correspond directly to the RSC data of the cache node itself — that's subTreeData. To complicate things further, I'm about to add another field to CacheNode that represents prefetched RSC data.

To make it a little less confusing, I've renamed the data field to lazyData. Still not perfectly clear on first glance, but it's at least more specific. With PPR, the goal is to remove the lazy data fetching mechanism in favor of initiating the request immediately upon navigation. So this field will eventually go away.

In the next PR, I will rename subTreeData, too. Perhaps something with "rsc" in the name so it's less generic than "data".

Closes NEXT-1843

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Dec 11, 2023
@acdlite acdlite force-pushed the rename-cachenode.data-lazydata branch from 7598b38 to 2f2a2e5 Compare December 11, 2023 04:01
@ijjk
Copy link
Member

ijjk commented Dec 11, 2023 •
edited

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary acdlite/next.js rename-cachenode.data-lazydata Change
buildDuration 10.6s 10.4s N/A
buildDurationCached 6s 6s N/A
nodeModulesSize 200 MB 200 MB ⚠️ +778 B
nextStartRea..uration (ms) 420ms 424ms N/A
Client Bundles (main, webpack)
vercel/next.js canary acdlite/next.js rename-cachenode.data-lazydata Change
170-HASH.js gzip 26.7 kB 26.7 kB N/A
199.HASH.js gzip 181 B 185 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB ✓
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 240 B 241 B N/A
main-HASH.js gzip 31.7 kB 31.6 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary acdlite/next.js rename-cachenode.data-lazydata Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary acdlite/next.js rename-cachenode.data-lazydata Change
_app-HASH.js gzip 195 B 194 B N/A
_error-HASH.js gzip 183 B 182 B N/A
amp-HASH.js gzip 501 B 501 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 255 B ✓
head-HASH.js gzip 349 B 350 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 309 B N/A
script-HASH.js gzip 384 B 384 B ✓
withRouter-HASH.js gzip 307 B 306 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 1.57 kB 1.57 kB ✓
Client Build Manifests
vercel/next.js canary acdlite/next.js rename-cachenode.data-lazydata Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary acdlite/next.js rename-cachenode.data-lazydata Change
index.html gzip 529 B 527 B N/A
link.html gzip 543 B 540 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary acdlite/next.js rename-cachenode.data-lazydata Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 146 kB 146 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary acdlite/next.js rename-cachenode.data-lazydata Change
middleware-b..fest.js gzip 626 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 37.4 kB 37.4 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 2.07 kB 2.07 kB ✓
Next Runtimes
vercel/next.js canary acdlite/next.js rename-cachenode.data-lazydata Change
app-page-exp...dev.js gzip 168 kB 168 kB ✓
app-page-exp..prod.js gzip 93.9 kB 93.9 kB ✓
app-page-tur..prod.js gzip 94.7 kB 94.7 kB ✓
app-page-tur..prod.js gzip 89.2 kB 89.2 kB ✓
app-page.run...dev.js gzip 138 kB 138 kB ✓
app-page.run..prod.js gzip 88.5 kB 88.5 kB ✓
app-route-ex...dev.js gzip 23.9 kB 23.9 kB ✓
app-route-ex..prod.js gzip 16.6 kB 16.6 kB ✓
app-route-tu..prod.js gzip 16.6 kB 16.6 kB ✓
app-route-tu..prod.js gzip 16.2 kB 16.2 kB ✓
app-route.ru...dev.js gzip 23.4 kB 23.4 kB ✓
app-route.ru..prod.js gzip 16.2 kB 16.2 kB ✓
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB ✓
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB ✓
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 22.5 kB 22.5 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 49.4 kB 49.4 kB ✓
Overall change 929 kB 929 kB ✓
Diff details
Diff for page.js

Diff too large to display

Diff for 170-HASH.js

Diff too large to display

Commit: 2048564

@acdlite acdlite marked this pull request as ready for review December 11, 2023 04:17
@acdlite
Rename CacheNode.data -> .lazyData
2048564 
`CacheNode.data` is used to lazily kick off a request during render, and
represents the result of the entire Flight response. It doesn't
correspond directly to the RSC data of the cache node itself — that's
`subTreeData`. To complicate things further, I'm about to add another
field to CacheNode that represents prefetched RSC data.

To make it a little less confusing, I've renamed the `data` field to
`lazyData`. Still not perfectly clear on first glance, but it's at least
more specific. With PPR, the goal is to remove the lazy data fetching
mechanism in favor of initiating the request immediately upon
navigation. So this field will eventually go away.

In the next PR, I will rename `subTreeData`, too. Perhaps something with
"rsc" in the name so it's less generic than "data".
@acdlite acdlite force-pushed the rename-cachenode.data-lazydata branch from 2f2a2e5 to 2048564 Compare December 11, 2023 15:40
@acdlite acdlite mentioned this pull request Dec 11, 2023
Merged
huozhi
huozhi approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@huozhi huozhi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to rename

@acdlite acdlite merged commit c2ab5f7 into vercel:canary Dec 11, 2023
69 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acdlite @ijjk @huozhi