Rename CacheNode.subTreeData -> .rsc #59491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
area: tests
created-by: Next.js team
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
Diff detailsDiff for page.jsDiff too large to display Diff for 170-HASH.jsDiff too large to display |
acdlite
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
I want to give this field a name that's bit less generic and distinguishes it from `lazyData` (because that one has a different type and is a special case we want to eventually remove). I'm also about to add an optional `prefetchRsc` field that represents a prefetched version of the same value. The common suffix is meant to communicate how they are related. Doing this rename in its own PR because it's a pure find-and-replace, whereas the later steps are not.
acdlite
force-pushed
the
rename-cachenode.subTreeData-rsc
branch
from
49ac8b4
to
b242431
Compare
huozhi
reviewed
Dec 11, 2023
| @@ -149,7 +149,7 @@ function HistoryUpdater({ | |||
|
|
|||
| export const createEmptyCacheNode = () => ({ | |||
| lazyData: null, | |||
| subTreeData: null, | |||
| rsc: null, | |||
There was a problem hiding this comment.
Do we consider to call it sth like rscNode or any related to "node" as the type is ReactNode, rsc makes me think of rsc payload data
There was a problem hiding this comment.
Yeah maybe but even rscNode could refer to something that was rendered by RSC but is not renderable on the client. It would have to be something more like rscReactNode but I don't know if that really does much to clarify. I think in this case we can rely on the type to communicate it.
huozhi
approved these changes
Dec 11, 2023
ztanner
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to give this field a name that's bit less generic and distinguishes it from
lazyData(because that one has a different type and is a special case we want to eventually remove).I'm also about to add an optional
prefetchRscfield that represents a prefetched version of the same value. The common suffix is meant to communicate how they are related.Doing this rename in its own PR because it's a pure find-and-replace, whereas the later steps are not.
Closes NEXT-1846