Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(next-swc): Provide tokio context required for WASM plugins #62441

Merged
merged 6 commits into from
Feb 28, 2024
Merged

fix(next-swc): Provide tokio context required for WASM plugins #62441

merged 6 commits into from
Feb 28, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 23, 2024 •
edited

What?

Run transforms with the tokio context so Wasmer works properly.

Why?

To allow invoking Wasm plugins. wasmer had a breaking change.

How?

Closes PACK-2587
Closes #62081

@ijjk ijjk added created-by: Turbopack team PRs by the turbopack team type: next labels Feb 23, 2024
@ijjk
Copy link
Member

ijjk commented Feb 23, 2024 •
edited

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js kdy1/wasmer-tokio Change
buildDuration 14s 14.1s ⚠️ +137ms
buildDurationCached 7.7s 6.4s N/A
nodeModulesSize 197 MB 197 MB ✓
nextStartRea..uration (ms) 412ms 417ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/wasmer-tokio Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 242 B ✓
main-HASH.js gzip 32.1 kB 32.2 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.6 kB 45.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/wasmer-tokio Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js kdy1/wasmer-tokio Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.56 kB 6.56 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/wasmer-tokio Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/wasmer-tokio Change
index.html gzip 528 B 526 B N/A
link.html gzip 541 B 539 B N/A
withRouter.html gzip 523 B 522 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/wasmer-tokio Change
edge-ssr.js gzip 95 kB 95 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js kdy1/wasmer-tokio Change
middleware-b..fest.js gzip 624 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 990 B 990 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/wasmer-tokio Change
app-page-exp...dev.js gzip 171 kB 171 kB ✓
app-page-exp..prod.js gzip 96.7 kB 96.7 kB ✓
app-page-tur..prod.js gzip 98.5 kB 98.5 kB ✓
app-page-tur..prod.js gzip 92.9 kB 92.9 kB ✓
app-page.run...dev.js gzip 150 kB 150 kB ✓
app-page.run..prod.js gzip 91.4 kB 91.4 kB ✓
app-route-ex...dev.js gzip 21.3 kB 21.3 kB ✓
app-route-ex..prod.js gzip 15 kB 15 kB ✓
app-route-tu..prod.js gzip 15 kB 15 kB ✓
app-route-tu..prod.js gzip 14.8 kB 14.8 kB ✓
app-route.ru...dev.js gzip 20.9 kB 20.9 kB ✓
app-route.ru..prod.js gzip 14.8 kB 14.8 kB ✓
pages-api-tu..prod.js gzip 9.51 kB 9.51 kB ✓
pages-api.ru...dev.js gzip 9.79 kB 9.79 kB ✓
pages-api.ru..prod.js gzip 9.51 kB 9.51 kB ✓
pages-turbo...prod.js gzip 22.3 kB 22.3 kB ✓
pages.runtim...dev.js gzip 23 kB 23 kB ✓
pages.runtim..prod.js gzip 22.3 kB 22.3 kB ✓
server.runti..prod.js gzip 50.6 kB 50.6 kB ✓
Overall change 950 kB 950 kB ✓
build cache
vercel/next.js canary vercel/next.js kdy1/wasmer-tokio Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 105 kB 104 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for middleware.js

Diff too large to display

Commit: c992f7b

@kdy1 kdy1 self-assigned this Feb 26, 2024
sokra
sokra reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

napi provides a tokio runtime. Could we use that instead of creating a new one?

@kdy1
Copy link
Member Author

kdy1 commented Feb 27, 2024 •
edited

@sokra We need to move operations like cloning the options slice to the main JS thread if we want to do so.

image
  • We can't use Buffer from the inline future because it's not Send. So we need to parse option from the main thread and pass something that is Send to the async future.
  • We can't use AbortSignal anymore

@kdy1
Copy link
Member Author

kdy1 commented Feb 27, 2024

Fixed.

@ijjk
Copy link
Member

ijjk commented Feb 27, 2024 •
edited

Tests Passed

@ForsakenHarmony ForsakenHarmony changed the title fix(next-swc): Provide tokio context required for Wasm plguins fix(next-swc): Provide tokio context required for WASM plugins Feb 27, 2024
@kdy1 kdy1 merged commit cea5366 into canary Feb 28, 2024
70 checks passed
@kdy1 kdy1 deleted the kdy1/wasmer-tokio branch February 28, 2024 02:28
@orionmiz orionmiz mentioned this pull request Mar 3, 2024
Closed
1 task
kdy1 added a commit that referenced this pull request Mar 8, 2024
@kdy1
Revert "fix(next-swc): Provide tokio context required for WASM plugins (
b5f7539 
#62441)"

This reverts commit cea5366.
@kdy1 kdy1 mentioned this pull request Mar 8, 2024
Merged
kdy1 added a commit that referenced this pull request Mar 12, 2024
@kdy1
Revert "fix(next-swc): Provide tokio context required for WASM plugins (
7c6ee22 
#62441)"

This reverts commit cea5366.
sokra pushed a commit that referenced this pull request Mar 13, 2024
@kdy1 @sokra
Revert "fix(next-swc): Provide tokio context required for WASM plugins (
13f9f02 
#62441)"

This reverts commit cea5366.
sokra added a commit that referenced this pull request Mar 13, 2024
@kdy1 @sokra
chore: Update swc_core to v0.90.21 (#63031)
013ba06 
### What?

- Update `swc_core` to fix performance regression caused by the creation
of the `tokio` runtime.

This PR practically reverts
#62441.

 - Apply various minifier bug fixes.

   - swc-project/swc#8730
   - swc-project/swc#8733
   - swc-project/swc#8725
   - swc-project/swc#8726
   - swc-project/swc#8727

- Apply swc-project/plugins#271 (Closes
PACK-2714)


### Why?

Someone reported a performance regression. See
swc-project/swc#8708

### How?

Closes PACK-2693

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees

@kdy1 kdy1

Labels
created-by: Turbopack team PRs by the turbopack team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't run application with any custom SWC plugin
4 participants
@kdy1 @ijjk @sokra @ForsakenHarmony