Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mini-css-extract-plugin #62698

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

neomad1337
Copy link
Contributor

For Contributors

What?

This PR upgrades the mini-css-extract-plugin dependency

Why?

In this version, the bug related to content hash is fixed. This bug causes different hashes of CSS chunks in the webpack chunk.

How?

Closes NEXT-1146
Fixes #49230

Copy link

socket-security bot commented Feb 29, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/mini-css-extract-plugin@2.4.4 unsafe Transitive: environment, eval, filesystem, network, shell +84 20.6 MB evilebottnawi

🚮 Removed packages: npm/mini-css-extract-plugin@2.4.3

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Feb 29, 2024

Allow CI Workflow Run

  • approve CI run for commit: aaa0dba

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Feb 29, 2024

Allow CI Workflow Run

  • approve CI run for commit: aaa0dba

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@samcx samcx enabled auto-merge (squash) February 29, 2024 21:10
@ijjk
Copy link
Member

ijjk commented Feb 29, 2024

Stats from current PR

Default Build
General
vercel/next.js canary neomad1337/next.js update-mini-css-extract Change
buildDuration 13.9s 13.8s N/A
buildDurationCached 8.4s 6.2s N/A
nodeModulesSize 198 MB 198 MB
nextStartRea..uration (ms) 405ms 412ms N/A
Client Bundles (main, webpack)
vercel/next.js canary neomad1337/next.js update-mini-css-extract Change
2453-HASH.js gzip 30.4 kB 30.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.6 kB 45.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary neomad1337/next.js update-mini-css-extract Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary neomad1337/next.js update-mini-css-extract Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.56 kB 6.56 kB
Client Build Manifests
vercel/next.js canary neomad1337/next.js update-mini-css-extract Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary neomad1337/next.js update-mini-css-extract Change
index.html gzip 529 B 526 B N/A
link.html gzip 542 B 539 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary neomad1337/next.js update-mini-css-extract Change
edge-ssr.js gzip 95 kB 95 kB N/A
page.js gzip 3.07 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary neomad1337/next.js update-mini-css-extract Change
middleware-b..fest.js gzip 623 B 623 B
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.61 kB 1.61 kB
Next Runtimes
vercel/next.js canary neomad1337/next.js update-mini-css-extract Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.7 kB 96.7 kB
app-page-tur..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 92.9 kB 92.9 kB
app-page.run...dev.js gzip 150 kB 150 kB
app-page.run..prod.js gzip 91.4 kB 91.4 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 20.9 kB 20.9 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.51 kB 9.51 kB
pages-api.ru...dev.js gzip 9.79 kB 9.79 kB
pages-api.ru..prod.js gzip 9.51 kB 9.51 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 23 kB 23 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.6 kB 50.6 kB
Overall change 950 kB 950 kB
build cache
vercel/next.js canary neomad1337/next.js update-mini-css-extract Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 105 kB 104 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: e7046b0

@samcx samcx merged commit c6e865b into vercel:canary Feb 29, 2024
64 checks passed
ijjk added a commit that referenced this pull request Feb 29, 2024
Update precompiled related to below dependencies upgrades 

x-ref: #62698
x-ref: #62644

Closes NEXT-2649

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEXT-1146] Hashes are different between multiple servers with generateBuildId
4 participants