Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(next-swc): Pass names of side-effect-free packages #63268

Merged
merged 15 commits into from
Mar 29, 2024
Merged

feat(next-swc): Pass names of side-effect-free packages #63268

merged 15 commits into from
Mar 29, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 14, 2024

What?

Pass the names of side-effect-free packages specified in experimental.optimizePackageImports.

Turbopack counterpart: vercel/turbo#7731

Why?

Some packages like @tremor/react causes a problem without optimizePackageImports.

How?

Closes PACK-2527

@kdy1 kdy1 self-assigned this Mar 14, 2024
@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Mar 14, 2024
@ijjk
Copy link
Member

ijjk commented Mar 14, 2024 •
edited

Tests Passed

@ijjk
Copy link
Member

ijjk commented Mar 14, 2024 •
edited

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js kdy1/pack-2527 Change
buildDuration 13.9s 14s ⚠️ +118ms
buildDurationCached 7.6s 6.2s N/A
nodeModulesSize 199 MB 198 MB N/A
nextStartRea..uration (ms) 399ms 402ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/pack-2527 Change
2453-HASH.js gzip 31.4 kB 31 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB ✓
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 242 B ✓
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/pack-2527 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js kdy1/pack-2527 Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.57 kB 6.57 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/pack-2527 Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/pack-2527 Change
index.html gzip 530 B 529 B N/A
link.html gzip 542 B 541 B N/A
withRouter.html gzip 524 B 524 B ✓
Overall change 524 B 524 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/pack-2527 Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js kdy1/pack-2527 Change
middleware-b..fest.js gzip 626 B 626 B ✓
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 1.62 kB 1.62 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/pack-2527 Change
app-page-exp...dev.js gzip 170 kB 170 kB N/A
app-page-exp..prod.js gzip 97 kB 97 kB N/A
app-page-tur..prod.js gzip 98.8 kB 98.7 kB N/A
app-page-tur..prod.js gzip 93 kB 93 kB N/A
app-page.run...dev.js gzip 144 kB 144 kB N/A
app-page.run..prod.js gzip 91.5 kB 91.5 kB N/A
app-route-ex...dev.js gzip 21.4 kB 21.4 kB N/A
app-route-ex..prod.js gzip 15.2 kB 15.1 kB N/A
app-route-tu..prod.js gzip 15.2 kB 15.1 kB N/A
app-route-tu..prod.js gzip 14.9 kB 14.8 kB N/A
app-route.ru...dev.js gzip 21.1 kB 21 kB N/A
app-route.ru..prod.js gzip 14.9 kB 14.8 kB N/A
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB ✓
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB ✓
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.1 kB 23.1 kB ✓
pages.runtim..prod.js gzip 22.4 kB 22.4 kB ✓
server.runti..prod.js gzip 51 kB 51 kB ✓
Overall change 148 kB 148 kB ✓
build cache
vercel/next.js canary vercel/next.js kdy1/pack-2527 Change
0.pack gzip 1.58 MB 1.57 MB N/A
index.pack gzip 106 kB 106 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 2453-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: 4d41c6e

@kdy1 kdy1 mentioned this pull request Mar 14, 2024
Merged
@kdy1 kdy1 force-pushed the kdy1/pack-2527 branch 2 times, most recently from 749854d to 84c8c49 Compare March 19, 2024 06:49
kdy1 added a commit to vercel/turbo that referenced this pull request Mar 28, 2024
@kdy1
feat(turbopack): Support marking packages as side-effect-free (#7731)
ad6b88b 
### Description

This is required to support `experimental.optimizePackageImports` of `next.config.js`.

next.js counterpart: vercel/next.js#63268

Closes PACK-2527

### Testing Instructions

Look at the test case I added to vercel/next.js#63268
@kdy1 kdy1 marked this pull request as ready for review March 28, 2024 07:40
@kdy1 kdy1 requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners March 28, 2024 07:40
@kdy1 kdy1 enabled auto-merge (squash) March 28, 2024 07:40
@kdy1 kdy1 marked this pull request as draft March 29, 2024 05:05
auto-merge was automatically disabled March 29, 2024 05:05

Pull request was converted to draft

@kdy1 kdy1 mentioned this pull request Mar 29, 2024
Closed
@kdy1 kdy1 marked this pull request as ready for review March 29, 2024 05:51
@kdy1 kdy1 enabled auto-merge (squash) March 29, 2024 05:51
@kdy1 kdy1 merged commit 29d53c8 into canary Mar 29, 2024
78 checks passed
@kdy1 kdy1 deleted the kdy1/pack-2527 branch March 29, 2024 06:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees

@kdy1 kdy1

Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdy1 @ijjk @sokra