Turbopack: "Cannot find module" when package require() a package installed via the optionalDependencies field in package.json

[pilcrowOnPaper]

Link to the code that reproduces this issue

https://github.com/pilcrowOnPaper/repro-nextjs-turbopack-optional-dependencies

To Reproduce

1. Start dev server with pnpm dev

Current vs. Expected behavior

I expect the dev server to not crash

Provide environment information

Operating System:
  Platform: darwin
  Arch: arm64
  Version: Darwin Kernel Version 23.4.0: Wed Feb 21 21:44:54 PST 2024; root:xnu-10063.101.15~2/RELEASE_ARM64_T6030
  Available memory (MB): 36864
  Available CPU cores: 11
Binaries:
  Node: 21.7.0
  npm: 10.5.0
  Yarn: N/A
  pnpm: 8.15.4
Relevant Packages:
  next: 14.2.0-canary.48 // Latest available version is detected (14.2.0-canary.48).
  eslint-config-next: 14.1.0
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.4.3
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

Package manager (npm, pnpm, Yarn), Turbopack (--turbo)

Which stage(s) are affected? (Select all that apply)

next dev (local)

Additional context

No response

_PACK-2925

[timneutkens]

Just double checked and it seems that this isn't specific to Turbopack? I can see the same error when running with webpack.

I.e. changing the dev script to next dev: https://codesandbox.io/p/github/pilcrowOnPaper/repro-nextjs-turbopack-optional-dependencies/csb-78d4k5/draft/youthful-diffie?file=%2Fpackage.json%3A15%2C23

Seems @node-rs/argon2 just can't be bundled and needs to be added to the list of external packages, argon2 is already in there: https://github.com/vercel/next.js/blob/canary/packages/next/src/lib/server-external-packages.json#L15, maybe it was changed to @node-rs/ recently. Will open a PR to add it.

Here's an example with serverComponentsExternalPackages manually added: https://codesandbox.io/p/github/pilcrowOnPaper/repro-nextjs-turbopack-optional-dependencies/csb-p9q66w/draft/tender-rain?file=%2Fnext.config.mjs

[timneutkens]

Opened #65204 to address this. Added additional details and made sure oslo is also in there, that way Lucia should work automatically, you'll no longer have to edit next.config.js when adding Lucia 👍

[pilcrowOnPaper]

You seem to be correct - apologies for that!

The error was similar to the ones I got when when importing oslo/password (which imports @node-rs/argon2) even with serverComponentsExternalPackages, so I just assumed it was an issue with @node-rs/argon2 and Turbopack. I'll try to see what's causing the issues with oslo/password and Turbopack.

[timneutkens]

Thanks for checking @pilcrowOnPaper, can you confirm it's fixed with next@canary? Just to double check you no longer need custom configuration 👍

[pilcrowOnPaper]

Thanks, that seems to have fixed the issue! Though, bad timing since we're planning to remove oslo/password due to various issues (including this) so I think I'll send a PR removing oslo from the list when we release a new major version. Still, having @node-rs/argon2 excluded by default is super helpful!

[timneutkens]

Awesome, thanks for checking! Yeah it's fine to remove it later, overall it doesn't really hurt to have it external and the older version of Lucia people use would still have the version of oslo included so probably fine to leave it for a few months.

[github-actions]

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.