Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use string-hash instead of imurmurhash in Terser plugin #6939

Closed
timneutkens opened this issue Apr 8, 2019 · 1 comment · Fixed by #6964
Closed

Use string-hash instead of imurmurhash in Terser plugin #6939

timneutkens opened this issue Apr 8, 2019 · 1 comment · Fixed by #6964
Assignees
@lfades

Comments

@timneutkens
Copy link
Member

string-hash is already a dependency (and used in styled-jsx too). imurmurhash is not used anywhere else.
@lfades lfades mentioned this issue Apr 9, 2019
Merged
@dav-is
Copy link
Contributor

dav-is commented Apr 9, 2019

imurmurhash is used in cacache (which is used in terser-webpack-plugin and lerna)

timneutkens pushed a commit that referenced this issue Apr 9, 2019
@timneutkens
Replace imurmurhash with string-hash (#6964)
f89bd82 
Closes #6939
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lfades lfades

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace imurmurhash with string-hash lfades/next.js
3 participants
@lfades @timneutkens @dav-is