Add required `permanent: boolean` field to redirect #10044

ijjk · 2020-01-10T21:03:03Z

As discussed this requires a permanent: true/false value be specified if a statusCode isn't. This helps prevent us from inaccurately assuming a default redirect status for the user.

Allowing the user to tell us whether it's permanent or not creates a safer config than having them try to figure out the correct status code to use

…irect-field

ijjk · 2020-01-10T21:12:13Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
buildDuration	13.5s	13.5s	⚠️ +23ms
nodeModulesSize	49 MB	49 MB	⚠️ +964 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
buildDuration	14.1s	14s	-130ms
nodeModulesSize	49 MB	49 MB	⚠️ +964 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.4 kB	67.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
main-HASH.module.js gzip	4.17 kB	4.17 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_error.js gzip	77.8 kB	77.8 kB	⚠️ +13 B
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78 kB	⚠️ +13 B
link.js gzip	80.4 kB	80.4 kB	⚠️ +13 B
routerDirect.js gzip	78.1 kB	78.1 kB	⚠️ +14 B
withRouter.js gzip	78.1 kB	78.1 kB	⚠️ +14 B
Overall change	393 kB	393 kB	⚠️ +67 B

Commit: 5adbf6b

test/integration/custom-routes/test/index.test.js

…irect-field

ijjk · 2020-01-13T16:41:28Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
buildDuration	12.7s	12.8s	⚠️ +99ms
nodeModulesSize	49 MB	49 MB	⚠️ +1.02 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
main-HASH.module.js gzip	4.18 kB	4.18 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.06 kB	3.06 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
buildDuration	13.3s	13.2s	-135ms
nodeModulesSize	49 MB	49 MB	⚠️ +1.02 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
main-HASH.module.js gzip	4.18 kB	4.18 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_error.js gzip	77.8 kB	77.8 kB	⚠️ +14 B
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78 kB	⚠️ +13 B
link.js gzip	80.4 kB	80.4 kB	⚠️ +13 B
routerDirect.js gzip	78.1 kB	78.1 kB	⚠️ +14 B
withRouter.js gzip	78.1 kB	78.1 kB	⚠️ +13 B
Overall change	393 kB	393 kB	⚠️ +67 B

Commit: b97a644

Timer

LGTM

ijjk · 2020-01-14T18:26:22Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
buildDuration	13.3s	13.1s	-117ms
nodeModulesSize	49 MB	49 MB	⚠️ +1.02 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
main-HASH.module.js gzip	4.18 kB	4.18 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.06 kB	3.06 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
buildDuration	13.8s	13.8s	⚠️ +29ms
nodeModulesSize	49 MB	49 MB	⚠️ +1.02 kB

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
main-HASH.module.js gzip	4.18 kB	4.18 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/permanent-redirect-field	Change
_error.js gzip	77.8 kB	77.8 kB	⚠️ +14 B
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78 kB	⚠️ +13 B
link.js gzip	80.4 kB	80.4 kB	⚠️ +13 B
routerDirect.js gzip	78.1 kB	78.1 kB	⚠️ +14 B
withRouter.js gzip	78.1 kB	78.1 kB	⚠️ +13 B
Overall change	393 kB	393 kB	⚠️ +67 B

Commit: 8127db2

ijjk added 2 commits January 10, 2020 14:56

Add permanent field for redirects

b4b54a1

Merge remote-tracking branch 'upstream/canary' into add/permanent-red…

dbeeeb4

…irect-field

ijjk added the Type: Enhancement label Jan 10, 2020

ijjk added this to the 9.2.x milestone Jan 10, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners January 10, 2020 21:03

Update printing redirect status code

5adbf6b

timneutkens reviewed Jan 13, 2020

View reviewed changes

test/integration/custom-routes/test/index.test.js Outdated Show resolved Hide resolved

ijjk added 2 commits January 13, 2020 10:09

Merge remote-tracking branch 'upstream/canary' into add/permanent-red…

1c28e49

…irect-field

Don't add permanent to routes-manifest

b97a644

ijjk requested a review from timneutkens January 13, 2020 16:42

Timer modified the milestones: 9.2.x, 9.2.0 Jan 14, 2020

Timer added the ready to land label Jan 14, 2020

Timer approved these changes Jan 14, 2020

View reviewed changes

Timer changed the title ~~Add permanent redirect field for more streamlined redirects~~ Add required permanent: boolean field to redirect Jan 14, 2020

Merge branch 'canary' into add/permanent-redirect-field

8127db2

Timer merged commit 84264f8 into vercel:canary Jan 14, 2020

Timer deleted the add/permanent-redirect-field branch January 14, 2020 18:28

snyk-bot mentioned this pull request Feb 11, 2020

[Snyk] Upgrade next from 9.1.5 to 9.2.0 ndom91/newtelco-next-maintenance-mgmt#16

Merged

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add required `permanent: boolean` field to redirect #10044

Add required `permanent: boolean` field to redirect #10044

ijjk commented Jan 10, 2020

ijjk commented Jan 10, 2020

ijjk commented Jan 13, 2020

Timer left a comment

ijjk commented Jan 14, 2020

Add required permanent: boolean field to redirect #10044

Add required permanent: boolean field to redirect #10044

Conversation

ijjk commented Jan 10, 2020

ijjk commented Jan 10, 2020

Stats from current PR

ijjk commented Jan 13, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Jan 14, 2020

Stats from current PR

Add required `permanent: boolean` field to redirect #10044

Add required `permanent: boolean` field to redirect #10044