Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace brackets in CSS classes for dynamic routes #11795

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 9, 2020

This fixes classes generated for CSS modules for dynamic routes by replacing the brackets [] in the filename with underscores _

Closes: #11474
Closes: #10468

@ijjk ijjk added the Type: Bug label Apr 9, 2020
@ijjk ijjk added this to the 9.3.5 milestone Apr 9, 2020
@ijjk
Copy link
Member Author

ijjk commented Apr 9, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
buildDuration 8.7s 9.4s ⚠️ +701ms
nodeModulesSize 61 MB 61 MB ⚠️ +286 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
main-HASH.js gzip 6.25 kB 6.25 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.3 kB 56.3 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.5 kB 51.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
index.html gzip 917 B 917 B
link.html gzip 926 B 926 B
withRouter.html gzip 913 B 913 B
Overall change 2.76 kB 2.76 kB

Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
buildDuration 10.5s 10.7s ⚠️ +266ms
nodeModulesSize 61 MB 61 MB ⚠️ +286 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
main-HASH.js gzip 6.25 kB 6.25 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.3 kB 56.3 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.5 kB 51.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary ijjk/next.js add/NEXT-152-dynamic-route-css Change
_error.js gzip 233 kB 233 kB -312 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 956 B 956 B
index.js gzip 233 kB 233 kB ⚠️ +104 B
link.js gzip 243 kB 243 kB -18 B
routerDirect.js gzip 241 kB 241 kB ⚠️ +53 B
withRouter.js gzip 241 kB 241 kB -7 B
Overall change 1.19 MB 1.19 MB -180 B

@timneutkens timneutkens merged commit ab4ba04 into vercel:canary Apr 10, 2020
@timneutkens timneutkens deleted the add/NEXT-152-dynamic-route-css branch April 10, 2020 10:32
@Janpot
Copy link
Contributor

Janpot commented Apr 10, 2020

@ijjk Wouldn't the dots in catch-all routes be problematic as well?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants