Experimental: New ESLint Plugin #11986

janicklas-ralph · 2020-04-17T22:16:39Z

This PR sets up a basic ESLint plugin under @next namespace
The plugin will be published as @next/eslint-plugin-next

This plugin is still a WIP.

cc: @prateekbh

ijjk · 2020-04-17T22:23:26Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	12.2s	12.2s	-39ms
nodeModulesSize	55.5 MB	55.5 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.172	2.211	⚠️ +0.04
/ avg req/sec	1151.03	1130.85	-20.18
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.184	1.226	⚠️ +0.04
/error-in-render avg req/sec	2112.37	2039.08	-73.29

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	602 B	602 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	927 B	927 B	✓
link.html gzip	937 B	937 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	13s	12.9s	-92ms
nodeModulesSize	55.5 MB	55.5 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	602 B	602 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	594 kB	594 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

ijjk · 2020-04-17T22:29:20Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	11.3s	11.3s	-40ms
nodeModulesSize	55.5 MB	55.5 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.905	1.924	⚠️ +0.02
/ avg req/sec	1312.58	1299.57	-13.01
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.979	0.993	⚠️ +0.01
/error-in-render avg req/sec	2552.43	2518.31	-34.12

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	602 B	602 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	927 B	927 B	✓
link.html gzip	937 B	937 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	12.2s	12.3s	⚠️ +80ms
nodeModulesSize	55.5 MB	55.5 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	602 B	602 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	594 kB	594 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

ijjk · 2020-04-17T23:30:09Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	10.7s	10.8s	⚠️ +77ms
nodeModulesSize	55.5 MB	55.5 MB	✓

Page Load Tests Overall increase ✓

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.889	1.817	-0.07
/ avg req/sec	1323.8	1376.03	⚠️ +52.23
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.939	0.848	-0.09
/error-in-render avg req/sec	2661.84	2948.52	⚠️ +286.68

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	602 B	602 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	927 B	927 B	✓
link.html gzip	937 B	937 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	12.1s	11.4s	-686ms
nodeModulesSize	55.5 MB	55.5 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	602 B	602 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	594 kB	594 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

prateekbh · 2020-04-17T22:18:15Z

packages/next-plugin-eslint/lib/index.js

+  configs: {
+    recommended: {
+      rules: {
+        '@next/next/no-css-tags': 2,


lets start with 1 and then promote it to 2

prateekbh · 2020-04-20T17:11:29Z

packages/next-plugin-eslint/lib/rules/sync-scripts.js

+        context.report({
+          node,
+          message:
+            "A synchronous script tag in head, can impact your webpage's performance",


we are no more looking in head right?

prateekbh · 2020-04-20T17:12:13Z

packages/next-plugin-eslint/lib/index.js

+module.exports = {
+  rules: {
+    'no-css-tags': require('./rules/no-css-tags'),
+    'sync-scripts': require('./rules/sync-scripts'),


nit(just for convention sake): no-sync-scripts

ijjk · 2020-04-22T18:40:34Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	11.8s	11.6s	-219ms
nodeModulesSize	55.2 MB	55.2 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.955	1.97	⚠️ +0.01
/ avg req/sec	1278.62	1269.35	-9.27
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.937	1.199	⚠️ +0.26
/error-in-render avg req/sec	2666.93	2085.1	-581.83

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..45d6.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.87 kB	6.87 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	929 B	929 B	✓
link.html gzip	938 B	938 B	✓
withRouter.html gzip	925 B	925 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	12.5s	12.5s	-23ms
nodeModulesSize	55.2 MB	55.2 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..45d6.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.87 kB	6.87 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	595 kB	595 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

ijjk · 2020-04-22T18:45:58Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	11.5s	11.8s	⚠️ +300ms
nodeModulesSize	55.2 MB	55.2 MB	✓

Page Load Tests Overall increase ✓

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.958	1.962	0
/ avg req/sec	1276.61	1273.9	-2.71
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.035	0.977	-0.06
/error-in-render avg req/sec	2415.02	2559.24	⚠️ +144.22

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..45d6.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.87 kB	6.87 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	929 B	929 B	✓
link.html gzip	938 B	938 B	✓
withRouter.html gzip	925 B	925 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	12.3s	12.4s	⚠️ +99ms
nodeModulesSize	55.2 MB	55.2 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..45d6.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.87 kB	6.87 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	595 kB	595 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

timneutkens · 2020-04-28T17:07:38Z

packages/next-plugin-eslint/package.json

+    "directory": "packages/next-plugin-eslint"
+  },
+  "scripts": {
+    "test": "mocha tests --recursive"


Ideally we'll want to use jest or our global test suite instead of having it inside the package

ijjk · 2020-05-04T20:26:09Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	11.8s	11.9s	⚠️ +117ms
nodeModulesSize	57.5 MB	57.5 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.12	2.044	-0.08
/ avg req/sec	1179.28	1222.91	⚠️ +43.63
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.327	1.393	⚠️ +0.07
/error-in-render avg req/sec	1883.35	1795.04	-88.31

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39.2 kB	39.2 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.82 kB	4.82 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.2 kB	39.2 kB	✓
Overall change	51.7 kB	51.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	12.7s	12.5s	-193ms
nodeModulesSize	57.5 MB	57.5 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39.2 kB	39.2 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.82 kB	4.82 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.2 kB	39.2 kB	✓
Overall change	51.7 kB	51.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	853 kB	853 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	853 kB	853 kB	✓
link.js	891 kB	891 kB	✓
routerDirect.js	883 kB	883 kB	✓
withRouter.js	883 kB	883 kB	✓
Overall change	4.37 MB	4.37 MB	✓

ijjk · 2020-05-04T21:16:48Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	11.6s	11.9s	⚠️ +316ms
nodeModulesSize	57.5 MB	57.5 MB	✓

Page Load Tests Overall increase ✓

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.941	1.913	-0.03
/ avg req/sec	1288.14	1307.17	⚠️ +19.03
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.131	1.141	⚠️ +0.01
/error-in-render avg req/sec	2209.69	2191.4	-18.29

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39.2 kB	39.2 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.82 kB	4.82 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.2 kB	39.2 kB	✓
Overall change	51.7 kB	51.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	12.7s	12.4s	-258ms
nodeModulesSize	57.5 MB	57.5 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.28 kB	6.28 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39.2 kB	39.2 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.82 kB	4.82 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.2 kB	39.2 kB	✓
Overall change	51.7 kB	51.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	853 kB	853 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	853 kB	853 kB	✓
link.js	891 kB	891 kB	✓
routerDirect.js	883 kB	883 kB	✓
withRouter.js	883 kB	883 kB	✓
Overall change	4.37 MB	4.37 MB	✓

ijjk · 2020-05-04T22:10:23Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	10.7s	11s	⚠️ +299ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.842	1.809	-0.03
/ avg req/sec	1357.27	1382.31	⚠️ +25.04
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.057	1.108	⚠️ +0.05
/error-in-render avg req/sec	2365.21	2257.25	-107.96

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.23 kB	6.23 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39.2 kB	39.2 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.83 kB	4.83 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.2 kB	39.2 kB	✓
Overall change	51.7 kB	51.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	926 B	926 B	✓
link.html gzip	937 B	937 B	✓
withRouter.html gzip	925 B	925 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	11.6s	11.7s	⚠️ +86ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.23 kB	6.23 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39.2 kB	39.2 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.83 kB	4.83 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.2 kB	39.2 kB	✓
Overall change	51.7 kB	51.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	853 kB	853 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	853 kB	853 kB	✓
link.js	891 kB	891 kB	✓
routerDirect.js	883 kB	883 kB	✓
withRouter.js	883 kB	883 kB	✓
Overall change	4.37 MB	4.37 MB	✓

ijjk · 2020-05-04T22:12:54Z

Failing test suites

test/acceptance/ReactRefresh.test.js

logbox: can recover from a component error

Expand output

● logbox: can recover from a component error

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `logbox: can recover from a component error 1`

- Snapshot
+ Received

- child.js (4:14) @ Child
+ ../../../../packages/react-refresh-utils/internal/helpers.js (114:0) @ eval

-   2 |   // hello
+   112 | if (canApplyUpdate()) {
-   3 |   export default function Child() {
- > 4 |     throw new Error('oops')
-     |          ^
-   5 |   }
-   6 |·
+   113 |     try {
+ > 114 |         runtime_1["default"].performReactRefresh();
+   115 |     }
+   116 |     catch (err) {
+   117 |         console.warn('Warning: Failed to re-render. We will retry on the next Fast Refresh event.\n' +

  393 | 
  394 |   expect(await session.hasRedbox(true)).toBe(true)
> 395 |   expect(await session.getRedboxSource()).toMatchInlineSnapshot(`
      |                                           ^
  396 |     "child.js (4:14) @ Child
  397 | 
  398 |       2 |   // hello

  at Object.<anonymous> (acceptance/ReactRefresh.test.js:395:43)

ijjk · 2020-05-04T22:22:17Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	13.3s	13.8s	⚠️ +516ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.273	2.259	-0.01
/ avg req/sec	1099.67	1106.79	⚠️ +7.12
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.495	1.534	⚠️ +0.04
/error-in-render avg req/sec	1672.27	1629.28	-42.99

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.23 kB	6.23 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39.2 kB	39.2 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.83 kB	4.83 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.2 kB	39.2 kB	✓
Overall change	51.7 kB	51.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	926 B	926 B	✓
link.html gzip	937 B	937 B	✓
withRouter.html gzip	925 B	925 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	14.3s	14.4s	⚠️ +88ms
nodeModulesSize	57.6 MB	57.6 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.23 kB	6.23 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39.2 kB	39.2 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.83 kB	4.83 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.2 kB	39.2 kB	✓
Overall change	51.7 kB	51.7 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	853 kB	853 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	853 kB	853 kB	✓
link.js	891 kB	891 kB	✓
routerDirect.js	883 kB	883 kB	✓
withRouter.js	883 kB	883 kB	✓
Overall change	4.37 MB	4.37 MB	✓

prateekbh

Just one last bit

packages/next-plugin-eslint/lib/rules/no-css-tags.js

ijjk · 2020-05-05T18:44:59Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	13.5s	13.6s	⚠️ +110ms
nodeModulesSize	60.4 MB	60.4 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.448	2.473	⚠️ +0.02
/ avg req/sec	1021.21	1010.9	-10.31
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.638	1.632	-0.01
/error-in-render avg req/sec	1526.54	1532.15	⚠️ +5.61

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.23 kB	6.23 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.83 kB	4.83 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	926 B	926 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	14.4s	14.3s	-87ms
nodeModulesSize	60.4 MB	60.4 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.23 kB	6.23 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.83 kB	4.83 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	853 kB	853 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	853 kB	853 kB	✓
link.js	891 kB	891 kB	✓
routerDirect.js	883 kB	883 kB	✓
withRouter.js	883 kB	883 kB	✓
Overall change	4.37 MB	4.37 MB	✓

ijjk · 2020-05-05T18:46:37Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	12.2s	12.5s	⚠️ +339ms
nodeModulesSize	60.4 MB	60.4 MB	✓

Page Load Tests Overall increase ✓

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.021	2.009	-0.01
/ avg req/sec	1236.72	1244.44	⚠️ +7.72
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.249	1.228	-0.02
/error-in-render avg req/sec	2001.74	2036.12	⚠️ +34.38

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.23 kB	6.23 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.83 kB	4.83 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	926 B	926 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	13.2s	12.9s	-259ms
nodeModulesSize	60.4 MB	60.4 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.23 kB	6.23 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.83 kB	4.83 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	853 kB	853 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	853 kB	853 kB	✓
link.js	891 kB	891 kB	✓
routerDirect.js	883 kB	883 kB	✓
withRouter.js	883 kB	883 kB	✓
Overall change	4.37 MB	4.37 MB	✓

ijjk · 2020-05-05T21:36:39Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	12.8s	12.7s	-60ms
nodeModulesSize	60.4 MB	60.4 MB	✓

Page Load Tests Overall increase ✓

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.235	2.093	-0.14
/ avg req/sec	1118.68	1194.59	⚠️ +75.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.496	1.426	-0.07
/error-in-render avg req/sec	1671.56	1753.74	⚠️ +82.18

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.23 kB	6.23 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.83 kB	4.83 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	926 B	926 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	13.5s	13.6s	⚠️ +173ms
nodeModulesSize	60.4 MB	60.4 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.23 kB	6.23 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.83 kB	4.83 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	853 kB	853 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	853 kB	853 kB	✓
link.js	891 kB	891 kB	✓
routerDirect.js	883 kB	883 kB	✓
withRouter.js	883 kB	883 kB	✓
Overall change	4.37 MB	4.37 MB	✓

ijjk · 2020-05-05T21:37:38Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	12.5s	12.7s	⚠️ +193ms
nodeModulesSize	60.4 MB	60.4 MB	✓

Page Load Tests Overall increase ✓

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.192	2.127	-0.07
/ avg req/sec	1140.27	1175.22	⚠️ +34.95
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.352	1.369	⚠️ +0.02
/error-in-render avg req/sec	1848.63	1826.4	-22.23

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.23 kB	6.23 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.83 kB	4.83 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
index.html gzip	926 B	926 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
buildDuration	13.3s	13.4s	⚠️ +51ms
nodeModulesSize	60.4 MB	60.4 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.js gzip	6.23 kB	6.23 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5232.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
main-HASH.module.js gzip	4.83 kB	4.83 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.6 kB	51.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.13 kB	3.13 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	janicklas-ralph/next.js eslint	Change
_error.js	853 kB	853 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	853 kB	853 kB	✓
link.js	891 kB	891 kB	✓
routerDirect.js	883 kB	883 kB	✓
withRouter.js	883 kB	883 kB	✓
Overall change	4.37 MB	4.37 MB	✓

Timer

Awesome.

rauchg · 2020-05-07T18:07:53Z

You're the man @janicklas-ralph

janicklas-ralph added 4 commits April 4, 2020 14:36

Updating native-url version

edabb95

Bump version

c147099

Merge branch 'canary' of github.com:zeit/next.js into canary

63b04ca

Setup eslint plugin

14ae8c3

janicklas-ralph requested review from ijjk, lfades, Timer and timneutkens as code owners April 17, 2020 22:16

Merge branch 'canary' of github.com:zeit/next.js into eslint

07dd2bb

Merge branch 'canary' of github.com:zeit/next.js into eslint

5a1a989

prateekbh reviewed Apr 20, 2020

View reviewed changes

janicklas-ralph added 2 commits April 22, 2020 11:33

Merge branch 'canary' of github.com:zeit/next.js into eslint

3b52bfc

Fix conflicts and review comments

7891cca

janicklas-ralph requested a review from prateekbh April 22, 2020 18:39

timneutkens reviewed Apr 28, 2020

View reviewed changes

timneutkens mentioned this pull request Apr 29, 2020

Add no-anonymous-default-export to default rule set #12291

Closed

Merge branch 'canary' of github.com:zeit/next.js into eslint

7e090a4

Merge branch 'canary' of github.com:zeit/next.js into eslint

3eb1999

Merge branch 'canary' of github.com:zeit/next.js into eslint

0baa620

Merge branch 'canary' of github.com:zeit/next.js into eslint

22007a7

prateekbh suggested changes May 5, 2020

View reviewed changes

packages/next-plugin-eslint/lib/rules/no-css-tags.js Outdated Show resolved Hide resolved

janicklas-ralph added 2 commits May 5, 2020 11:36

Make No-css-tags check for first party files only

0517bff

Merge branch 'canary' of github.com:zeit/next.js into eslint

0bae2f1

janicklas-ralph added 2 commits May 5, 2020 14:28

Removing mocha from eslint plugin

b02a0a3

Merge branch 'canary' of github.com:zeit/next.js into eslint

d6923b0

Merge branch 'canary' into eslint

e679d66

prateekbh approved these changes May 6, 2020

View reviewed changes

lauralouiset mentioned this pull request May 6, 2020

Add support for paths in tsconfig.json and jsconfig.json #11293

Merged

Timer added 3 commits May 7, 2020 00:54

Merge branch 'canary' into eslint

72d65e0

Rename directory

4679168

Move tests to correct location

86c7be3

Timer approved these changes May 7, 2020

View reviewed changes

Timer added the Type: Enhancement label May 7, 2020

Timer added this to the 9.3.7 milestone May 7, 2020

Timer changed the title ~~Setup ESLint plugin~~ Experimental: New ESLint Plugin May 7, 2020

Timer merged commit 5ad512b into vercel:canary May 7, 2020

Timer modified the milestones: 9.3.7, 9.4 May 11, 2020

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

Experimental: New ESLint Plugin (vercel#11986)

b9ab2bb

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Experimental: New ESLint Plugin #11986

Experimental: New ESLint Plugin #11986

janicklas-ralph commented Apr 17, 2020

ijjk commented Apr 17, 2020

ijjk commented Apr 17, 2020

ijjk commented Apr 17, 2020

prateekbh Apr 17, 2020

prateekbh Apr 20, 2020

prateekbh Apr 20, 2020

ijjk commented Apr 22, 2020

ijjk commented Apr 22, 2020

timneutkens Apr 28, 2020

ijjk commented May 4, 2020

ijjk commented May 4, 2020

ijjk commented May 4, 2020

ijjk commented May 4, 2020

ijjk commented May 4, 2020

prateekbh left a comment

ijjk commented May 5, 2020

ijjk commented May 5, 2020

ijjk commented May 5, 2020

ijjk commented May 5, 2020

Timer left a comment

rauchg commented May 7, 2020

Experimental: New ESLint Plugin #11986

Experimental: New ESLint Plugin #11986

Conversation

janicklas-ralph commented Apr 17, 2020

ijjk commented Apr 17, 2020

Stats from current PR

ijjk commented Apr 17, 2020

Stats from current PR

ijjk commented Apr 17, 2020

Stats from current PR

prateekbh Apr 17, 2020

Choose a reason for hiding this comment

prateekbh Apr 20, 2020

Choose a reason for hiding this comment

prateekbh Apr 20, 2020

Choose a reason for hiding this comment

ijjk commented Apr 22, 2020

Stats from current PR

ijjk commented Apr 22, 2020

Stats from current PR

timneutkens Apr 28, 2020

Choose a reason for hiding this comment

ijjk commented May 4, 2020

Stats from current PR

ijjk commented May 4, 2020

Stats from current PR

ijjk commented May 4, 2020

Stats from current PR

ijjk commented May 4, 2020

Failing test suites

ijjk commented May 4, 2020

Stats from current PR

prateekbh left a comment

Choose a reason for hiding this comment

ijjk commented May 5, 2020

Stats from current PR

ijjk commented May 5, 2020

Stats from current PR

ijjk commented May 5, 2020

Stats from current PR

ijjk commented May 5, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

rauchg commented May 7, 2020