Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update styled-jsx to 3.3.0 #12870

Merged
merged 1 commit into from
May 14, 2020
Merged

Update styled-jsx to 3.3.0 #12870

merged 1 commit into from
May 14, 2020

Conversation

giuseppeg
Copy link
Contributor

@giuseppeg giuseppeg commented May 14, 2020 •
edited

Introduces a new plugin option to configure the module that the transpiled files should import.
Should unblock #10149

https://github.com/zeit/styled-jsx/releases/tag/v3.3.0

@giuseppeg
Update styled-jsx to 3.3.0
3cc879e 
Introduces a new plugin option to configure the module that the transpiled files should import. 
Should unblock vercel#10149 and support for yarn v2 once vercel#10149 is complete.

https://github.com/zeit/styled-jsx/releases/tag/v3.3.0
@ijjk
Copy link
Member

ijjk commented May 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary giuseppeg/next.js patch-1 Change
buildDuration 11.6s 11.5s -50ms
nodeModulesSize 58.7 MB 58.7 MB ⚠️ +254 B
Page Load Tests Overall decrease ⚠️
zeit/next.js canary giuseppeg/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.818 1.852 ⚠️ +0.03
/ avg req/sec 1375.26 1350.1 -25.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.041 1.119 ⚠️ +0.08
/error-in-render avg req/sec 2401.08 2234.13 -166.95
Client Bundles (main, webpack, commons)
zeit/next.js canary giuseppeg/next.js patch-1 Change
main-HASH.js gzip 6.68 kB 6.68 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary giuseppeg/next.js patch-1 Change
main-HASH.module.js gzip 5.72 kB 5.72 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary giuseppeg/next.js patch-1 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary giuseppeg/next.js patch-1 Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.29 kB 3.29 kB ✓
hooks.js gzip 880 B 880 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary giuseppeg/next.js patch-1 Change
_app.module.js gzip 599 B 599 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary giuseppeg/next.js patch-1 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary giuseppeg/next.js patch-1 Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary giuseppeg/next.js patch-1 Change
buildDuration 12s 11.8s -212ms
nodeModulesSize 58.7 MB 58.7 MB ⚠️ +254 B
Client Bundles (main, webpack, commons)
zeit/next.js canary giuseppeg/next.js patch-1 Change
main-HASH.js gzip 6.68 kB 6.68 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e49d.js gzip 10.4 kB 10.4 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary giuseppeg/next.js patch-1 Change
main-HASH.module.js gzip 5.72 kB 5.72 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary giuseppeg/next.js patch-1 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary giuseppeg/next.js patch-1 Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.29 kB 3.29 kB ✓
hooks.js gzip 880 B 880 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary giuseppeg/next.js patch-1 Change
_app.module.js gzip 599 B 599 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary giuseppeg/next.js patch-1 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary giuseppeg/next.js patch-1 Change
_error.js 850 kB 850 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 851 kB 851 kB ✓
link.js 888 kB 888 kB ✓
routerDirect.js 880 kB 880 kB ✓
withRouter.js 880 kB 880 kB ✓
Overall change 4.36 MB 4.36 MB ✓

@timneutkens timneutkens merged commit eed3923 into vercel:canary May 14, 2020
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
@giuseppeg @chibicode
Update styled-jsx to 3.3.0 (vercel#12870)
96b2cbf 
Introduces a new plugin option to configure the module that the transpiled files should import. 
Should unblock vercel#10149 and support for yarn v2 once vercel#10149 is complete.

https://github.com/zeit/styled-jsx/releases/tag/v3.3.0
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@giuseppeg @rokinsky
Update styled-jsx to 3.3.0 (vercel#12870)
c17546a 
Introduces a new plugin option to configure the module that the transpiled files should import. 
Should unblock vercel#10149 and support for yarn v2 once vercel#10149 is complete.

https://github.com/zeit/styled-jsx/releases/tag/v3.3.0
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@giuseppeg @ijjk @timneutkens