chore: remove-redundant-example-react-import #13907

sshyam-gupta · 2020-06-08T18:09:04Z

One more related to #12964

I covered the following examples:

blog-starter-typescript
with-google-analytics
with-google-analytics-amp

If you have a suggestion or change I'd appreciate it.

ijjk · 2020-06-08T18:16:46Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
buildDuration	11.5s	11.6s	⚠️ +159ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.909	1.848	-0.06
/ avg req/sec	1309.26	1352.84	⚠️ +43.58
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.079	1.161	⚠️ +0.08
/error-in-render avg req/sec	2315.9	2154.09	-161.81

Client Bundles (main, webpack, commons)

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ec24.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
index.html gzip	925 B	925 B	✓
link.html gzip	936 B	936 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
buildDuration	12.7s	12.8s	⚠️ +65ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ec24.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_error.js	877 kB	877 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	877 kB	877 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Timer

LGTM, thanks!

ijjk · 2020-06-08T18:39:39Z

Failing test suites

test/integration/css/test/index.test.js

CSS Support > Ordering with Global CSS and Modules (dev) > should have the correct color (css ordering)

Expand output

● CSS Support › Ordering with Global CSS and Modules (dev) › should have the correct color (css ordering)

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `CSS Support Ordering with Global CSS and Modules (dev) should have the correct color (css ordering) 1`

Snapshot: "rgb(0, 0, 255)"
Received: "rgb(255, 0, 0)"

  824 |         `window.getComputedStyle(document.querySelector('#blueText')).color`
  825 |       )
> 826 |       expect(currentColor).toMatchInlineSnapshot(`"rgb(0, 0, 255)"`)
      |                            ^
  827 |     })
  828 | 
  829 |     it('should have the correct color (css ordering) during hot reloads', async () => {

  at Object.<anonymous> (integration/css/test/index.test.js:826:28)
      at runMicrotasks (<anonymous>)

ijjk · 2020-06-08T18:45:51Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
buildDuration	10.9s	11.1s	⚠️ +198ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.783	1.709	-0.07
/ avg req/sec	1402.4	1462.62	⚠️ +60.22
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.071	1.051	-0.02
/error-in-render avg req/sec	2333.81	2377.76	⚠️ +43.95

Client Bundles (main, webpack, commons)

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ec24.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_buildManifest.js gzip	171 B	171 B	✓
_buildManife..dule.js gzip	180 B	180 B	✓
Overall change	351 B	351 B	✓

Rendered Page Sizes

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
index.html gzip	901 B	901 B	✓
link.html gzip	906 B	906 B	✓
withRouter.html gzip	894 B	894 B	✓
Overall change	2.7 kB	2.7 kB	✓

Serverless Mode

General

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
buildDuration	11.8s	12.2s	⚠️ +397ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
main-HASH.js gzip	6.49 kB	6.49 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ec24.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.9 kB	56.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
main-HASH.module.js gzip	5.58 kB	5.58 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.4 kB	52.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.05 kB	2.05 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_buildManifest.js gzip	171 B	171 B	✓
_buildManife..dule.js gzip	180 B	180 B	✓
Overall change	351 B	351 B	✓

Serverless bundles

	vercel/next.js canary	sshyam-gupta/next.js chore/remove-react-imports	Change
_error.js	874 kB	874 kB	✓
404.html	4.13 kB	4.13 kB	✓
hooks.html	3.71 kB	3.71 kB	✓
index.js	875 kB	875 kB	✓
link.js	913 kB	913 kB	✓
routerDirect.js	905 kB	905 kB	✓
withRouter.js	905 kB	905 kB	✓
Overall change	4.48 MB	4.48 MB	✓

Co-authored-by: Joe Haddad <joe.haddad@zeit.co>

sshyam-gupta added 3 commits June 8, 2020 23:04

Remove React import from blog-starter-typescript

b995c4f

Remove React import from with-google-analytics

63924bc

Remove React import from with-google-analytics-amp

0396957

sshyam-gupta requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners June 8, 2020 18:09

ijjk added the examples Issue/PR related to examples label Jun 8, 2020

Merge branch 'canary' into chore/remove-react-imports

ccb0947

Timer approved these changes Jun 8, 2020

View reviewed changes

Merge branch 'canary' into chore/remove-react-imports

1754acf

Timer mentioned this pull request Jun 8, 2020

Intermittent failing test suites #13911

Closed

Timer merged commit 506116c into vercel:canary Jun 9, 2020

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020

chore: remove-redundant-example-react-import (vercel#13907)

37a9dbb

Co-authored-by: Joe Haddad <joe.haddad@zeit.co>

katjuell mentioned this pull request Aug 11, 2021

Add bundle analyzer and update React imports sourcegraph/learn#160

Merged

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove-redundant-example-react-import #13907

chore: remove-redundant-example-react-import #13907

sshyam-gupta commented Jun 8, 2020 •

edited

ijjk commented Jun 8, 2020

Timer left a comment

ijjk commented Jun 8, 2020

ijjk commented Jun 8, 2020

chore: remove-redundant-example-react-import #13907

chore: remove-redundant-example-react-import #13907

Conversation

sshyam-gupta commented Jun 8, 2020 • edited

ijjk commented Jun 8, 2020

Stats from current PR

Timer left a comment

Choose a reason for hiding this comment

ijjk commented Jun 8, 2020

Failing test suites

ijjk commented Jun 8, 2020

Stats from current PR

sshyam-gupta commented Jun 8, 2020 •

edited