Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add retry method to loadable types #14152

Merged

Conversation

stefanprobst
Copy link
Contributor

@ijjk
Copy link
Member

ijjk commented Jun 13, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
buildDuration 13.2s 13s -187ms
nodeModulesSize 65.2 MB 65.2 MB ⚠️ +52 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
/ failed reqs 0 0
/ total time (seconds) 2.249 2.345 ⚠️ +0.1
/ avg req/sec 1111.38 1065.93 -45.45
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.47 1.443 -0.03
/error-in-render avg req/sec 1700.64 1731.99 ⚠️ +31.35
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
main-HASH.js gzip 6.51 kB 6.51 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
main-HASH.module.js gzip 5.6 kB 5.6 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
_error.js gzip 3.37 kB 3.37 kB
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
hooks.js gzip 881 B 881 B
_app.js gzip 1.26 kB 1.26 kB
Overall change 8.34 kB 8.34 kB
Client Pages Modern
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
index.module.js gzip 223 B 223 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
hooks.module.js gzip 383 B 383 B
_error.module.js gzip 2.21 kB 2.21 kB
link.module.js gzip 1.52 kB 1.52 kB
_app.module.js gzip 604 B 604 B
Overall change 5.49 kB 5.49 kB
Client Build Manifests
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
_buildManifest.js gzip 270 B 270 B
_buildManife..dule.js gzip 274 B 274 B
Overall change 544 B 544 B
Rendered Page Sizes
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
index.html gzip 956 B 956 B
link.html gzip 963 B 963 B
withRouter.html gzip 949 B 949 B
Overall change 2.87 kB 2.87 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
buildDuration 14s 14.3s ⚠️ +353ms
nodeModulesSize 65.2 MB 65.2 MB ⚠️ +52 B
Client Bundles (main, webpack, commons)
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
main-HASH.js gzip 6.51 kB 6.51 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.9 kB 56.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
main-HASH.module.js gzip 5.6 kB 5.6 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.4 kB 52.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
_error.js gzip 3.37 kB 3.37 kB
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
hooks.js gzip 881 B 881 B
_app.js gzip 1.26 kB 1.26 kB
Overall change 8.34 kB 8.34 kB
Client Pages Modern
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
index.module.js gzip 223 B 223 B
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
hooks.module.js gzip 383 B 383 B
_error.module.js gzip 2.21 kB 2.21 kB
link.module.js gzip 1.52 kB 1.52 kB
_app.module.js gzip 604 B 604 B
Overall change 5.49 kB 5.49 kB
Client Build Manifests
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
_buildManifest.js gzip 270 B 270 B
_buildManife..dule.js gzip 274 B 274 B
Overall change 544 B 544 B
Serverless bundles
vercel/next.js canary stefanprobst/next.js chore/add-retry-to-loadable-types Change
_error.js 875 kB 875 kB
404.html 4.17 kB 4.17 kB
hooks.html 3.79 kB 3.79 kB
index.js 875 kB 875 kB
link.js 913 kB 913 kB
routerDirect.js 905 kB 905 kB
withRouter.js 905 kB 905 kB
Overall change 4.48 MB 4.48 MB

@timneutkens timneutkens merged commit 66778c7 into vercel:canary Jun 15, 2020
@timneutkens
Copy link
Member

Looks fine!

@stefanprobst stefanprobst deleted the chore/add-retry-to-loadable-types branch June 15, 2020 13:26
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants