Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to function component with-react-intl example #14217

Merged
merged 2 commits into from Jun 16, 2020
Merged

switch to function component with-react-intl example #14217

merged 2 commits into from Jun 16, 2020

Conversation

darshkpatel
Copy link
Contributor

@darshkpatel darshkpatel commented Jun 16, 2020 •
edited

The example was using class-based component for custom _app, switched to function component.

Sidenote: The existing code gave an error when navigated to a new page using the navbar
Screenshot 2020-06-16 at 2 47 52 PM

@ijjk ijjk added the examples Issue/PR related to examples label Jun 16, 2020
@ijjk
Copy link
Member

ijjk commented Jun 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
buildDuration 10.8s 11s ⚠️ +259ms
nodeModulesSize 65.2 MB 65.2 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.832 1.892 ⚠️ +0.06
/ avg req/sec 1364.38 1321.48 -42.9
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.072 1.055 -0.02
/error-in-render avg req/sec 2331.55 2368.86 ⚠️ +37.31
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
main-HASH.module.js gzip 5.6 kB 5.6 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
_error.js gzip 3.37 kB 3.37 kB ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
Overall change 8.34 kB 8.34 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
hooks.module.js gzip 383 B 383 B ✓
_error.module.js gzip 2.21 kB 2.21 kB ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.49 kB 5.49 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 274 B 274 B ✓
Overall change 544 B 544 B ✓
Rendered Page Sizes
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
index.html gzip 956 B 956 B ✓
link.html gzip 963 B 963 B ✓
withRouter.html gzip 949 B 949 B ✓
Overall change 2.87 kB 2.87 kB ✓
Serverless Mode
General
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
buildDuration 12.1s 11.6s -436ms
nodeModulesSize 65.2 MB 65.2 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
main-HASH.module.js gzip 5.6 kB 5.6 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
_error.js gzip 3.37 kB 3.37 kB ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
Overall change 8.34 kB 8.34 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
hooks.module.js gzip 383 B 383 B ✓
_error.module.js gzip 2.21 kB 2.21 kB ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.49 kB 5.49 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 274 B 274 B ✓
Overall change 544 B 544 B ✓
Serverless bundles
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@ijjk
Copy link
Member

ijjk commented Jun 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
buildDuration 12.4s 12.3s -115ms
nodeModulesSize 65.2 MB 65.2 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.057 1.983 -0.07
/ avg req/sec 1215.12 1260.89 ⚠️ +45.77
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.231 1.211 -0.02
/error-in-render avg req/sec 2030.66 2064.52 ⚠️ +33.86
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
main-HASH.module.js gzip 5.6 kB 5.6 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
_error.js gzip 3.37 kB 3.37 kB ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
Overall change 8.34 kB 8.34 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
hooks.module.js gzip 383 B 383 B ✓
_error.module.js gzip 2.21 kB 2.21 kB ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.49 kB 5.49 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 274 B 274 B ✓
Overall change 544 B 544 B ✓
Rendered Page Sizes
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
index.html gzip 956 B 956 B ✓
link.html gzip 963 B 963 B ✓
withRouter.html gzip 949 B 949 B ✓
Overall change 2.87 kB 2.87 kB ✓
Serverless Mode
General
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
buildDuration 13s 13s ⚠️ +26ms
nodeModulesSize 65.2 MB 65.2 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
main-HASH.js gzip 6.51 kB 6.51 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..0538.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
main-HASH.module.js gzip 5.6 kB 5.6 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
_error.js gzip 3.37 kB 3.37 kB ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.05 kB 2.05 kB ✓
hooks.js gzip 881 B 881 B ✓
_app.js gzip 1.26 kB 1.26 kB ✓
Overall change 8.34 kB 8.34 kB ✓
Client Pages Modern
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
index.module.js gzip 223 B 223 B ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
hooks.module.js gzip 383 B 383 B ✓
_error.module.js gzip 2.21 kB 2.21 kB ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
_app.module.js gzip 604 B 604 B ✓
Overall change 5.49 kB 5.49 kB ✓
Client Build Manifests
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
_buildManifest.js gzip 270 B 270 B ✓
_buildManife..dule.js gzip 274 B 274 B ✓
Overall change 544 B 544 B ✓
Serverless bundles
vercel/next.js canary MLH-Fellowship/next.js darsh/update-to-functional Change
_error.js 875 kB 875 kB ✓
404.html 4.17 kB 4.17 kB ✓
hooks.html 3.79 kB 3.79 kB ✓
index.js 875 kB 875 kB ✓
link.js 913 kB 913 kB ✓
routerDirect.js 905 kB 905 kB ✓
withRouter.js 905 kB 905 kB ✓
Overall change 4.48 MB 4.48 MB ✓

@timneutkens timneutkens changed the title switch to functional component with-react-intl example switch to function component with-react-intl example Jun 16, 2020
@kodiakhq kodiakhq bot merged commit a3ffa2e into vercel:canary Jun 16, 2020
@darshkpatel darshkpatel deleted the darsh/update-to-functional branch June 16, 2020 11:36
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@darshkpatel @rokinsky
switch to function component with-react-intl example (vercel#14217)
389dce1 
The example was using class-based component for custom _app, switched to functional component approach.


**Sidenote:** The existing code didn't gave an error when navigated to a new page using the navbar
![Screenshot 2020-06-16 at 2 47 52 PM](https://user-images.githubusercontent.com/11258286/84760988-6cbebd80-afe6-11ea-9b7f-98aca7404895.png)
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@darshkpatel @ijjk @timneutkens