Convert incremental generation cache to a class #14660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server Mode (Increase detected
|
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| buildDuration | 11.8s | 12.1s | |
| nodeModulesSize | 67.1 MB | 67.1 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.916 | 1.971 | |
| / avg req/sec | 1305.02 | 1268.33 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.246 | 1.212 | -0.03 |
| /error-in-render avg req/sec | 2006.24 | 2062.26 | +56.02 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.51 kB | 6.51 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| 19b7e98f51cc..558d.js gzip | 10.7 kB | 10.7 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 57.1 kB | 57.1 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 5.59 kB | 5.59 kB | ✓ |
| webpack-HASH..dule.js gzip | 751 B | 751 B | ✓ |
| 19b7e98f51cc..dule.js gzip | 7.08 kB | 7.08 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 52.6 kB | 52.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 268 B | 268 B | ✓ |
| _buildManife..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 540 B | 540 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| index.html gzip | 954 B | 954 B | ✓ |
| link.html gzip | 959 B | 959 B | ✓ |
| withRouter.html gzip | 947 B | 947 B | ✓ |
| Overall change | 2.86 kB | 2.86 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| buildDuration | 12.7s | 12.7s | |
| nodeModulesSize | 67.1 MB | 67.1 MB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.51 kB | 6.51 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| 19b7e98f51cc..558d.js gzip | 10.7 kB | 10.7 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 57.1 kB | 57.1 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 5.59 kB | 5.59 kB | ✓ |
| webpack-HASH..dule.js gzip | 751 B | 751 B | ✓ |
| 19b7e98f51cc..dule.js gzip | 7.08 kB | 7.08 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 52.6 kB | 52.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 268 B | 268 B | ✓ |
| _buildManife..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 540 B | 540 B | ✓ |
Serverless bundles
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| _error.js | 875 kB | 875 kB | ✓ |
| 404.html | 4.17 kB | 4.17 kB | ✓ |
| hooks.html | 3.79 kB | 3.79 kB | ✓ |
| index.js | 876 kB | 876 kB | ✓ |
| link.js | 916 kB | 916 kB | ✓ |
| routerDirect.js | 908 kB | 908 kB | ✓ |
| withRouter.js | 908 kB | 908 kB | ✓ |
| Overall change | 4.49 MB | 4.49 MB | ✓ |
timneutkens
changed the title
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| buildDuration | 13.2s | 13.6s | |
| nodeModulesSize | 67.1 MB | 67.1 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.277 | 2.311 | |
| / avg req/sec | 1098.16 | 1081.88 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.593 | 1.582 | -0.01 |
| /error-in-render avg req/sec | 1569.58 | 1580.6 | +11.02 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.51 kB | 6.51 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| 19b7e98f51cc..558d.js gzip | 10.7 kB | 10.7 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 57.1 kB | 57.1 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 5.59 kB | 5.59 kB | ✓ |
| webpack-HASH..dule.js gzip | 751 B | 751 B | ✓ |
| 19b7e98f51cc..dule.js gzip | 7.08 kB | 7.08 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 52.6 kB | 52.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 268 B | 268 B | ✓ |
| _buildManife..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 540 B | 540 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| index.html gzip | 954 B | 954 B | ✓ |
| link.html gzip | 959 B | 959 B | ✓ |
| withRouter.html gzip | 947 B | 947 B | ✓ |
| Overall change | 2.86 kB | 2.86 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| buildDuration | 14.4s | 14.2s | -216ms |
| nodeModulesSize | 67.1 MB | 67.1 MB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.51 kB | 6.51 kB | ✓ |
| webpack-HASH.js gzip | 751 B | 751 B | ✓ |
| 19b7e98f51cc..558d.js gzip | 10.7 kB | 10.7 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 57.1 kB | 57.1 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 5.59 kB | 5.59 kB | ✓ |
| webpack-HASH..dule.js gzip | 751 B | 751 B | ✓ |
| 19b7e98f51cc..dule.js gzip | 7.08 kB | 7.08 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 52.6 kB | 52.6 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 268 B | 268 B | ✓ |
| _buildManife..dule.js gzip | 272 B | 272 B | ✓ |
| Overall change | 540 B | 540 B | ✓ |
Serverless bundles
| vercel/next.js canary | timneutkens/next.js add/rename-spr-to-incremental | Change | |
|---|---|---|---|
| _error.js | 875 kB | 875 kB | ✓ |
| 404.html | 4.17 kB | 4.17 kB | ✓ |
| hooks.html | 3.79 kB | 3.79 kB | ✓ |
| index.js | 876 kB | 876 kB | ✓ |
| link.js | 916 kB | 916 kB | ✓ |
| routerDirect.js | 908 kB | 908 kB | ✓ |
| withRouter.js | 908 kB | 908 kB | ✓ |
| Overall change | 4.49 MB | 4.49 MB | ✓ |
Timer
approved these changes
Jun 28, 2020
rokinsky
pushed a commit
to rokinsky/next.js
that referenced
this pull request
Jul 11, 2020
We've been meaning to change this code for a while 👍 - Changed the name from spr to incremental - Changed the code to be a class instead of using module scope variables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been meaning to change this code for a while 👍