Add PWA Example #15433

khattakdev · 2020-07-23T13:03:33Z

closes #15356

Co-authored-by: Luis Alvarez D. <luis@vercel.com>

ijjk · 2020-07-23T13:12:31Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	13.1s	13.1s	⚠️ +4ms
nodeModulesSize	66.4 MB	66.4 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.095	2.064	-0.03
/ avg req/sec	1193.27	1211.51	+18.24
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.298	1.24	-0.06
/error-in-render avg req/sec	1926.74	2016.27	+89.53

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..d2f7.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-8da3811..3b61.js gzip	6.72 kB	6.72 kB	✓
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	87.6 kB	87.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.1 kB	6.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-43a8e8b..dule.js gzip	5.79 kB	5.79 kB	✓
polyfills-05..dule.js gzip	30.8 kB	30.8 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	82.6 kB	82.6 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-8e69b..8695.js gzip	3.41 kB	3.41 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.66 kB	7.66 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-663e6..dule.js gzip	2.24 kB	2.24 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.29 kB	5.29 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
index.html gzip	946 B	946 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	938 B	938 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	14.1s	14.2s	⚠️ +134ms
nodeModulesSize	66.4 MB	66.4 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..d2f7.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-8da3811..3b61.js gzip	6.72 kB	6.72 kB	✓
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	87.6 kB	87.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.1 kB	6.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-43a8e8b..dule.js gzip	5.79 kB	5.79 kB	✓
polyfills-05..dule.js gzip	30.8 kB	30.8 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	82.6 kB	82.6 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-8e69b..8695.js gzip	3.41 kB	3.41 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.66 kB	7.66 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-663e6..dule.js gzip	2.24 kB	2.24 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.29 kB	5.29 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_error.js	881 kB	881 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	881 kB	881 kB	✓
link.js	922 kB	922 kB	✓
routerDirect.js	916 kB	916 kB	✓
withRouter.js	916 kB	916 kB	✓
Overall change	4.52 MB	4.52 MB	✓

Commit: 583771c

lfades

The changes in the sitemap PR (#15047) that's almost ready for merge are also included here, once that one is merged make sure to merge your branch with canary so we can exclude the changes from that example in this PR. Contributions by collaborators aren't enabled so you would you have to do that yourself 🙏

khattakdev · 2020-07-24T06:58:35Z

@lfades I didn't notice I checkout new branch from sitemap example's branch.
I remove the sitemap example from this PR. So It's PWA specific now.

ijjk · 2020-07-24T07:03:36Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	12.2s	12.1s	-101ms
nodeModulesSize	66.4 MB	66.4 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.958	2.005	⚠️ +0.05
/ avg req/sec	1276.77	1246.68	⚠️ -30.09
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.343	1.382	⚠️ +0.04
/error-in-render avg req/sec	1862.03	1808.65	⚠️ -53.38

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..d2f7.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-8da3811..3b61.js gzip	6.72 kB	6.72 kB	✓
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	87.6 kB	87.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.1 kB	6.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-43a8e8b..dule.js gzip	5.79 kB	5.79 kB	✓
polyfills-05..dule.js gzip	30.8 kB	30.8 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	82.6 kB	82.6 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-8e69b..8695.js gzip	3.41 kB	3.41 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.66 kB	7.66 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-663e6..dule.js gzip	2.24 kB	2.24 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.29 kB	5.29 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
index.html gzip	946 B	946 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	938 B	938 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	13.1s	13.5s	⚠️ +383ms
nodeModulesSize	66.4 MB	66.4 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..d2f7.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-8da3811..3b61.js gzip	6.72 kB	6.72 kB	✓
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	87.6 kB	87.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.1 kB	6.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-43a8e8b..dule.js gzip	5.79 kB	5.79 kB	✓
polyfills-05..dule.js gzip	30.8 kB	30.8 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	82.6 kB	82.6 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-8e69b..8695.js gzip	3.41 kB	3.41 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-ddd176e..5566.js gzip	1.29 kB	1.29 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.66 kB	7.66 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-663e6..dule.js gzip	2.24 kB	2.24 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-69bc264..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.29 kB	5.29 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	275 B	275 B	✓
_buildManife..dule.js gzip	281 B	281 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_error.js	881 kB	881 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	881 kB	881 kB	✓
link.js	922 kB	922 kB	✓
routerDirect.js	916 kB	916 kB	✓
withRouter.js	916 kB	916 kB	✓
Overall change	4.52 MB	4.52 MB	✓

Commit: 8fae669

docs/faq.md

examples/progressive-web-app/README.md

examples/progressive-web-app/package.json

examples/progressive-web-app/public/manifest.json

lfades

Added some suggestion, also I tried to run the app in dev mod and got this:

Terminal logs:

Not sure of what's happening but it's broken 😢

The next-pwa also has an example: https://github.com/shadowwalker/next-pwa/tree/master/examples/next-9 - I didn't manage to see a lot of differences between the two, except for that one using _document.js for head tags that are probably required everywhere and aren't dynamic, which is a good idea.

@shadowwalker Can you help me review this example, we would love to have something official about PWAs 🙏

Co-authored-by: Luis Alvarez D. <luis@vercel.com>

ijjk · 2020-08-03T07:40:31Z

Stats from current PR

Default Server Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	11.6s	11.1s	-497ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.008	2.012	0
/ avg req/sec	1244.93	1242.76	⚠️ -2.17
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.119	1.116	0
/error-in-render avg req/sec	2233.39	2239.35	+5.96

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..39a4.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-5b25689..c07a.js gzip	6.73 kB	6.73 kB	✓
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	87.6 kB	87.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-6ac1f4e..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-05..dule.js gzip	30.8 kB	30.8 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	82.7 kB	82.7 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
index.html gzip	946 B	946 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	939 B	939 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	12.5s	12.4s	-43ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..39a4.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-5b25689..c07a.js gzip	6.73 kB	6.73 kB	✓
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	87.6 kB	87.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-6ac1f4e..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-05..dule.js gzip	30.8 kB	30.8 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	82.7 kB	82.7 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: 64ca558

ijjk · 2020-08-03T07:41:42Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	12.8s	12.8s	⚠️ +53ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.267	2.275	⚠️ +0.01
/ avg req/sec	1102.92	1098.84	⚠️ -4.08
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.277	1.304	⚠️ +0.03
/error-in-render avg req/sec	1958.39	1917.66	⚠️ -40.73

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..39a4.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-5b25689..c07a.js gzip	6.73 kB	6.73 kB	✓
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	87.6 kB	87.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-6ac1f4e..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-05..dule.js gzip	30.8 kB	30.8 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	82.7 kB	82.7 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
index.html gzip	946 B	946 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	939 B	939 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	14.4s	13.7s	-671ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..39a4.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-5b25689..c07a.js gzip	6.73 kB	6.73 kB	✓
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	87.6 kB	87.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-6ac1f4e..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-05..dule.js gzip	30.8 kB	30.8 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	82.7 kB	82.7 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: e44a1a3

ijjk · 2020-08-03T07:41:59Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	13.5s	13.7s	⚠️ +207ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.304	2.315	⚠️ +0.01
/ avg req/sec	1084.86	1079.87	⚠️ -4.99
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.305	1.255	-0.05
/error-in-render avg req/sec	1915.19	1991.92	+76.73

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..39a4.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-5b25689..c07a.js gzip	6.73 kB	6.73 kB	✓
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	87.6 kB	87.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-6ac1f4e..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-05..dule.js gzip	30.8 kB	30.8 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	82.7 kB	82.7 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
index.html gzip	946 B	946 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	939 B	939 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	14.6s	15s	⚠️ +433ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..39a4.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-5b25689..c07a.js gzip	6.73 kB	6.73 kB	✓
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	87.6 kB	87.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-6ac1f4e..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-05..dule.js gzip	30.8 kB	30.8 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	82.7 kB	82.7 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: 51b14e9

khattakdev · 2020-08-03T07:45:04Z

@lfades That error has something to do with NextJs version 9.5. The example works fine with 9.4.
I have fixed that issue with a minor change in the config file. It should work fine now.

ijjk · 2020-08-03T08:05:31Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	13.8s	14.1s	⚠️ +284ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.34	2.36	⚠️ +0.02
/ avg req/sec	1068.26	1059.11	⚠️ -9.15
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.395	1.335	-0.06
/error-in-render avg req/sec	1791.96	1872.14	+80.18

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..39a4.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-5b25689..c07a.js gzip	6.73 kB	6.73 kB	✓
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	87.6 kB	87.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-6ac1f4e..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-05..dule.js gzip	30.8 kB	30.8 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	82.7 kB	82.7 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
index.html gzip	946 B	946 B	✓
link.html gzip	952 B	952 B	✓
withRouter.html gzip	939 B	939 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	15.6s	15.4s	-187ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..39a4.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-5b25689..c07a.js gzip	6.73 kB	6.73 kB	✓
polyfills-05..1236.js gzip	30.8 kB	30.8 kB	✓
webpack-488d..c0e7.js gzip	751 B	751 B	✓
Overall change	87.6 kB	87.6 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.13 kB	6.13 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-6ac1f4e..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-05..dule.js gzip	30.8 kB	30.8 kB	✓
webpack-4f62..dule.js gzip	751 B	751 B	✓
Overall change	82.7 kB	82.7 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-8f5f611..1f7b.js gzip	1.28 kB	1.28 kB	✓
_error-a98d9..5cb7.js gzip	3.45 kB	3.45 kB	✓
hooks-f7f3d0..7465.js gzip	887 B	887 B	✓
index-08fb3f..c0e9.js gzip	227 B	227 B	✓
link-6f8445b..99e1.js gzip	1.3 kB	1.3 kB	✓
routerDirect..8aa1.js gzip	284 B	284 B	✓
withRouter-f..e777.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-669dbe5..dule.js gzip	626 B	626 B	✓
_error-d5979..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-805c40..dule.js gzip	387 B	387 B	✓
index-6ba5a4..dule.js gzip	226 B	226 B	✓
link-91516ae..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-d..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	274 B	274 B	✓
_buildManife..dule.js gzip	282 B	282 B	✓
Overall change	556 B	556 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: aed53cd

Co-authored-by: Luis Alvarez D. <luis@vercel.com>

ijjk · 2020-08-04T16:38:22Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	13.4s	13.7s	⚠️ +326ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.407	2.549	⚠️ +0.14
/ avg req/sec	1038.68	980.65	⚠️ -58.03
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.493	1.488	-0.01
/error-in-render avg req/sec	1674.75	1680.55	+5.8

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..afbf.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-2ecb3b8..bd63.js gzip	6.73 kB	6.73 kB	✓
polyfills-75..1629.js gzip	31 kB	31 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	87.8 kB	87.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-dbff266..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-75..dule.js gzip	31 kB	31 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	82.8 kB	82.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-e97733c..af21.js gzip	1.3 kB	1.3 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-fbb1d2e..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	272 B	272 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	552 B	552 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
index.html gzip	944 B	944 B	✓
link.html gzip	953 B	953 B	✓
withRouter.html gzip	940 B	940 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	14.5s	14.6s	⚠️ +168ms
nodeModulesSize	65.5 MB	65.5 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..afbf.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-2ecb3b8..bd63.js gzip	6.73 kB	6.73 kB	✓
polyfills-75..1629.js gzip	31 kB	31 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	87.8 kB	87.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-dbff266..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-75..dule.js gzip	31 kB	31 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	82.8 kB	82.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-e97733c..af21.js gzip	1.3 kB	1.3 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-fbb1d2e..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	272 B	272 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	552 B	552 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: 34ec951

lfades

@ekhattak Thank you very much for the PR, I tested it locally and the PWA is working now!.

One last change. I noticed you're using our create-next-app template. Can you update it to match the latest? our current template is using CSS Modules instead of styled-jsx 🙏

ijjk · 2020-08-05T11:02:27Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	12.7s	12.6s	-142ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.304	2.211	-0.09
/ avg req/sec	1085.07	1130.7	+45.63
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.281	1.169	-0.11
/error-in-render avg req/sec	1951.44	2138.27	+186.83

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..afbf.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-76d73eb..95d8.js gzip	6.73 kB	6.73 kB	✓
polyfills-75..1629.js gzip	31 kB	31 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	87.8 kB	87.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-0b6ca7d..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-75..dule.js gzip	31 kB	31 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	82.8 kB	82.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-e97733c..af21.js gzip	1.3 kB	1.3 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-fbb1d2e..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	272 B	272 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	552 B	552 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
index.html gzip	945 B	945 B	✓
link.html gzip	953 B	953 B	✓
withRouter.html gzip	939 B	939 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	15.6s	15.9s	⚠️ +286ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..afbf.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-76d73eb..95d8.js gzip	6.73 kB	6.73 kB	✓
polyfills-75..1629.js gzip	31 kB	31 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	87.8 kB	87.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.11 kB	6.11 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-0b6ca7d..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-75..dule.js gzip	31 kB	31 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	82.8 kB	82.8 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-e97733c..af21.js gzip	1.3 kB	1.3 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.72 kB	7.72 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-fbb1d2e..dule.js gzip	1.25 kB	1.25 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.36 kB	5.36 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	272 B	272 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	552 B	552 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Commit: 90ec2c8

examples/progressive-web-app/styles/globals.css

ijjk · 2020-08-06T04:37:21Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	12.1s	12s	-114ms
nodeModulesSize	66 MB	66 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.352	2.405	⚠️ +0.05
/ avg req/sec	1062.93	1039.61	⚠️ -23.32
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.551	1.404	-0.15
/error-in-render avg req/sec	1611.79	1781.21	+169.42

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..8895.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-da9f477..d581.js gzip	6.73 kB	6.73 kB	✓
polyfills-75..1629.js gzip	31 kB	31 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	87.9 kB	87.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.21 kB	6.21 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-ccc9938..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-75..dule.js gzip	31 kB	31 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	82.9 kB	82.9 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Rendered Page Sizes

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
index.html gzip	947 B	947 B	✓
link.html gzip	953 B	953 B	✓
withRouter.html gzip	942 B	942 B	✓
Overall change	2.84 kB	2.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
buildDuration	13.7s	13.6s	-111ms
nodeModulesSize	66 MB	66 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..8895.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
main-da9f477..d581.js gzip	6.73 kB	6.73 kB	✓
polyfills-75..1629.js gzip	31 kB	31 kB	✓
webpack-ccf5..276a.js gzip	751 B	751 B	✓
Overall change	87.9 kB	87.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
677f882d2ed8..dule.js gzip	6.21 kB	6.21 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
main-ccc9938..dule.js gzip	5.81 kB	5.81 kB	✓
polyfills-75..dule.js gzip	31 kB	31 kB	✓
webpack-10c7..dule.js gzip	751 B	751 B	✓
Overall change	82.9 kB	82.9 kB	✓

Client Pages

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-874bd8a..0103.js gzip	1.28 kB	1.28 kB	✓
_error-fa39c..ec40.js gzip	3.45 kB	3.45 kB	✓
hooks-585f07..95a3.js gzip	887 B	887 B	✓
index-c7b63f..fc02.js gzip	227 B	227 B	✓
link-f4d2979..e57b.js gzip	1.29 kB	1.29 kB	✓
routerDirect..ebc7.js gzip	284 B	284 B	✓
withRouter-2..db68.js gzip	284 B	284 B	✓
Overall change	7.71 kB	7.71 kB	✓

Client Pages Modern

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_app-97e743e..dule.js gzip	626 B	626 B	✓
_error-b4004..dule.js gzip	2.3 kB	2.3 kB	✓
hooks-696209..dule.js gzip	387 B	387 B	✓
index-a4dd74..dule.js gzip	226 B	226 B	✓
link-653c74f..dule.js gzip	1.26 kB	1.26 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-1..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_buildManifest.js gzip	273 B	273 B	✓
_buildManife..dule.js gzip	280 B	280 B	✓
Overall change	553 B	553 B	✓

Serverless bundles

	vercel/next.js canary	MLH-Fellowship/next.js arsalan/pwa-example	Change
_error.js	1.02 MB	1.02 MB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.82 kB	3.82 kB	✓
index.js	1.02 MB	1.02 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.22 MB	5.22 MB	✓

Commit: fdf2ae4

lfades

@ekhattak Thank you!

khattakdev and others added 9 commits July 10, 2020 12:48

Add with-sitemap Example

c0b2503

Update README

e311207

Update examples/with-sitemap/scripts/generate-sitemap.js

34626f2

Co-authored-by: Luis Alvarez D. <luis@vercel.com>

Update examples/with-sitemap/package.json

e3af2a2

Co-authored-by: Luis Alvarez D. <luis@vercel.com>

Update examples/with-sitemap/public/sitemap.xml

0eb95a8

Co-authored-by: Luis Alvarez D. <luis@vercel.com>

Update README

54c6e17

Add .env Info to README

0bf8608

Add PWA Example

334db9e

Update FAQ with PWA Example

583771c

khattakdev requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners July 23, 2020 13:03

ijjk added type: documentation examples Issue/PR related to examples labels Jul 23, 2020

lfades reviewed Jul 24, 2020

View reviewed changes

Remove Sitemap Example

8fae669

khattakdev requested a review from lfades July 24, 2020 07:32

lfades reviewed Aug 2, 2020

View reviewed changes

docs/faq.md Outdated Show resolved Hide resolved

lfades reviewed Aug 2, 2020

View reviewed changes

examples/progressive-web-app/README.md Outdated Show resolved Hide resolved

lfades reviewed Aug 2, 2020

View reviewed changes

examples/progressive-web-app/package.json Outdated Show resolved Hide resolved

lfades reviewed Aug 2, 2020

View reviewed changes

examples/progressive-web-app/public/manifest.json Outdated Show resolved Hide resolved

lfades requested changes Aug 2, 2020

View reviewed changes

khattakdev marked this pull request as draft August 3, 2020 07:27

khattakdev and others added 2 commits August 3, 2020 12:28

Update examples/progressive-web-app/README.md

64ca558

Co-authored-by: Luis Alvarez D. <luis@vercel.com>

Update examples/progressive-web-app/package.json

51b14e9

Co-authored-by: Luis Alvarez D. <luis@vercel.com>

Update examples/progressive-web-app/public/manifest.json

e44a1a3

Co-authored-by: Luis Alvarez D. <luis@vercel.com>

Fix Caching Issue

aed53cd

khattakdev marked this pull request as ready for review August 4, 2020 02:27

khattakdev requested a review from lfades August 4, 2020 02:27

Update docs/faq.md

34ec951

Co-authored-by: Luis Alvarez D. <luis@vercel.com>

lfades requested changes Aug 4, 2020

View reviewed changes

Switch to css modules

90ec2c8

khattakdev requested a review from lfades August 5, 2020 13:12

lfades reviewed Aug 5, 2020

View reviewed changes

examples/progressive-web-app/styles/globals.css Show resolved Hide resolved

Add Css Module in _app.js

fdf2ae4

khattakdev requested a review from lfades August 6, 2020 05:34

lfades approved these changes Aug 6, 2020

View reviewed changes

Timer merged commit ebd1434 into vercel:canary Aug 6, 2020

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PWA Example #15433

Add PWA Example #15433

khattakdev commented Jul 23, 2020

ijjk commented Jul 23, 2020

lfades left a comment

khattakdev commented Jul 24, 2020

ijjk commented Jul 24, 2020

lfades left a comment •

edited

ijjk commented Aug 3, 2020

ijjk commented Aug 3, 2020

ijjk commented Aug 3, 2020

khattakdev commented Aug 3, 2020 •

edited

ijjk commented Aug 3, 2020

ijjk commented Aug 4, 2020

lfades left a comment •

edited

ijjk commented Aug 5, 2020

ijjk commented Aug 6, 2020

lfades left a comment

Add PWA Example #15433

Add PWA Example #15433

Conversation

khattakdev commented Jul 23, 2020

ijjk commented Jul 23, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

khattakdev commented Jul 24, 2020

ijjk commented Jul 24, 2020

Stats from current PR

lfades left a comment • edited

Choose a reason for hiding this comment

ijjk commented Aug 3, 2020

Stats from current PR

ijjk commented Aug 3, 2020

Stats from current PR

ijjk commented Aug 3, 2020

Stats from current PR

khattakdev commented Aug 3, 2020 • edited

ijjk commented Aug 3, 2020

Stats from current PR

ijjk commented Aug 4, 2020

Stats from current PR

lfades left a comment • edited

Choose a reason for hiding this comment

ijjk commented Aug 5, 2020

Stats from current PR

ijjk commented Aug 6, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

lfades left a comment •

edited

khattakdev commented Aug 3, 2020 •

edited

lfades left a comment •

edited