Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of eval #1611

Closed
wants to merge 26 commits into from
Closed

Get rid of eval #1611

wants to merge 26 commits into from

Commits on Apr 3, 2017

  1. Introduce script tag based page loading system.

    @arunoda
    arunoda committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    a0945c7 View commit details
    Browse the repository at this point in the history

  2. Call ensurePage only in the dev mode.

    @arunoda
    arunoda committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    8938843 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2017

  1. Implement router using the page-loader.

    @arunoda
    arunoda committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    c95d2b2 View commit details
    Browse the repository at this point in the history

  2. Fix a typo and remove unwanted code.

    @arunoda
    arunoda committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    e3d68ff View commit details
    Browse the repository at this point in the history

  3. Fix some issues related to rendering.

    @arunoda
    arunoda committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    03209d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2017

  1. Fix production tests.

    @arunoda
    arunoda committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    a1f11a4 View commit details
    Browse the repository at this point in the history

  2. Fix ondemand test cases.

    @arunoda
    arunoda committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    6f65a05 View commit details
    Browse the repository at this point in the history

  3. Fix unit tests.

    @arunoda
    arunoda committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    57e3a67 View commit details
    Browse the repository at this point in the history

  4. Get rid of eval completely.

    @arunoda
    arunoda committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    822a99b View commit details
    Browse the repository at this point in the history

  5. Remove all the inline code.

    @arunoda
    arunoda committed Apr 5, 2017
    Configuration menu
    Copy the full SHA
    76bfc38 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2017

  1. Remove the json-pages plugin.

    @arunoda
    arunoda committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    5aa02d0 View commit details
    Browse the repository at this point in the history

  2. Rename NEXT_PAGE_LOADER into __NEXT_PAGE_LOADER__

    @arunoda
    arunoda committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    32cdf3f View commit details
    Browse the repository at this point in the history

  3. Rename NEXT_LOADED_PAGES into __NEXT_LOADED_PAGES__

    @arunoda
    arunoda committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    65a2603 View commit details
    Browse the repository at this point in the history

  4. Remove some unwanted code.

    @arunoda
    arunoda committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    f6f175d View commit details
    Browse the repository at this point in the history

  5. Load everything async.

    @arunoda
    arunoda committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    e46edc2 View commit details
    Browse the repository at this point in the history

  6. Remove lib/eval-script.js 

    We no longer need it.
    @arunoda
    arunoda committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    751d2e9 View commit details
    Browse the repository at this point in the history

  7. Move webpack idle wait code to the page-loader. 

    Because that's the place to do it.
    @arunoda
    arunoda committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    4f26e84 View commit details
    Browse the repository at this point in the history

  8. Merge with master.

    @arunoda
    arunoda committed Apr 6, 2017
    Configuration menu
    Copy the full SHA
    866319c View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2017

  1. Remove pageNotFound key from the error.

    @arunoda
    arunoda committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    6f9b51f View commit details
    Browse the repository at this point in the history

  2. Remove unused error field 'buildError'

    @arunoda
    arunoda committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    b5bd0da View commit details
    Browse the repository at this point in the history

  3. Add much better logic to normalize routes.

    @arunoda
    arunoda committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    c077ebe View commit details
    Browse the repository at this point in the history

  4. Get rid of mitt.

    @arunoda
    arunoda committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    fb2f90b View commit details
    Browse the repository at this point in the history

  5. Introduce a better way to register pages.

    @arunoda
    arunoda committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    7997c1f View commit details
    Browse the repository at this point in the history

  6. Came back to the mitt() based page-loader.

    @arunoda
    arunoda committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    6e0e7b4 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2017

  1. Add link rel=preload support.

    @arunoda
    arunoda committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    95558ae View commit details
    Browse the repository at this point in the history

  2. Fix a typo.

    @arunoda
    arunoda committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    6f735ee View commit details
    Browse the repository at this point in the history