Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add showDefaultLocale option for i18n so that the we can show the def… #19035

Closed
wants to merge 15 commits into from
Closed

Add showDefaultLocale option for i18n so that the we can show the def… #19035

wants to merge 15 commits into from

Conversation

RobinSCU
Copy link

@RobinSCU RobinSCU commented Nov 10, 2020 •
edited by timneutkens
Loading

Added showDefaultLocale option in the i18n config so that the developer can decide if the default locale should part of the Sub-path or not.

For discussion #18419

I personally think that it would be nice when we have this option because we currently rebuild our Webshop with Next.js and this is one feature we need so that we can use the next.js internal i18n solution.

#myfirstpr #pleasebenice :D

Thanks for consideration
Robin

@ijjk
Copy link
Member

ijjk commented Nov 10, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 11.4s 11.4s -22ms
nodeModulesSize 85 MB 85 MB ⚠️ +626 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.086 2.156 ⚠️ +0.07
/ avg req/sec 1198.59 1159.32 ⚠️ -39.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.135 1.149 ⚠️ +0.01
/error-in-render avg req/sec 2203.44 2175.41 ⚠️ -28.03
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-673683e..14c7.js gzip 7.48 kB 7.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.5 kB 58.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0c7333c..dule.js gzip 6.47 kB 6.47 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
index.html gzip 970 B 970 B ✓
link.html gzip 978 B 977 B -1 B
withRouter.html gzip 964 B 963 B -1 B
Overall change 2.91 kB 2.91 kB -2 B

Diffs

Diff for index.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.556d99942c2818856f24.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -123,13 +123,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.556d99942c2818856f24.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.556d99942c2818856f24.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 12.8s 12.9s ⚠️ +92ms
nodeModulesSize 85 MB 85 MB ⚠️ +626 B
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..7d3b.js gzip 11.3 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-673683e..14c7.js gzip 7.48 kB 7.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..a2f0.js gzip N/A 11.3 kB N/A
Overall change 58.5 kB 58.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..dule.js gzip 7.04 kB N/A N/A
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0c7333c..dule.js gzip 6.47 kB 6.47 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 7.04 kB N/A
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_error.js 915 kB 915 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 916 kB 916 kB ✓
link.js 965 kB 965 kB ✓
routerDirect.js 957 kB 957 kB ✓
withRouter.js 957 kB 957 kB ✓
Overall change 4.72 MB 4.72 MB ✓
Commit: 1927d97

@ijjk
Copy link
Member

ijjk commented Nov 11, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 13.9s 13.9s ⚠️ +6ms
nodeModulesSize 85 MB 85 MB ⚠️ +626 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.607 2.581 -0.03
/ avg req/sec 958.88 968.69 +9.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.545 1.555 ⚠️ +0.01
/error-in-render avg req/sec 1618.17 1607.46 ⚠️ -10.71
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-673683e..14c7.js gzip 7.48 kB 7.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.5 kB 58.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0c7333c..dule.js gzip 6.47 kB 6.47 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
index.html gzip 970 B 970 B ✓
link.html gzip 978 B 977 B -1 B
withRouter.html gzip 964 B 963 B -1 B
Overall change 2.91 kB 2.91 kB -2 B

Diffs

Diff for index.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.556d99942c2818856f24.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -123,13 +123,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.556d99942c2818856f24.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.556d99942c2818856f24.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 15.3s 15.6s ⚠️ +316ms
nodeModulesSize 85 MB 85 MB ⚠️ +626 B
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..7d3b.js gzip 11.3 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-673683e..14c7.js gzip 7.48 kB 7.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..a2f0.js gzip N/A 11.3 kB N/A
Overall change 58.5 kB 58.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..dule.js gzip 7.04 kB N/A N/A
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0c7333c..dule.js gzip 6.47 kB 6.47 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 7.04 kB N/A
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_error.js 915 kB 915 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 916 kB 916 kB ✓
link.js 965 kB 965 kB ✓
routerDirect.js 957 kB 957 kB ✓
withRouter.js 957 kB 957 kB ✓
Overall change 4.72 MB 4.72 MB ✓
Commit: 20c615a

@ijjk
Copy link
Member

ijjk commented Nov 11, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 15.2s 14s -1.2s
nodeModulesSize 85 MB 85 MB ⚠️ +626 B
Page Load Tests Overall increase ✓
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.68 2.592 -0.09
/ avg req/sec 932.91 964.63 +31.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.578 1.498 -0.08
/error-in-render avg req/sec 1584 1668.49 +84.49
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..7d3b.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-673683e..14c7.js gzip 7.48 kB 7.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.5 kB 58.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..dule.js gzip 7.04 kB 7.04 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0c7333c..dule.js gzip 6.47 kB 6.47 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
index.html gzip 970 B 970 B ✓
link.html gzip 978 B 977 B -1 B
withRouter.html gzip 964 B 963 B -1 B
Overall change 2.91 kB 2.91 kB -2 B

Diffs

Diff for index.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.556d99942c2818856f24.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -123,13 +123,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.556d99942c2818856f24.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.978ffbabf17b2be9a27e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.556d99942c2818856f24.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6b4511cd17e1524c6341.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.21bb8360a17038c087e6.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 15.7s 16.3s ⚠️ +615ms
nodeModulesSize 85 MB 85 MB ⚠️ +626 B
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..7d3b.js gzip 11.3 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-673683e..14c7.js gzip 7.48 kB 7.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..a2f0.js gzip N/A 11.3 kB N/A
Overall change 58.5 kB 58.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..dule.js gzip 7.04 kB N/A N/A
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0c7333c..dule.js gzip 6.47 kB 6.47 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 7.04 kB N/A
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_error.js 915 kB 915 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 916 kB 916 kB ✓
link.js 965 kB 965 kB ✓
routerDirect.js 957 kB 957 kB ✓
withRouter.js 957 kB 957 kB ✓
Overall change 4.72 MB 4.72 MB ✓
Commit: bc2561b

@ijjk
Copy link
Member

ijjk commented Nov 11, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 14.3s 14s -321ms
nodeModulesSize 84.8 MB 84.8 MB ⚠️ +626 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.709 2.687 -0.02
/ avg req/sec 922.73 930.32 +7.59
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.61 1.628 ⚠️ +0.02
/error-in-render avg req/sec 1552.56 1535.25 ⚠️ -17.31
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..3888.js gzip 11.3 kB 11.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-673683e..14c7.js gzip 7.48 kB 7.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.5 kB 58.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..dule.js gzip 7.05 kB 7.05 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0c7333c..dule.js gzip 6.47 kB 6.47 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
index.html gzip 969 B 969 B ✓
link.html gzip 977 B 978 B ⚠️ +1 B
withRouter.html gzip 963 B 963 B ✓
Overall change 2.91 kB 2.91 kB ⚠️ +1 B

Diffs

Diff for index.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a2ba07a682852f748bcf.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.cc7795d06b4045773c01.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.84827680b822d5d16780.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.1e38b24d28d8cb13087c.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a2ba07a682852f748bcf.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.cc7795d06b4045773c01.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a2ba07a682852f748bcf.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.cc7795d06b4045773c01.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -123,13 +123,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.84827680b822d5d16780.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.1e38b24d28d8cb13087c.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a2ba07a682852f748bcf.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.cc7795d06b4045773c01.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a2ba07a682852f748bcf.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.cc7795d06b4045773c01.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.84827680b822d5d16780.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.1e38b24d28d8cb13087c.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a2ba07a682852f748bcf.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.cc7795d06b4045773c01.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 15.7s 16.1s ⚠️ +436ms
nodeModulesSize 84.8 MB 84.8 MB ⚠️ +626 B
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..3888.js gzip 11.3 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-673683e..14c7.js gzip 7.48 kB 7.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..43cb.js gzip N/A 11.3 kB N/A
Overall change 58.5 kB 58.5 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..dule.js gzip 7.05 kB N/A N/A
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-0c7333c..dule.js gzip 6.47 kB 6.47 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 7.05 kB N/A
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-8a9d104..0e42.js gzip 1.55 kB 1.55 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.96 kB 7.96 kB ✓
Client Pages Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-d1cfb87..dule.js gzip 1.49 kB 1.49 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.59 kB 5.59 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_error.js 916 kB 916 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 916 kB 916 kB ✓
link.js 965 kB 965 kB ✓
routerDirect.js 958 kB 958 kB ✓
withRouter.js 958 kB 958 kB ✓
Overall change 4.72 MB 4.72 MB ✓
Commit: 8cb8bf2

@ijjk
Copy link
Member

ijjk commented Nov 12, 2020

Failing test suites

Commit: 0dd5f07

test/integration/prerender/test/index.test.js

  • SSG Prerender > serverless mode > should reload page on failed data request, and retry
Expand output

● SSG Prerender › serverless mode › should reload page on failed data request, and retry

expect(received).toMatch(expected)

Expected pattern: /post.*?post-999/
Received string:  ""

  689 | 
  690 |       const text = await browser.elementByCss('#params').text()
> 691 |       expect(text).toMatch(/post.*?post-999/)
      |                    ^
  692 |     })
  693 |   }
  694 | 

  at Object.<anonymous> (integration/prerender/test/index.test.js:691:20)
      at runMicrotasks (<anonymous>)

@ijjk
Copy link
Member

ijjk commented Nov 12, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 13.2s 12.5s -666ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +626 B
Page Load Tests Overall increase ✓
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.384 2.303 -0.08
/ avg req/sec 1048.88 1085.46 +36.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.341 1.246 -0.09
/error-in-render avg req/sec 1864.04 2007 +142.96
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-43dd9e5..8439.js gzip 6.48 kB 6.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-472f7d5..dule.js gzip 5.58 kB 5.58 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.5 kB 53.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
index.html gzip 972 B 969 B -3 B
link.html gzip 977 B 977 B ✓
withRouter.html gzip 964 B 963 B -1 B
Overall change 2.91 kB 2.91 kB -4 B

Diffs

Diff for index.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8820a560590f533604a6.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6e5d5ce11bee47189303.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9729a1323ef8c8c6127b.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.31346729cb5a3ba5a3d2.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8820a560590f533604a6.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6e5d5ce11bee47189303.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8820a560590f533604a6.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6e5d5ce11bee47189303.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -123,13 +123,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9729a1323ef8c8c6127b.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.31346729cb5a3ba5a3d2.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8820a560590f533604a6.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6e5d5ce11bee47189303.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -25,7 +25,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8820a560590f533604a6.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6e5d5ce11bee47189303.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -118,13 +118,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.9729a1323ef8c8c6127b.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.31346729cb5a3ba5a3d2.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8820a560590f533604a6.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6e5d5ce11bee47189303.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 14.4s 15.7s ⚠️ +1.3s
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +626 B
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..d9fb.js gzip 12.7 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-43dd9e5..8439.js gzip 6.48 kB 6.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..9638.js gzip N/A 12.7 kB N/A
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..dule.js gzip 8.23 kB N/A N/A
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-472f7d5..dule.js gzip 5.58 kB 5.58 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 8.23 kB N/A
Overall change 53.5 kB 53.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_error.js 916 kB 916 kB ✓
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 916 kB 916 kB ✓
link.js 974 kB 974 kB ✓
routerDirect.js 967 kB 967 kB ✓
withRouter.js 967 kB 967 kB ✓
Overall change 4.75 MB 4.75 MB ✓
Commit: 77f0175

@ambrauer ambrauer mentioned this pull request Nov 13, 2020
Merged
@vercel vercel bot temporarily deployed to Preview November 18, 2020 20:05 Inactive
@ijjk
Copy link
Member

ijjk commented Nov 18, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 11.1s 11.1s ⚠️ +55ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +626 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.591 2.573 -0.02
/ avg req/sec 964.97 971.64 +6.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.657 1.683 ⚠️ +0.03
/error-in-render avg req/sec 1508.64 1485.72 ⚠️ -22.92
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..4972.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f1a49fb..e45e.js gzip 6.52 kB 6.52 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-b618194..5477.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.01 kB 8.01 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
index.html gzip 613 B 614 B ⚠️ +1 B
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 607 B -1 B
Overall change 1.84 kB 1.84 kB ✓

Diffs

Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4d7272f0989b253f541e.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.771721b3b3735796c43f.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4d7272f0989b253f541e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.771721b3b3735796c43f.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4d7272f0989b253f541e.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.771721b3b3735796c43f.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4d7272f0989b253f541e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.771721b3b3735796c43f.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4d7272f0989b253f541e.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.771721b3b3735796c43f.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.4d7272f0989b253f541e.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.771721b3b3735796c43f.js"
       async=""
     ></script>
     <script
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 12.9s 12.9s ⚠️ +24ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +626 B
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..4972.js gzip 12.7 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-f1a49fb..e45e.js gzip 6.52 kB 6.52 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..b2a1.js gzip N/A 12.7 kB N/A
Overall change 58.9 kB 58.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-b618194..5477.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.01 kB 8.01 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_error.js 914 kB 914 kB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 915 kB 915 kB ✓
link.js 973 kB 973 kB ✓
routerDirect.js 966 kB 966 kB ✓
withRouter.js 966 kB 966 kB ✓
Overall change 4.74 MB 4.74 MB ✓
Commit: 3e38478

@vercel vercel bot temporarily deployed to Preview November 25, 2020 15:01 Inactive
@ijjk
Copy link
Member

ijjk commented Nov 25, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 9.7s 10.3s ⚠️ +539ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +626 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.197 2.181 -0.02
/ avg req/sec 1137.97 1146.23 +8.26
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.239 1.256 ⚠️ +0.02
/error-in-render avg req/sec 2018.27 1990.42 ⚠️ -27.85
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..8b81.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-fbd7082..8b7a.js gzip 6.54 kB 6.54 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-b618194..5477.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.01 kB 8.01 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
index.html gzip 614 B 615 B ⚠️ +1 B
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ⚠️ +1 B

Diffs

Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8592ecbddd5517e7e4f9.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.cf06c64642af73b193b6.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8592ecbddd5517e7e4f9.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.cf06c64642af73b193b6.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8592ecbddd5517e7e4f9.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.cf06c64642af73b193b6.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8592ecbddd5517e7e4f9.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.cf06c64642af73b193b6.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8592ecbddd5517e7e4f9.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.cf06c64642af73b193b6.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8592ecbddd5517e7e4f9.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.cf06c64642af73b193b6.js"
       async=""
     ></script>
     <script
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 11.6s 11.5s -157ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +626 B
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..8b81.js gzip 12.8 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-fbd7082..8b7a.js gzip 6.54 kB 6.54 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..7129.js gzip N/A 12.8 kB N/A
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-b618194..5477.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.01 kB 8.01 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_error.js 915 kB 915 kB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 915 kB 915 kB ✓
link.js 973 kB 973 kB ✓
routerDirect.js 966 kB 966 kB ✓
withRouter.js 966 kB 966 kB ✓
Overall change 4.74 MB 4.74 MB ✓
Commit: be3bebd

@lipoolock lipoolock mentioned this pull request Dec 1, 2020
Closed
@vercel vercel bot temporarily deployed to Preview December 2, 2020 20:06 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 2, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 9.4s 9.5s ⚠️ +139ms
nodeModulesSize 82.4 MB 82.4 MB ⚠️ +626 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.892 1.914 ⚠️ +0.02
/ avg req/sec 1321.12 1305.93 ⚠️ -15.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.157 1.187 ⚠️ +0.03
/error-in-render avg req/sec 2161.34 2106.81 ⚠️ -54.53
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..8b6e.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-3c9ff84..1d7c.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.01 kB 8.01 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
index.html gzip 614 B 613 B -1 B
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 607 B -1 B
Overall change 1.84 kB 1.84 kB -2 B

Diffs

Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a8f91a45a8b4eae9202a.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0a68ef4d8274d8c854e8.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a8f91a45a8b4eae9202a.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0a68ef4d8274d8c854e8.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a8f91a45a8b4eae9202a.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0a68ef4d8274d8c854e8.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a8f91a45a8b4eae9202a.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0a68ef4d8274d8c854e8.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a8f91a45a8b4eae9202a.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0a68ef4d8274d8c854e8.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a8f91a45a8b4eae9202a.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.0a68ef4d8274d8c854e8.js"
       async=""
     ></script>
     <script
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 10.9s 11.5s ⚠️ +613ms
nodeModulesSize 82.4 MB 82.4 MB ⚠️ +626 B
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..8b6e.js gzip 12.8 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-3c9ff84..1d7c.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
677f882d2ed8..2f16.js gzip N/A 12.8 kB N/A
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-fca3d..2eb1.js gzip 3.44 kB 3.44 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.01 kB 8.01 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_error.js 997 kB 997 kB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 998 kB 998 kB ✓
link.js 1.05 MB 1.05 MB ✓
routerDirect.js 1.04 MB 1.04 MB ✓
withRouter.js 1.04 MB 1.04 MB ✓
Overall change 5.14 MB 5.14 MB ✓
Commit: 76114ed

@RobinSCU
Copy link
Author

RobinSCU commented Dec 2, 2020

Hey @ijjk @Timer,

can you give me a hint on what the blocker is for this feature / pull request?

Thanks
Robin

@timneutkens
Copy link
Member

timneutkens commented Dec 4, 2020 •
edited
Loading

Needs extensive review, there is no RFC, and the feature request only has 50 👍 currently. It also seems that the implementation is incorrect and there are no tests (but let's first review this extensively before you add tests).

@RobinSCU
Copy link
Author

RobinSCU commented Dec 4, 2020

@timneutkens thanks for the reply!

@vercel vercel bot temporarily deployed to Preview December 30, 2020 11:26 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 30, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 11.7s 11.6s -69ms
nodeModulesSize 83 MB 83 MB ⚠️ +763 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.391 2.347 -0.04
/ avg req/sec 1045.55 1065.14 +19.59
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.664 1.715 ⚠️ +0.05
/error-in-render avg req/sec 1502.7 1457.39 ⚠️ -45.31
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..0acf.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-29e0222..8425.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-21c7af4..bddc.js gzip 1.6 kB 1.6 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.04 kB 8.04 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 320 B 320 B ✓
Overall change 320 B 320 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 622 B ⚠️ +1 B
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.85 kB ⚠️ +1 B

Diffs

Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59db017fa4fde18d87d3.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.65d8196a09e7f403d84c.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59db017fa4fde18d87d3.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.65d8196a09e7f403d84c.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59db017fa4fde18d87d3.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.65d8196a09e7f403d84c.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59db017fa4fde18d87d3.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.65d8196a09e7f403d84c.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59db017fa4fde18d87d3.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.65d8196a09e7f403d84c.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.59db017fa4fde18d87d3.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.65d8196a09e7f403d84c.js"
       async=""
     ></script>
     <script
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 13.7s 14.1s ⚠️ +442ms
nodeModulesSize 83 MB 83 MB ⚠️ +763 B
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..0acf.js gzip 12.8 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-29e0222..8425.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
677f882d2ed8..e934.js gzip N/A 12.8 kB N/A
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-21c7af4..bddc.js gzip 1.6 kB 1.6 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.04 kB 8.04 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 320 B 320 B ✓
Overall change 320 B 320 B ✓
Serverless bundles
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 8d8fd38

@caribou-code
Copy link

Needs extensive review, there is no RFC, and the feature request only has 50 👍 currently. It also seems that the implementation is incorrect and there are no tests (but let's first review this extensively before you add tests).

@timneutkens out of interest, what threshold of upvotes should an idea have to be worked on and accepted? This one has 74 now, which seems like a lot compared to others, but it's difficult to know without understanding the threshold. Thanks

@svassaux
Copy link

svassaux commented Jan 12, 2021 •
edited
Loading

we want this ! current system is bad for SEO (we don't want to index pages without a locale)

@ijjk
Copy link
Member

ijjk commented Jan 13, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 7.6s 8s ⚠️ +392ms
nodeModulesSize 76.2 MB 80.9 MB ⚠️ +4.68 MB
Page Load Tests Overall increase ✓
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.564 1.508 -0.06
/ avg req/sec 1598.87 1658.01 +59.14
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.008 1.013 0
/error-in-render avg req/sec 2481.2 2468.88 ⚠️ -12.32
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
index.html gzip 615 B 615 B ✓
link.html gzip 619 B 621 B ⚠️ +2 B
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ⚠️ +2 B

Diffs

Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a45bac3e08278884f33a.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.44e6ab875fc0a7998405.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a45bac3e08278884f33a.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.44e6ab875fc0a7998405.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a45bac3e08278884f33a.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.44e6ab875fc0a7998405.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a45bac3e08278884f33a.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.44e6ab875fc0a7998405.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a45bac3e08278884f33a.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.44e6ab875fc0a7998405.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.a45bac3e08278884f33a.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.44e6ab875fc0a7998405.js"
       async=""
     ></script>
     <script
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 9.4s 9.3s -171ms
nodeModulesSize 80.9 MB 80.9 MB ⚠️ +764 B
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..b025.js gzip 13.1 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
677f882d2ed8..996a.js gzip N/A 13.1 kB N/A
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 7693c26

@hshahdoost
Copy link

I think any company who is using the localization feature and cares for SEO would need this feature, Please review the request. We are currently using hacky solutions which is really ugly.

@zEh-
Copy link

zEh- commented Jan 20, 2021 •
edited
Loading

We're considering switching to the manual way through a lang-param-folder because we need control over this.
Would it somehow be possible to have this feature but also an opt-out for non-localized routes? I'd prefer (some) API-routes and other per-project routes like OAuth to be global as they might not need locale information or handle it differently by like a state search param or a header. This would also reduce caching as I understand it.

@RobinSCU RobinSCU marked this pull request as draft January 21, 2021 20:34
@ijjk
Copy link
Member

ijjk commented Jan 21, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 11.6s 11.4s -269ms
nodeModulesSize 73.3 MB 73.3 MB ⚠️ +765 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.323 2.408 ⚠️ +0.08
/ avg req/sec 1076.25 1038.2 ⚠️ -38.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.594 1.691 ⚠️ +0.1
/error-in-render avg req/sec 1568.37 1478.67 ⚠️ -89.7
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
index.html gzip 616 B 614 B -2 B
link.html gzip 621 B 620 B -1 B
withRouter.html gzip 609 B 608 B -1 B
Overall change 1.85 kB 1.84 kB -4 B

Diffs

Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d2871d212a15daaa90ee.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d2871d212a15daaa90ee.js"
       async=""
     ></script>
     <script
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d2871d212a15daaa90ee.js"
       as="script"
     />
     <link
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d2871d212a15daaa90ee.js"
       async=""
     ></script>
     <script
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d2871d212a15daaa90ee.js"
       as="script"
     />
     <link
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.68413f75a18d3759e1c6.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.d2871d212a15daaa90ee.js"
       async=""
     ></script>
     <script
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 13.7s 13.2s -437ms
nodeModulesSize 73.3 MB 73.3 MB ⚠️ +765 B
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
677f882d2ed8..43e3.js gzip 13.1 kB N/A N/A
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
677f882d2ed8..c573.js gzip N/A 13.1 kB N/A
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
buildDuration 13.7s 13.8s ⚠️ +71ms
nodeModulesSize 73.3 MB 73.3 MB ⚠️ +765 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.309 2.337 ⚠️ +0.03
/ avg req/sec 1082.83 1069.82 ⚠️ -13.01
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.588 1.633 ⚠️ +0.04
/error-in-render avg req/sec 1574.02 1530.65 ⚠️ -43.37
Client Bundles (main, webpack, commons)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary RobinSCU/next.js i18n/default-sub-path Change
index.html gzip 585 B 586 B ⚠️ +1 B
link.html gzip 592 B 592 B ✓
withRouter.html gzip 579 B 580 B ⚠️ +1 B
Overall change 1.76 kB 1.76 kB ⚠️ +2 B

Diffs

Diff for index.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ef43eed5fc6595ebc573.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "DKmCOtmXeHF4Mi85UuWrX",
+        "buildId": "al1utWoDBAMWuuX7LSErS",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ef43eed5fc6595ebc573.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/DKmCOtmXeHF4Mi85UuWrX/_buildManifest.js"
+      src="/_next/static/al1utWoDBAMWuuX7LSErS/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/DKmCOtmXeHF4Mi85UuWrX/_ssgManifest.js"
+      src="/_next/static/al1utWoDBAMWuuX7LSErS/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ef43eed5fc6595ebc573.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "DKmCOtmXeHF4Mi85UuWrX",
+        "buildId": "al1utWoDBAMWuuX7LSErS",
         "isFallback": false,
         "gip": true
       }
@@ -70,7 +70,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ef43eed5fc6595ebc573.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/DKmCOtmXeHF4Mi85UuWrX/_buildManifest.js"
+      src="/_next/static/al1utWoDBAMWuuX7LSErS/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/DKmCOtmXeHF4Mi85UuWrX/_ssgManifest.js"
+      src="/_next/static/al1utWoDBAMWuuX7LSErS/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -22,7 +22,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ef43eed5fc6595ebc573.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "DKmCOtmXeHF4Mi85UuWrX",
+        "buildId": "al1utWoDBAMWuuX7LSErS",
         "isFallback": false,
         "gip": true
       }
@@ -65,7 +65,7 @@
       async=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7457634b2036a74e43e3.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.ef43eed5fc6595ebc573.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/DKmCOtmXeHF4Mi85UuWrX/_buildManifest.js"
+      src="/_next/static/al1utWoDBAMWuuX7LSErS/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/DKmCOtmXeHF4Mi85UuWrX/_ssgManifest.js"
+      src="/_next/static/al1utWoDBAMWuuX7LSErS/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 829508d

@RobinSCU
Copy link
Author

I closed the PR because I think the implementation should be done by someone who has a deeper understanding of the i18n integration in Next.js

@RobinSCU RobinSCU closed this Jan 21, 2021
@nbouvrette
Copy link
Contributor

Related to #20240

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

@chibicode chibicode Awaiting requested review from chibicode

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@RobinSCU @ijjk @timneutkens @caribou-code @svassaux @hshahdoost @zEh- @nbouvrette