Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable handling for revalidate and notFound #19165

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 14, 2020

This allows SSG pages that return notFound to be revalidated.

Closes: #18651

@vercel vercel bot temporarily deployed to Preview November 14, 2020 05:43 Inactive
@ijjk
Copy link
Member Author

ijjk commented Nov 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
buildDuration 13s 12.9s -87ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +2.03 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
/ failed reqs 0 0
/ total time (seconds) 2.45 2.367 -0.08
/ avg req/sec 1020.26 1056.15 +35.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.229 1.284 ⚠️ +0.05
/error-in-render avg req/sec 2034.07 1947.46 ⚠️ -86.61
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB
framework.HASH.js gzip 39 kB 39 kB
main-495c6c9..66a1.js gzip 6.53 kB 6.53 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.9 kB 58.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-b42e726..dule.js gzip 5.64 kB 5.64 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53.6 kB 53.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB
_error-6f635..c393.js gzip 3.44 kB 3.44 kB
hooks-d4ffc3..9e0f.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.98 kB 7.98 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-973cce3..dule.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.6 kB 5.6 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
_buildManifest.js gzip 321 B 321 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
index.html gzip 970 B 970 B
link.html gzip 976 B 976 B
withRouter.html gzip 962 B 962 B
Overall change 2.91 kB 2.91 kB

Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
buildDuration 14.8s 15s ⚠️ +277ms
nodeModulesSize 84.9 MB 84.9 MB ⚠️ +2.03 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
677f882d2ed8..d9fb.js gzip 12.7 kB 12.7 kB
framework.HASH.js gzip 39 kB 39 kB
main-495c6c9..66a1.js gzip 6.53 kB 6.53 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.9 kB 58.9 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-b42e726..dule.js gzip 5.64 kB 5.64 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53.6 kB 53.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB
_error-6f635..c393.js gzip 3.44 kB 3.44 kB
hooks-d4ffc3..9e0f.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.98 kB 7.98 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-973cce3..dule.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.6 kB 5.6 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
_buildManifest.js gzip 321 B 321 B
_buildManife..dule.js gzip 330 B 330 B
Overall change 651 B 651 B
Serverless bundles Overall increase ⚠️
vercel/next.js canary ijjk/next.js ssg/enable-404-revalidate Change
_error.js 917 kB 918 kB ⚠️ +266 B
404.html 4.61 kB 4.61 kB
hooks.html 3.86 kB 3.86 kB
index.js 918 kB 918 kB ⚠️ +266 B
link.js 976 kB 976 kB ⚠️ +266 B
routerDirect.js 969 kB 969 kB ⚠️ +266 B
withRouter.js 969 kB 969 kB ⚠️ +266 B
Overall change 4.76 MB 4.76 MB ⚠️ +1.33 kB
Commit: a1f953b

@kodiakhq kodiakhq bot merged commit a32b1f4 into vercel:canary Nov 14, 2020
@Timer Timer deleted the ssg/enable-404-revalidate branch November 14, 2020 07:12
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 pages in a SSG site are not revalidated in Next 10
2 participants