Add required server files manifest #20035

ijjk · 2020-12-09T17:53:49Z

This keeps track of required server files in a manifest file

…iles # Conflicts: # packages/next/next-server/server/next-server.ts

ijjk · 2020-12-09T18:02:54Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js required-server-files	Change
buildDuration	10.1s	10s	-89ms
nodeModulesSize	82.5 MB	82.5 MB	⚠️ +11 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js required-server-files	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.385	2.47	⚠️ +0.09
/ avg req/sec	1048.17	1012.25	⚠️ -35.92
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.256	1.287	⚠️ +0.03
/error-in-render avg req/sec	1990.9	1942.62	⚠️ -48.28

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js required-server-files	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-899eb31..d9d9.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js required-server-files	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..fd29.js gzip	303 B	303 B	✓
withRouter-b..76ae.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js required-server-files	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js required-server-files	Change
buildDuration	12.1s	11.5s	-590ms
nodeModulesSize	82.5 MB	82.5 MB	⚠️ +11 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js required-server-files	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-899eb31..d9d9.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js required-server-files	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..fd29.js gzip	303 B	303 B	✓
withRouter-b..76ae.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_error.js	1 MB	1 MB	⚠️ +572 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	⚠️ +572 B
link.js	1.06 MB	1.06 MB	⚠️ +572 B
routerDirect.js	1.05 MB	1.05 MB	⚠️ +572 B
withRouter.js	1.05 MB	1.05 MB	⚠️ +572 B
Overall change	5.16 MB	5.16 MB	⚠️ +2.86 kB

Commit: 8eb781d

…iles

ijjk · 2020-12-10T22:29:05Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js required-server-files	Change
buildDuration	8.7s	8.7s	-59ms
nodeModulesSize	82.5 MB	82.5 MB	⚠️ +14 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js required-server-files	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.127	1.989	-0.14
/ avg req/sec	1175.62	1256.87	+81.25
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.171	1.121	-0.05
/error-in-render avg req/sec	2135.68	2229.83	+94.15

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js required-server-files	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3e8cb31..cddc.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js required-server-files	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..fd29.js gzip	303 B	303 B	✓
withRouter-b..76ae.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js required-server-files	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js required-server-files	Change
buildDuration	10.2s	10.2s	⚠️ +1ms
nodeModulesSize	82.5 MB	82.5 MB	⚠️ +14 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js required-server-files	Change
677f882d2ed8..34b9.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3e8cb31..cddc.js gzip	6.56 kB	6.56 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js required-server-files	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_app-7231d4b..5856.js gzip	1.28 kB	1.28 kB	✓
_error-01375..90b6.js gzip	3.69 kB	3.69 kB	✓
hooks-d4591d..e7c2.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-db223d9..dbd7.js gzip	1.61 kB	1.61 kB	✓
routerDirect..fd29.js gzip	303 B	303 B	✓
withRouter-b..76ae.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_error.js	1 MB	1 MB	⚠️ +692 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	⚠️ +692 B
link.js	1.06 MB	1.06 MB	⚠️ +692 B
routerDirect.js	1.05 MB	1.05 MB	⚠️ +692 B
withRouter.js	1.05 MB	1.05 MB	⚠️ +692 B
Overall change	5.16 MB	5.16 MB	⚠️ +3.46 kB

Commit: fe89d28

packages/next/build/index.ts

…iles

ijjk · 2020-12-16T20:32:49Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js required-server-files	Change
buildDuration	10.5s	10.6s	⚠️ +80ms
nodeModulesSize	82.4 MB	82.4 MB	⚠️ +13.9 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js required-server-files	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.42	2.476	⚠️ +0.06
/ avg req/sec	1033.08	1009.68	⚠️ -23.4
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.293	1.346	⚠️ +0.05
/error-in-render avg req/sec	1933.18	1857.08	⚠️ -76.1

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js required-server-files	Change
677f882d2ed8..0679.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-008bb91..b823.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59.1 kB	59.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js required-server-files	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.69 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js required-server-files	Change
index.html gzip	615 B	615 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	609 B	609 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js required-server-files	Change
buildDuration	12.8s	12.5s	-283ms
nodeModulesSize	82.4 MB	82.4 MB	⚠️ +13.9 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js required-server-files	Change
677f882d2ed8..0679.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-008bb91..b823.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59.1 kB	59.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js required-server-files	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.69 kB	✓
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.31 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js required-server-files	Change
_error.js	1 MB	1 MB	⚠️ +692 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	⚠️ +692 B
link.js	1.06 MB	1.06 MB	⚠️ +692 B
routerDirect.js	1.05 MB	1.05 MB	⚠️ +692 B
withRouter.js	1.05 MB	1.05 MB	⚠️ +692 B
Overall change	5.16 MB	5.16 MB	⚠️ +3.46 kB

Commit: 1d6083e

ijjk added 8 commits December 4, 2020 00:47

Add required server files and minimal handling

1e1f36f

Add config to required server files

fbde83b

Handle matched path

9dded89

Merge remote-tracking branch 'upstream/canary' into required-server-f…

ca87eb3

…iles # Conflicts: # packages/next/next-server/server/next-server.ts

Update test to ensure paths exist

3a87477

Omit config file path

ebda95d

Disable redirects in minimal mode

467e951

Merge remote-tracking branch 'upstream/canary' into required-server-f…

8eb781d

…iles # Conflicts: # packages/next/next-server/server/next-server.ts

ijjk requested review from lfades, Timer and timneutkens as code owners December 9, 2020 17:53

ijjk added the type: next label Dec 9, 2020

vercel bot temporarily deployed to Preview December 9, 2020 17:53 Inactive

ijjk added 3 commits December 10, 2020 12:08

Merge remote-tracking branch 'upstream/canary' into required-server-f…

5bc70e3

…iles

Ensure _next/data resolves against matched path

d1d6849

Merge remote-tracking branch 'upstream/canary' into required-server-f…

fe89d28

…iles

vercel bot temporarily deployed to Preview December 10, 2020 22:21 Inactive

timneutkens reviewed Dec 16, 2020

View reviewed changes

packages/next/build/index.ts Show resolved Hide resolved

ijjk added 2 commits December 16, 2020 14:19

Merge remote-tracking branch 'upstream/canary' into required-server-f…

3739ae7

…iles

Remove extra array spread

1d6083e

vercel bot temporarily deployed to Preview December 16, 2020 20:23 Inactive

ijjk requested a review from timneutkens December 16, 2020 20:23

timneutkens approved these changes Dec 16, 2020

View reviewed changes

kodiakhq bot merged commit e819e00 into vercel:canary Dec 16, 2020

ijjk deleted the required-server-files branch December 16, 2020 23:03

jorrit mentioned this pull request Dec 24, 2020

sharp no longer optional since 10.0.4-canary.7 #20456

Closed

snyk-bot mentioned this pull request May 26, 2021

[Snyk] Security upgrade @next/bundle-analyzer from 9.5.5 to 10.0.4 majacQ/next.js#115

Open

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add required server files manifest #20035

Add required server files manifest #20035

ijjk commented Dec 9, 2020

ijjk commented Dec 9, 2020

ijjk commented Dec 10, 2020

ijjk commented Dec 16, 2020

Add required server files manifest #20035

Add required server files manifest #20035

Conversation

ijjk commented Dec 9, 2020

ijjk commented Dec 9, 2020

Stats from current PR

ijjk commented Dec 10, 2020

Stats from current PR

ijjk commented Dec 16, 2020

Stats from current PR