Add image component support for ImageEngine Image CDN #20179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamermans
requested review from
chibicode,
ijjk,
lfades,
Timer and
timneutkens
as code owners
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| buildDuration | 9s | 9.1s | |
| nodeModulesSize | 82.4 MB | 82.4 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.087 | 2.131 | |
| / avg req/sec | 1198 | 1173.35 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.077 | 1.121 | |
| /error-in-render avg req/sec | 2321.24 | 2230.69 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| 677f882d2ed8..0679.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-b992ce4..2479.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-95c2..e870.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.1 kB | 59.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| polyfills-d3..23f6.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| _app-0d19cb6..5497.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-2cf0e..a0a0.js gzip | 3.69 kB | 3.69 kB | ✓ |
| hooks-42456f..0c06.js gzip | 887 B | 887 B | ✓ |
| index-8081ce..e44f.js gzip | 227 B | 227 B | ✓ |
| link-0ab9f83..fa00.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..c3d8.js gzip | 303 B | 303 B | ✓ |
| withRouter-0..a68e.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.31 kB | 8.31 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 323 B | 323 B | ✓ |
| Overall change | 323 B | 323 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| index.html gzip | 615 B | 615 B | ✓ |
| link.html gzip | 620 B | 620 B | ✓ |
| withRouter.html gzip | 608 B | 608 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| buildDuration | 10.9s | 10.5s | -425ms |
| nodeModulesSize | 82.4 MB | 82.4 MB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| 677f882d2ed8..0679.js gzip | 12.8 kB | 12.8 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-b992ce4..2479.js gzip | 6.56 kB | 6.56 kB | ✓ |
| webpack-95c2..e870.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.1 kB | 59.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| polyfills-d3..23f6.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| _app-0d19cb6..5497.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-2cf0e..a0a0.js gzip | 3.69 kB | 3.69 kB | ✓ |
| hooks-42456f..0c06.js gzip | 887 B | 887 B | ✓ |
| index-8081ce..e44f.js gzip | 227 B | 227 B | ✓ |
| link-0ab9f83..fa00.js gzip | 1.61 kB | 1.61 kB | ✓ |
| routerDirect..c3d8.js gzip | 303 B | 303 B | ✓ |
| withRouter-0..a68e.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.31 kB | 8.31 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 323 B | 323 B | ✓ |
| Overall change | 323 B | 323 B | ✓ |
Serverless bundles
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| _error.js | 1 MB | 1 MB | ✓ |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 1 MB | 1 MB | ✓ |
| link.js | 1.06 MB | 1.06 MB | ✓ |
| routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
| withRouter.js | 1.05 MB | 1.05 MB | ✓ |
| Overall change | 5.16 MB | 5.16 MB | ✓ |
kamermans
force-pushed
the
imageengine-image-cdn
branch
from
104931a
to
409f093
Compare
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| buildDuration | 8.7s | 8.5s | -173ms |
| nodeModulesSize | 80.6 MB | 80.6 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 1.784 | 1.758 | -0.03 |
| / avg req/sec | 1401.56 | 1421.85 | +20.29 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.058 | 1.105 | |
| /error-in-render avg req/sec | 2362.64 | 2261.69 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| 677f882d2ed8..396f.js gzip | 13 kB | 13 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-a9a6f0d..a96d.js gzip | 6.59 kB | 6.59 kB | ✓ |
| webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.3 kB | 59.3 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
| Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| _app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
| hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
| index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
| link-705099c..c35d.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
| withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 323 B | 323 B | ✓ |
| Overall change | 323 B | 323 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| index.html gzip | 615 B | 615 B | ✓ |
| link.html gzip | 621 B | 621 B | ✓ |
| withRouter.html gzip | 607 B | 607 B | ✓ |
| Overall change | 1.84 kB | 1.84 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| buildDuration | 10.7s | 10.4s | -307ms |
| nodeModulesSize | 80.6 MB | 80.6 MB |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| 677f882d2ed8..396f.js gzip | 13 kB | 13 kB | ✓ |
| framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
| main-a9a6f0d..a96d.js gzip | 6.59 kB | 6.59 kB | ✓ |
| webpack-50be..df5b.js gzip | 751 B | 751 B | ✓ |
| Overall change | 59.3 kB | 59.3 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| polyfills-81..14d7.js gzip | 31.2 kB | 31.2 kB | ✓ |
| Overall change | 31.2 kB | 31.2 kB | ✓ |
Client Pages
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| _app-b6fc6bc..222c.js gzip | 1.28 kB | 1.28 kB | ✓ |
| _error-e2ffa..0f3f.js gzip | 3.46 kB | 3.46 kB | ✓ |
| hooks-010c20..8411.js gzip | 887 B | 887 B | ✓ |
| index-bbee2f..528b.js gzip | 227 B | 227 B | ✓ |
| link-705099c..c35d.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..bf84.js gzip | 303 B | 303 B | ✓ |
| withRouter-a..5826.js gzip | 302 B | 302 B | ✓ |
| Overall change | 8.09 kB | 8.09 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 323 B | 323 B | ✓ |
| Overall change | 323 B | 323 B | ✓ |
Serverless bundles
| vercel/next.js canary | kamermans/next.js imageengine-image-cdn | Change | |
|---|---|---|---|
| _error.js | 1 MB | 1 MB | ✓ |
| 404.html | 2.67 kB | 2.67 kB | ✓ |
| hooks.html | 1.92 kB | 1.92 kB | ✓ |
| index.js | 1 MB | 1 MB | ✓ |
| link.js | 1.06 MB | 1.06 MB | ✓ |
| routerDirect.js | 1.05 MB | 1.05 MB | ✓ |
| withRouter.js | 1.05 MB | 1.05 MB | ✓ |
| Overall change | 5.17 MB | 5.17 MB | ✓ |
|
Closing this PR in favor of #18606 which will allow custom loaders to be used without having them built-in. Thanks for the PR! |
|
Ok, thanks for the info @timneutkens! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ImageEngine, a popular image optimization CDN from the folks at ScientiaMobile (full disclosure: I am one of the open-source devs that started this company).
This integration supports width-based resizing and quality adjustments like the built-in optimizer.
(I closed my previous PR because it was blocked on a change request I had already made)