Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font-stylesheet-gathering-plugin to be webpack 5 compatible #20229

Conversation

timneutkens
Copy link
Member

Solves the following warning:

(node:1484) [DEP_WEBPACK_MAIN_TEMPLATE_REQUIRE_FN] DeprecationWarning: MainTemplate.requireFn is deprecated (use "webpack_require")

Solves the following warning:

> (node:1484) [DEP_WEBPACK_MAIN_TEMPLATE_REQUIRE_FN] DeprecationWarning: MainTemplate.requireFn is deprecated (use "__webpack_require__")
@vercel vercel bot temporarily deployed to Preview December 16, 2020 12:10 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
buildDuration 8.6s 8.9s ⚠️ +292ms
nodeModulesSize 82.4 MB 82.4 MB ⚠️ +96 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
/ failed reqs 0 0
/ total time (seconds) 2.038 2.064 ⚠️ +0.03
/ avg req/sec 1226.68 1211.44 ⚠️ -15.24
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.086 1.103 ⚠️ +0.02
/error-in-render avg req/sec 2302.88 2267.25 ⚠️ -35.63
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-008bb91..b823.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59.1 kB 59.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
index.html gzip 615 B 615 B
link.html gzip 621 B 621 B
withRouter.html gzip 609 B 609 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
buildDuration 10.3s 10.2s -54ms
nodeModulesSize 82.4 MB 82.4 MB ⚠️ +96 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
677f882d2ed8..0679.js gzip 12.8 kB 12.8 kB
framework.HASH.js gzip 39 kB 39 kB
main-008bb91..b823.js gzip 6.56 kB 6.56 kB
webpack-95c2..e870.js gzip 751 B 751 B
Overall change 59.1 kB 59.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
polyfills-d3..23f6.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB
_error-2cf0e..a0a0.js gzip 3.69 kB 3.69 kB
hooks-42456f..0c06.js gzip 887 B 887 B
index-8081ce..e44f.js gzip 227 B 227 B
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB
routerDirect..c3d8.js gzip 303 B 303 B
withRouter-0..a68e.js gzip 302 B 302 B
Overall change 8.31 kB 8.31 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/webpack5-deprecation-warning-font-plugin Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.16 MB 5.16 MB
Commit: 2e7a141

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants