temporary: re-flag font optimization #20372

Timer · 2020-12-21T16:59:14Z

There's currently two bugs with the font optimization, but we'd really like to ship a stable version.

To unblock the stable release, we're temporarily reflagging this. It'll be unflagged on canary again!

ijjk · 2020-12-21T17:07:20Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
buildDuration	8.4s	8.8s	⚠️ +402ms
nodeModulesSize	82.6 MB	82.6 MB	⚠️ +5 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.997	1.77	-0.23
/ avg req/sec	1251.88	1412.22	+160.34
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.085	1.098	⚠️ +0.01
/error-in-render avg req/sec	2303.37	2276.23	⚠️ -27.14

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1f21dcf..0011.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall decrease ✓

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.44 kB	-257 B
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.05 kB	-257 B

Client Build Manifests

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
index.html gzip	612 B	612 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Diffs

Diff for _buildManifest.js

@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
   __rewrites: [],
   "/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
   "/_error": [
-    "static\u002Fchunks\u002Fpages\u002F_error-fbaccf4d6b3c31a2915e.js"
+    "static\u002Fchunks\u002Fpages\u002F_error-671dbf297c19f6f715f8.js"
   ],
   "/hooks": [
     "static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"

Diff for _error-fbacc..c31a2915e.js

@@ -535,23 +535,8 @@ Also adds support for deduplicated `key` properties
           .map(function(c, i) {
             var key = c.key || i;
 
-            if (true && !props.inAmpMode) {
-              if (
-                c.type === "link" &&
-                c.props["href"] && // TODO(prateekbh@): Replace this with const from `constants` when the tree shaking works.
-                ["https://fonts.googleapis.com/css"].some(function(url) {
-                  return c.props["href"].startsWith(url);
-                })
-              ) {
-                var newProps = _objectSpread({}, c.props || {});
-
-                newProps["data-href"] = newProps["href"];
-                newProps["href"] = undefined;
-                return /*#__PURE__*/ _react["default"].cloneElement(
-                  c,
-                  newProps
-                );
-              }
+            if (false) {
+              var newProps;
             }
 
             return /*#__PURE__*/ _react["default"].cloneElement(c, {

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
buildDuration	9.8s	10.5s	⚠️ +654ms
nodeModulesSize	82.6 MB	82.6 MB	⚠️ +5 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1f21dcf..0011.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall decrease ✓

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	N/A	N/A
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
_error-85785..a9f3.js gzip	N/A	3.44 kB	N/A
Overall change	8.31 kB	8.05 kB	-257 B

Client Build Manifests

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_error.js	1 MB	1 MB	-907 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	-907 B
link.js	1.06 MB	1.06 MB	-907 B
routerDirect.js	1.05 MB	1.05 MB	-907 B
withRouter.js	1.05 MB	1.05 MB	-907 B
Overall change	5.16 MB	5.16 MB	-4.54 kB

Commit: 36489da

ijjk · 2020-12-21T17:11:34Z

Failing test suites

Commit: 36489da

test/integration/font-optimization/test/index.test.js

Font optimization for emulated serverless apps > should inline the google fonts for static pages
Font optimization for emulated serverless apps > should inline the google fonts for static pages with Next/Head
Font optimization for emulated serverless apps > should inline the google fonts for SSR pages

Expand output

● Font optimization for emulated serverless apps › should inline the google fonts for static pages

expect(received).toMatch(expected)

Expected pattern: /<style data-href="https:\/\/fonts\.googleapis\.com\/css\?family=Voces">.*<\/style>/
Received string:  "<!DOCTYPE html><html><head><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css?family=Voces\"/><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><noscript data-n-css=\"\"></noscript><link rel=\"preload\" href=\"/_next/static/chunks/main-900edc5937ffcaff41f2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-95c2b224bccf352ee870.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.7772abbf0576bbdde379.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.05728be7d9121c6d1687.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.c147773867e352ef2e6f.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-a28cd453ca55fb4466af.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/index-c7d60046023b57a50ff9.js\" as=\"script\"/></head><body><div id=\"__next\"><div>Hi!</div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/\",\"query\":{},\"buildId\":\"Q6DNo88KXz45DrOkmnqm-\",\"runtimeConfig\":{},\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-91aba805b9878acb8ecf.js\"></script><script src=\"/_next/static/chunks/main-900edc5937ffcaff41f2.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-95c2b224bccf352ee870.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.7772abbf0576bbdde379.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.05728be7d9121c6d1687.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.c147773867e352ef2e6f.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-a28cd453ca55fb4466af.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/index-c7d60046023b57a50ff9.js\" async=\"\"></script><script src=\"/_next/static/Q6DNo88KXz45DrOkmnqm-/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/Q6DNo88KXz45DrOkmnqm-/_ssgManifest.js\" async=\"\"></script></body></html>"

  48 |       '<link rel="stylesheet" data-href="https://fonts.googleapis.com/css?family=Voces"/>'
  49 |     )
> 50 |     expect(html).toMatch(
     |                  ^
  51 |       /<style data-href="https:\/\/fonts\.googleapis\.com\/css\?family=Voces">.*<\/style>/
  52 |     )
  53 |   })

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:50:18)

● Font optimization for emulated serverless apps › should inline the google fonts for static pages with Next/Head

expect(received).toContain(expected) // indexOf

Expected substring: "<link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css2?family=Modak\"/>"
Received string:    "<!DOCTYPE html><html><head><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css?family=Voces\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta charSet=\"utf-8\"/><link href=\"https://fonts.googleapis.com/css2?family=Modak\" rel=\"stylesheet\"/><meta name=\"next-head-count\" content=\"3\"/><noscript data-n-css=\"\"></noscript><link rel=\"preload\" href=\"/_next/static/chunks/main-900edc5937ffcaff41f2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-95c2b224bccf352ee870.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.7772abbf0576bbdde379.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.05728be7d9121c6d1687.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.c147773867e352ef2e6f.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-a28cd453ca55fb4466af.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/static-head-2ffeb21e5b0787018231.js\" as=\"script\"/></head><body><div id=\"__next\"><div>Hi!</div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/static-head\",\"query\":{},\"buildId\":\"Q6DNo88KXz45DrOkmnqm-\",\"runtimeConfig\":{},\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-91aba805b9878acb8ecf.js\"></script><script src=\"/_next/static/chunks/main-900edc5937ffcaff41f2.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-95c2b224bccf352ee870.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.7772abbf0576bbdde379.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.05728be7d9121c6d1687.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.c147773867e352ef2e6f.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-a28cd453ca55fb4466af.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/static-head-2ffeb21e5b0787018231.js\" async=\"\"></script><script src=\"/_next/static/Q6DNo88KXz45DrOkmnqm-/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/Q6DNo88KXz45DrOkmnqm-/_ssgManifest.js\" async=\"\"></script></body></html>"

  56 |     const html = await renderViaHTTP(appPort, '/static-head')
  57 |     expect(await fsExists(builtPage('font-manifest.json'))).toBe(true)
> 58 |     expect(html).toContain(
     |                  ^
  59 |       '<link rel="stylesheet" data-href="https://fonts.googleapis.com/css2?family=Modak"/>'
  60 |     )
  61 |     expect(html).toMatch(

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:58:18)

● Font optimization for emulated serverless apps › should inline the google fonts for SSR pages

expect(received).toContain(expected) // indexOf

Expected substring: "<link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css2?family=Roboto:wght@700\"/>"
Received string:    "<!DOCTYPE html><html><head><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css?family=Voces\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta charSet=\"utf-8\"/><title>Create Next App</title><link rel=\"icon\" href=\"/favicon.ico\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css2?family=Roboto:wght@700\"/><meta name=\"next-head-count\" content=\"5\"/><noscript data-n-css=\"\"></noscript><link rel=\"preload\" href=\"/_next/static/chunks/main-900edc5937ffcaff41f2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-95c2b224bccf352ee870.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.7772abbf0576bbdde379.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.05728be7d9121c6d1687.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.c147773867e352ef2e6f.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-a28cd453ca55fb4466af.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/stars-51a1f62edbfd69ec0155.js\" as=\"script\"/></head><body><div id=\"__next\"><div class=\"container\"><main><div>Next stars: <!-- -->768.3951655761525</div></main></div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"stars\":768.3951655761525}},\"page\":\"/stars\",\"query\":{},\"buildId\":\"Q6DNo88KXz45DrOkmnqm-\",\"runtimeConfig\":{},\"nextExport\":false,\"isFallback\":false,\"gip\":true}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-91aba805b9878acb8ecf.js\"></script><script src=\"/_next/static/chunks/main-900edc5937ffcaff41f2.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-95c2b224bccf352ee870.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.7772abbf0576bbdde379.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.05728be7d9121c6d1687.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.c147773867e352ef2e6f.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-a28cd453ca55fb4466af.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/stars-51a1f62edbfd69ec0155.js\" async=\"\"></script><script src=\"/_next/static/Q6DNo88KXz45DrOkmnqm-/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/Q6DNo88KXz45DrOkmnqm-/_ssgManifest.js\" async=\"\"></script></body></html>"

  67 |     const html = await renderViaHTTP(appPort, '/stars')
  68 |     expect(await fsExists(builtPage('font-manifest.json'))).toBe(true)
> 69 |     expect(html).toContain(
     |                  ^
  70 |       '<link rel="stylesheet" data-href="https://fonts.googleapis.com/css2?family=Roboto:wght@700"/>'
  71 |     )
  72 |     expect(html).toMatch(

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:69:18)

ijjk · 2020-12-21T17:55:08Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
buildDuration	8.7s	8.6s	-187ms
nodeModulesSize	82.6 MB	82.6 MB	⚠️ +5.21 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.128	1.677	-0.45
/ avg req/sec	1174.92	1491.04	+316.12
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.065	1.074	⚠️ +0.01
/error-in-render avg req/sec	2347.57	2327.47	⚠️ -20.1

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1f21dcf..0011.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall decrease ✓

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.44 kB	-257 B
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.05 kB	-257 B

Client Build Manifests

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
index.html gzip	612 B	612 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Diffs

Diff for _buildManifest.js

@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
   __rewrites: [],
   "/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
   "/_error": [
-    "static\u002Fchunks\u002Fpages\u002F_error-fbaccf4d6b3c31a2915e.js"
+    "static\u002Fchunks\u002Fpages\u002F_error-671dbf297c19f6f715f8.js"
   ],
   "/hooks": [
     "static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"

Diff for _error-fbacc..c31a2915e.js

@@ -535,23 +535,8 @@ Also adds support for deduplicated `key` properties
           .map(function(c, i) {
             var key = c.key || i;
 
-            if (true && !props.inAmpMode) {
-              if (
-                c.type === "link" &&
-                c.props["href"] && // TODO(prateekbh@): Replace this with const from `constants` when the tree shaking works.
-                ["https://fonts.googleapis.com/css"].some(function(url) {
-                  return c.props["href"].startsWith(url);
-                })
-              ) {
-                var newProps = _objectSpread({}, c.props || {});
-
-                newProps["data-href"] = newProps["href"];
-                newProps["href"] = undefined;
-                return /*#__PURE__*/ _react["default"].cloneElement(
-                  c,
-                  newProps
-                );
-              }
+            if (false) {
+              var newProps;
             }
 
             return /*#__PURE__*/ _react["default"].cloneElement(c, {

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
buildDuration	10.1s	10.2s	⚠️ +97ms
nodeModulesSize	82.6 MB	82.6 MB	⚠️ +5.21 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1f21dcf..0011.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall decrease ✓

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	N/A	N/A
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
_error-85785..a9f3.js gzip	N/A	3.44 kB	N/A
Overall change	8.31 kB	8.05 kB	-257 B

Client Build Manifests

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_error.js	1 MB	1 MB	-907 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	-907 B
link.js	1.06 MB	1.06 MB	-907 B
routerDirect.js	1.05 MB	1.05 MB	-907 B
withRouter.js	1.05 MB	1.05 MB	-907 B
Overall change	5.16 MB	5.16 MB	-4.54 kB

Commit: 6024bae

ijjk · 2020-12-21T18:02:11Z

Failing test suites

Commit: 6024bae

test/integration/required-server-files/test/index.test.js

Required Server Files > should output required-server-files manifest correctly

Expand output

● Required Server Files › should output required-server-files manifest correctly

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  85 |     for (const file of requiredFilesManifest.files) {
  86 |       console.log('checking', file)
> 87 |       expect(await fs.exists(join(appDir, file))).toBe(true)
     |                                                   ^
  88 |     }
  89 |   })
  90 | 

  at Object.<anonymous> (integration/required-server-files/test/index.test.js:87:51)

ijjk · 2020-12-21T19:12:44Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
buildDuration	11.4s	11.2s	-253ms
nodeModulesSize	82.6 MB	82.6 MB	⚠️ +6.22 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.762	2.328	-0.43
/ avg req/sec	905	1073.93	+168.93
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.603	1.637	⚠️ +0.03
/error-in-render avg req/sec	1559.34	1526.74	⚠️ -32.6

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1f21dcf..0011.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall decrease ✓

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	3.44 kB	-257 B
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
Overall change	8.31 kB	8.05 kB	-257 B

Client Build Manifests

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
index.html gzip	612 B	612 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Diffs

Diff for _buildManifest.js

@@ -2,7 +2,7 @@ self.__BUILD_MANIFEST = {
   __rewrites: [],
   "/": ["static\u002Fchunks\u002Fpages\u002Findex-283eed3c1520dcc26e8d.js"],
   "/_error": [
-    "static\u002Fchunks\u002Fpages\u002F_error-fbaccf4d6b3c31a2915e.js"
+    "static\u002Fchunks\u002Fpages\u002F_error-671dbf297c19f6f715f8.js"
   ],
   "/hooks": [
     "static\u002Fchunks\u002Fpages\u002Fhooks-bdd2cad07648acf22380.js"

Diff for _error-fbacc..c31a2915e.js

@@ -535,23 +535,8 @@ Also adds support for deduplicated `key` properties
           .map(function(c, i) {
             var key = c.key || i;
 
-            if (true && !props.inAmpMode) {
-              if (
-                c.type === "link" &&
-                c.props["href"] && // TODO(prateekbh@): Replace this with const from `constants` when the tree shaking works.
-                ["https://fonts.googleapis.com/css"].some(function(url) {
-                  return c.props["href"].startsWith(url);
-                })
-              ) {
-                var newProps = _objectSpread({}, c.props || {});
-
-                newProps["data-href"] = newProps["href"];
-                newProps["href"] = undefined;
-                return /*#__PURE__*/ _react["default"].cloneElement(
-                  c,
-                  newProps
-                );
-              }
+            if (false) {
+              var newProps;
             }
 
             return /*#__PURE__*/ _react["default"].cloneElement(c, {

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
buildDuration	13.2s	13.3s	⚠️ +181ms
nodeModulesSize	82.6 MB	82.6 MB	⚠️ +6.22 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
677f882d2ed8..5e70.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-1f21dcf..0011.js gzip	6.56 kB	6.56 kB	✓
webpack-95c2..e870.js gzip	751 B	751 B	✓
Overall change	59 kB	59 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
polyfills-d3..23f6.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages Overall decrease ✓

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_app-0d19cb6..5497.js gzip	1.28 kB	1.28 kB	✓
_error-2cf0e..a0a0.js gzip	3.69 kB	N/A	N/A
hooks-42456f..0c06.js gzip	887 B	887 B	✓
index-8081ce..e44f.js gzip	227 B	227 B	✓
link-0ab9f83..fa00.js gzip	1.61 kB	1.61 kB	✓
routerDirect..c3d8.js gzip	303 B	303 B	✓
withRouter-0..a68e.js gzip	302 B	302 B	✓
_error-85785..a9f3.js gzip	N/A	3.44 kB	N/A
Overall change	8.31 kB	8.05 kB	-257 B

Client Build Manifests

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	Timer/next.js temp/reflag-font-optimization	Change
_error.js	1 MB	1 MB	-907 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	-907 B
link.js	1.06 MB	1.06 MB	-907 B
routerDirect.js	1.05 MB	1.05 MB	-907 B
withRouter.js	1.05 MB	1.05 MB	-907 B
Overall change	5.16 MB	5.16 MB	-4.54 kB

Commit: 7c84e5c

temporary: re-flag font optimization

36489da

ijjk added the type: next label Dec 21, 2020

vercel bot temporarily deployed to Preview December 21, 2020 16:59 Inactive

tests: correctly exit server after execution

dcbed4c

enable feature via env

6024bae

vercel bot temporarily deployed to Preview December 21, 2020 17:47 Inactive

Filter file

7c84e5c

vercel bot temporarily deployed to Preview December 21, 2020 19:02 Inactive

Timer marked this pull request as ready for review December 21, 2020 19:21

Timer requested review from ijjk, lfades and timneutkens as code owners December 21, 2020 19:21

ijjk approved these changes Dec 21, 2020

View reviewed changes

kodiakhq bot merged commit 260ab51 into vercel:canary Dec 21, 2020

Timer deleted the temp/reflag-font-optimization branch December 21, 2020 19:33

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

temporary: re-flag font optimization #20372

temporary: re-flag font optimization #20372

Timer commented Dec 21, 2020

ijjk commented Dec 21, 2020

Diffs

ijjk commented Dec 21, 2020

ijjk commented Dec 21, 2020

Diffs

ijjk commented Dec 21, 2020

ijjk commented Dec 21, 2020

Diffs

temporary: re-flag font optimization #20372

temporary: re-flag font optimization #20372

Conversation

Timer commented Dec 21, 2020

ijjk commented Dec 21, 2020

Stats from current PR

Diffs

ijjk commented Dec 21, 2020

Failing test suites

ijjk commented Dec 21, 2020

Stats from current PR

Diffs

ijjk commented Dec 21, 2020

Failing test suites

ijjk commented Dec 21, 2020

Stats from current PR

Diffs