Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in error markdown #20825

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Fix typo in error markdown #20825

merged 1 commit into from
Jan 7, 2021

Conversation

jeremybalog
Copy link
Contributor

No description provided.

lfades
lfades previously approved these changes Jan 6, 2021
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ijjk
Copy link
Member

ijjk commented Jan 6, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary jeremybalog/next.js patch-1 Change
buildDuration 9s 8.9s -114ms
nodeModulesSize 80.8 MB 80.8 MB
Page Load Tests Overall increase ✓
vercel/next.js canary jeremybalog/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 1.769 1.755 -0.01
/ avg req/sec 1412.98 1424.56 +11.58
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.137 1.109 -0.03
/error-in-render avg req/sec 2199.57 2253.47 +53.9
Client Bundles (main, webpack, commons)
vercel/next.js canary jeremybalog/next.js patch-1 Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-8b99f8a..8ccf.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jeremybalog/next.js patch-1 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary jeremybalog/next.js patch-1 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary jeremybalog/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary jeremybalog/next.js patch-1 Change
index.html gzip 613 B 613 B
link.html gzip 618 B 618 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary jeremybalog/next.js patch-1 Change
buildDuration 10.7s 9.9s -736ms
nodeModulesSize 80.8 MB 80.8 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary jeremybalog/next.js patch-1 Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-8b99f8a..8ccf.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jeremybalog/next.js patch-1 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary jeremybalog/next.js patch-1 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary jeremybalog/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary jeremybalog/next.js patch-1 Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 97c23c6

@timneutkens timneutkens changed the base branch from master to canary January 7, 2021 09:22
@timneutkens timneutkens dismissed lfades’s stale review January 7, 2021 09:22

The base branch was changed.

@timneutkens timneutkens merged commit bb05e42 into vercel:canary Jan 7, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants