Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding small note to ENV documentation #20860

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Adding small note to ENV documentation #20860

merged 2 commits into from
Jan 7, 2021

Conversation

destumme
Copy link
Contributor

@destumme destumme commented Jan 7, 2021

This single sentence addition would have saved me about a day of troubleshooting. This doc doesn't mention how the inline occurs. The only place I could eventually find that mentions this is the server & public runtime config pages.

@destumme
Adding small note to ENV documentation
4a7f7bd 
This single sentence addition would have saved me about a day of troubleshooting. This doc doesn't mention how the inline occurs. The only place I could see that mentions this is the server & public runtime config pages.
@ijjk
Copy link
Member

ijjk commented Jan 7, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary destumme/next.js patch-1 Change
buildDuration 10.6s 10.8s ⚠️ +216ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary destumme/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.042 2.19 ⚠️ +0.15
/ avg req/sec 1224.3 1141.73 ⚠️ -82.57
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.26 1.373 ⚠️ +0.11
/error-in-render avg req/sec 1984.36 1821.13 ⚠️ -163.23
Client Bundles (main, webpack, commons)
vercel/next.js canary destumme/next.js patch-1 Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary destumme/next.js patch-1 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary destumme/next.js patch-1 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary destumme/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary destumme/next.js patch-1 Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary destumme/next.js patch-1 Change
buildDuration 12.8s 12.4s -325ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary destumme/next.js patch-1 Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary destumme/next.js patch-1 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary destumme/next.js patch-1 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary destumme/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary destumme/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 4a7f7bd

@ijjk
Copy link
Member

ijjk commented Jan 7, 2021

Failing test suites

Commit: 4a7f7bd

test/integration/gssp-ssr-change-reloading/test/index.test.js

  • GS(S)P Server-Side Change Reloading > should not reload page when client-side is changed too GSP
Expand output

● GS(S)P Server-Side Change Reloading › should not reload page when client-side is changed too GSP

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":"#props"}
  (Session info: headless chrome=87.0.4280.88)

  35 |     await browser.eval(() => (window.beforeChange = 'hi'))
  36 | 
> 37 |     const props = JSON.parse(await browser.elementByCss('#props').text())
     |                              ^
  38 | 
  39 |     const page = new File(join(appDir, 'pages/gsp-blog/[post].js'))
  40 |     page.replace('change me', 'changed')

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:565:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:491:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:700:17)
  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:37:30)

@ijjk
Copy link
Member

ijjk commented Jan 7, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary destumme/next.js patch-1 Change
buildDuration 8.7s 8.9s ⚠️ +180ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary destumme/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.761 1.735 -0.03
/ avg req/sec 1419.27 1440.69 +21.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.084 1.107 ⚠️ +0.02
/error-in-render avg req/sec 2307.21 2259.14 ⚠️ -48.07
Client Bundles (main, webpack, commons)
vercel/next.js canary destumme/next.js patch-1 Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary destumme/next.js patch-1 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary destumme/next.js patch-1 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary destumme/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary destumme/next.js patch-1 Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary destumme/next.js patch-1 Change
buildDuration 10.8s 10.1s -639ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary destumme/next.js patch-1 Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary destumme/next.js patch-1 Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary destumme/next.js patch-1 Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary destumme/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary destumme/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 5db446a

@kodiakhq kodiakhq bot merged commit d49c474 into vercel:canary Jan 7, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@destumme @ijjk @Timer