Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix with-three-js example #20897

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Fix with-three-js example #20897

merged 2 commits into from
Jan 11, 2021

Conversation

bhbs
Copy link
Contributor

@bhbs bhbs commented Jan 8, 2021 •
edited

Fixes: #20722

  • upgrade npm packages
  • remove StandardEffects
  • remove postprocessing

@ijjk ijjk added the examples Issue/PR related to examples label Jan 8, 2021
@ijjk
Copy link
Member

ijjk commented Jan 8, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary bhbs/next.js fix/with-three-js Change
buildDuration 9.9s 9.8s -20ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary bhbs/next.js fix/with-three-js Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.918 1.921 0
/ avg req/sec 1303.26 1301.44 ⚠️ -1.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.226 1.236 ⚠️ +0.01
/error-in-render avg req/sec 2039.79 2022.92 ⚠️ -16.87
Client Bundles (main, webpack, commons)
vercel/next.js canary bhbs/next.js fix/with-three-js Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary bhbs/next.js fix/with-three-js Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary bhbs/next.js fix/with-three-js Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary bhbs/next.js fix/with-three-js Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary bhbs/next.js fix/with-three-js Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary bhbs/next.js fix/with-three-js Change
buildDuration 11.7s 11.6s -98ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary bhbs/next.js fix/with-three-js Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary bhbs/next.js fix/with-three-js Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary bhbs/next.js fix/with-three-js Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary bhbs/next.js fix/with-three-js Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary bhbs/next.js fix/with-three-js Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 718ecad

@ijjk
Copy link
Member

ijjk commented Jan 8, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary bhbs/next.js fix/with-three-js Change
buildDuration 10.3s 10.5s ⚠️ +198ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary bhbs/next.js fix/with-three-js Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.05 2.058 ⚠️ +0.01
/ avg req/sec 1219.79 1214.74 ⚠️ -5.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.27 1.359 ⚠️ +0.09
/error-in-render avg req/sec 1968.58 1839.64 ⚠️ -128.94
Client Bundles (main, webpack, commons)
vercel/next.js canary bhbs/next.js fix/with-three-js Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary bhbs/next.js fix/with-three-js Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary bhbs/next.js fix/with-three-js Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary bhbs/next.js fix/with-three-js Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary bhbs/next.js fix/with-three-js Change
index.html gzip 614 B 614 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary bhbs/next.js fix/with-three-js Change
buildDuration 12.7s 12.5s -211ms
nodeModulesSize 80.8 MB 80.8 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary bhbs/next.js fix/with-three-js Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary bhbs/next.js fix/with-three-js Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary bhbs/next.js fix/with-three-js Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary bhbs/next.js fix/with-three-js Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary bhbs/next.js fix/with-three-js Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: a404b47

timneutkens
timneutkens approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timneutkens timneutkens merged commit d0f1e33 into vercel:canary Jan 11, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Next with three.js example not working.
3 participants
@bhbs @ijjk @timneutkens