Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in example #20934

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Fix error in example #20934

merged 2 commits into from
Jan 11, 2021

Conversation

giraffesyo
Copy link
Contributor

When you do a fresh install of the blog-starter-typescript example package, you get the following error after running yarn dev:

giraffesyo@Michaels-MacBook-Pro blog-starter-typescript-app % yarn dev
yarn run v1.22.10
$ next
ready - started server on http://localhost:3000
error - ./styles/index.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-6-1!./node_modules/next/dist/compiled/postcss-loader/cjs.js??ref--5-oneOf-6-2!./styles/index.css)
Error: PostCSS plugin postcss-nested requires PostCSS 8.
Migration guide for end-users:
https://github.com/postcss/postcss/wiki/PostCSS-8-for-end-users

Tailwindcss 2.0 has moved autoprefixer and postcss to peer dependencies instead of dependencies. Their installation guide mentions this. We need to add these as dev dependencies to resolve this error. This was already done in the non-typescript example but was missed here.

These are peer dependencies of tailwindcss
@ijjk ijjk added the examples Issue/PR related to examples label Jan 10, 2021
@ijjk
Copy link
Member

ijjk commented Jan 10, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary giraffesyo/next.js canary Change
buildDuration 9.6s 9.7s ⚠️ +158ms
nodeModulesSize 80.9 MB 80.9 MB
Page Load Tests Overall increase ✓
vercel/next.js canary giraffesyo/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 2.006 1.951 -0.05
/ avg req/sec 1246.02 1281.28 +35.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.263 1.184 -0.08
/error-in-render avg req/sec 1978.76 2111.76 +133
Client Bundles (main, webpack, commons)
vercel/next.js canary giraffesyo/next.js canary Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary giraffesyo/next.js canary Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary giraffesyo/next.js canary Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary giraffesyo/next.js canary Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Rendered Page Sizes
vercel/next.js canary giraffesyo/next.js canary Change
index.html gzip 614 B 614 B
link.html gzip 619 B 619 B
withRouter.html gzip 606 B 606 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary giraffesyo/next.js canary Change
buildDuration 11.6s 12.7s ⚠️ +1.1s
nodeModulesSize 80.9 MB 80.9 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary giraffesyo/next.js canary Change
677f882d2ed8..89aa.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-dba4ec1..27c0.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary giraffesyo/next.js canary Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary giraffesyo/next.js canary Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB
hooks-010c20..8411.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-d979103..c5ff.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary giraffesyo/next.js canary Change
_buildManifest.js gzip 323 B 323 B
Overall change 323 B 323 B
Serverless bundles
vercel/next.js canary giraffesyo/next.js canary Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: dd5ae8d

@timneutkens
Copy link
Member

Thanks!

@timneutkens timneutkens merged commit d9f1cf0 into vercel:canary Jan 11, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants