Call Error.getInitialProps for the top level error #21240

okmttdhr · 2021-01-17T05:29:23Z

ijjk · 2021-01-17T05:38:15Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	10s	10s	⚠️ +3ms
nodeModulesSize	77.5 MB	77.5 MB	⚠️ +109 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.948	1.9	-0.05
/ avg req/sec	1283.7	1316.13	+32.43
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.26	1.2	-0.06
/error-in-render avg req/sec	1983.62	2083.06	+99.44

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-712e20f..aa05.js gzip	6.63 kB	6.64 kB	⚠️ +10 B
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	⚠️ +10 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	615 B	615 B	✓
link.html gzip	620 B	621 B	⚠️ +1 B
withRouter.html gzip	608 B	609 B	⚠️ +1 B
Overall change	1.84 kB	1.84 kB	⚠️ +2 B

Diffs

Diff for main-82580de..1a0a14a04.js

@@ -867,9 +867,11 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         return pageLoader.loadPage("/_error").then(function(_ref5) {
           var ErrorComponent = _ref5.page,
             styleSheets = _ref5.styleSheets;
-          // In production we do a normal render with the `ErrorComponent` as component.
+
+          var _renderErrorProps$pro; // In production we do a normal render with the `ErrorComponent` as component.
           // If we've gotten here upon initial render, we can use the props from the server.
           // Otherwise, we need to call `getInitialProps` on `App` before mounting.
+
           var AppTree = wrapApp(App);
           var appCtx = {
             Component: ErrorComponent,
@@ -884,7 +886,8 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
             }
           };
           return Promise.resolve(
-            renderErrorProps.props
+            (_renderErrorProps$pro = renderErrorProps.props) != null &&
+              _renderErrorProps$pro.err
               ? renderErrorProps.props
               : (0, _utils.loadGetInitialProps)(App, appCtx)
           ).then(function(initProps) {

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-82580def8071a0a14a04.js"
+      href="/_next/static/chunks/main-56fc380c275d702704f7.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-7cd0807c85ae48513b2d.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-82580def8071a0a14a04.js"
+      src="/_next/static/chunks/main-56fc380c275d702704f7.js"
       async=""
     ></script>
     <script

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-82580def8071a0a14a04.js"
+      href="/_next/static/chunks/main-56fc380c275d702704f7.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-7cd0807c85ae48513b2d.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-82580def8071a0a14a04.js"
+      src="/_next/static/chunks/main-56fc380c275d702704f7.js"
       async=""
     ></script>
     <script

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-82580def8071a0a14a04.js"
+      href="/_next/static/chunks/main-56fc380c275d702704f7.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-7cd0807c85ae48513b2d.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-82580def8071a0a14a04.js"
+      src="/_next/static/chunks/main-56fc380c275d702704f7.js"
       async=""
     ></script>
     <script

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	11.2s	11.5s	⚠️ +304ms
nodeModulesSize	77.5 MB	77.5 MB	⚠️ +109 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-712e20f..aa05.js gzip	6.63 kB	N/A	N/A
webpack-50be..df5b.js gzip	751 B	751 B	✓
main-34f59e5..a744.js gzip	N/A	6.64 kB	N/A
Overall change	59.4 kB	59.4 kB	⚠️ +10 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: 2886241

ijjk · 2021-01-17T06:03:45Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	9s	8.9s	-102ms
nodeModulesSize	77.5 MB	77.5 MB	⚠️ +109 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.755	1.805	⚠️ +0.05
/ avg req/sec	1424.33	1385.31	⚠️ -39.02
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.124	1.106	-0.02
/error-in-render avg req/sec	2223.99	2260.61	+36.62

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-712e20f..aa05.js gzip	6.63 kB	6.64 kB	⚠️ +10 B
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	⚠️ +10 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	615 B	615 B	✓
link.html gzip	620 B	621 B	⚠️ +1 B
withRouter.html gzip	608 B	609 B	⚠️ +1 B
Overall change	1.84 kB	1.84 kB	⚠️ +2 B

Diffs

Diff for main-82580de..1a0a14a04.js

@@ -867,9 +867,11 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         return pageLoader.loadPage("/_error").then(function(_ref5) {
           var ErrorComponent = _ref5.page,
             styleSheets = _ref5.styleSheets;
-          // In production we do a normal render with the `ErrorComponent` as component.
+
+          var _renderErrorProps$pro; // In production we do a normal render with the `ErrorComponent` as component.
           // If we've gotten here upon initial render, we can use the props from the server.
           // Otherwise, we need to call `getInitialProps` on `App` before mounting.
+
           var AppTree = wrapApp(App);
           var appCtx = {
             Component: ErrorComponent,
@@ -884,7 +886,8 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
             }
           };
           return Promise.resolve(
-            renderErrorProps.props
+            (_renderErrorProps$pro = renderErrorProps.props) != null &&
+              _renderErrorProps$pro.err
               ? renderErrorProps.props
               : (0, _utils.loadGetInitialProps)(App, appCtx)
           ).then(function(initProps) {

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-82580def8071a0a14a04.js"
+      href="/_next/static/chunks/main-56fc380c275d702704f7.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-7cd0807c85ae48513b2d.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-82580def8071a0a14a04.js"
+      src="/_next/static/chunks/main-56fc380c275d702704f7.js"
       async=""
     ></script>
     <script

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-82580def8071a0a14a04.js"
+      href="/_next/static/chunks/main-56fc380c275d702704f7.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-7cd0807c85ae48513b2d.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-82580def8071a0a14a04.js"
+      src="/_next/static/chunks/main-56fc380c275d702704f7.js"
       async=""
     ></script>
     <script

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-82580def8071a0a14a04.js"
+      href="/_next/static/chunks/main-56fc380c275d702704f7.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-7cd0807c85ae48513b2d.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-82580def8071a0a14a04.js"
+      src="/_next/static/chunks/main-56fc380c275d702704f7.js"
       async=""
     ></script>
     <script

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	10.6s	10.5s	-99ms
nodeModulesSize	77.5 MB	77.5 MB	⚠️ +109 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-712e20f..aa05.js gzip	6.63 kB	N/A	N/A
webpack-50be..df5b.js gzip	751 B	751 B	✓
main-34f59e5..a744.js gzip	N/A	6.64 kB	N/A
Overall change	59.4 kB	59.4 kB	⚠️ +10 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: 81fa0c3

Janpot · 2021-01-28T15:37:03Z

@okmttdhr Perhaps it's better to create a new test for this as it could be interesting to have a test for both with and without getInitialProps?

ijjk · 2021-02-14T12:28:11Z

Failing test suites

Commit: ea3d8a5

test/integration/build-output/test/index.test.js

Build Output > Crypto Application > should not include crypto

Expand output

● Build Output › Crypto Application › should not include crypto

expect(received).toBeLessThanOrEqual(expected)

Expected: <= 66.6
Received:    66.7

  169 |       expect(indexSize.endsWith('kB')).toBe(true)
  170 | 
> 171 |       expect(parseFloat(indexFirstLoad)).toBeLessThanOrEqual(66.6)
      |                                          ^
  172 |       expect(parseFloat(indexFirstLoad)).toBeGreaterThanOrEqual(60)
  173 |       expect(indexFirstLoad.endsWith('kB')).toBe(true)
  174 |     })

  at Object.<anonymous> (integration/build-output/test/index.test.js:171:42)

ijjk · 2021-02-14T12:31:17Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	12.1s	12.3s	⚠️ +139ms
nodeModulesSize	69.8 MB	69.8 MB	⚠️ +109 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.282	2.301	⚠️ +0.02
/ avg req/sec	1095.75	1086.33	⚠️ -9.42
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.677	1.649	-0.03
/error-in-render avg req/sec	1491.14	1515.97	+24.83

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..5cb0.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.64 kB	⚠️ +10 B
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	⚠️ +10 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	614 B	613 B	-1 B
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	-1 B

Diffs

Diff for main-HASH.js

@@ -867,9 +867,11 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         return pageLoader.loadPage("/_error").then(function(_ref5) {
           var ErrorComponent = _ref5.page,
             styleSheets = _ref5.styleSheets;
-          // In production we do a normal render with the `ErrorComponent` as component.
+
+          var _renderErrorProps$pro; // In production we do a normal render with the `ErrorComponent` as component.
           // If we've gotten here upon initial render, we can use the props from the server.
           // Otherwise, we need to call `getInitialProps` on `App` before mounting.
+
           var AppTree = wrapApp(App);
           var appCtx = {
             Component: ErrorComponent,
@@ -884,7 +886,8 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
             }
           };
           return Promise.resolve(
-            renderErrorProps.props
+            (_renderErrorProps$pro = renderErrorProps.props) != null &&
+              _renderErrorProps$pro.err
               ? renderErrorProps.props
               : (0, _utils.loadGetInitialProps)(App, appCtx)
           ).then(function(initProps) {

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c32b83e7292620e90828.js"
+      href="/_next/static/chunks/main-cc2c01e0faac0fac136f.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c32b83e7292620e90828.js"
+      src="/_next/static/chunks/main-cc2c01e0faac0fac136f.js"
       async=""
     ></script>
     <script

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c32b83e7292620e90828.js"
+      href="/_next/static/chunks/main-cc2c01e0faac0fac136f.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c32b83e7292620e90828.js"
+      src="/_next/static/chunks/main-cc2c01e0faac0fac136f.js"
       async=""
     ></script>
     <script

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c32b83e7292620e90828.js"
+      href="/_next/static/chunks/main-cc2c01e0faac0fac136f.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c32b83e7292620e90828.js"
+      src="/_next/static/chunks/main-cc2c01e0faac0fac136f.js"
       async=""
     ></script>
     <script

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	14.2s	13.8s	-327ms
nodeModulesSize	69.8 MB	69.8 MB	⚠️ +109 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..5cb0.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.64 kB	⚠️ +10 B
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	⚠️ +10 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_error.js	1.01 MB	1.01 MB	✓
404.html	2.67 kB	2.67 kB	✓
amp.amp.html	10.4 kB	10.4 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.01 MB	1.01 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	14.3s	15.2s	⚠️ +854ms
nodeModulesSize	69.8 MB	69.8 MB	⚠️ +109 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.393	2.415	⚠️ +0.02
/ avg req/sec	1044.5	1035.31	⚠️ -9.19
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.647	1.733	⚠️ +0.09
/error-in-render avg req/sec	1518.24	1442.91	⚠️ -75.33

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
597-d08f5fe5..d690.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.59 kB	⚠️ +11 B
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.9 kB	59.9 kB	⚠️ +11 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-6e0a903..b885.js gzip	1.26 kB	1.26 kB	✓
_error-9e190..f9d6.js gzip	3.38 kB	3.38 kB	✓
amp-7fd79cc4..99ee.js gzip	538 B	538 B	✓
hooks-f7e199..11b9.js gzip	904 B	904 B	✓
index-3dc22c..ffbb.js gzip	232 B	232 B	✓
link-7cc9e62..ef27.js gzip	1.66 kB	1.66 kB	✓
routerDirect..323a.js gzip	308 B	308 B	✓
withRouter-a..2ef8.js gzip	304 B	304 B	✓
Overall change	8.59 kB	8.59 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	586 B	586 B	✓
link.html gzip	593 B	594 B	⚠️ +1 B
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	⚠️ +1 B

Diffs

Diff for main-HASH.js

@@ -540,23 +540,26 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
         return (
           console.error(r),
           U.loadPage("/_error").then(function(n) {
-            var o = n.page,
-              a = n.styleSheets,
-              i = de(t),
-              u = {
-                Component: o,
-                AppTree: i,
+            var o,
+              a = n.page,
+              i = n.styleSheets,
+              u = de(t),
+              c = {
+                Component: a,
+                AppTree: u,
                 router: z,
-                ctx: { err: r, pathname: R, query: F, asPath: J, AppTree: i }
+                ctx: { err: r, pathname: R, query: F, asPath: J, AppTree: u }
               };
             return Promise.resolve(
-              e.props ? e.props : (0, x.loadGetInitialProps)(t, u)
+              null != (o = e.props) && o.err
+                ? e.props
+                : (0, x.loadGetInitialProps)(t, c)
             ).then(function(t) {
               return me(
                 (0, m.default)({}, e, {
                   err: r,
-                  Component: o,
-                  styleSheets: a,
+                  Component: a,
+                  styleSheets: i,
                   props: t
                 })
               );

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-919a887b944fe535a634.js"
+      href="/_next/static/chunks/main-4dcb26b973301ac57749.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "aIIf6nyjsDjMvKNOlTcwq",
+        "buildId": "NTRE_jUvoNlTaaNRD5rPF",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-919a887b944fe535a634.js"
+      src="/_next/static/chunks/main-4dcb26b973301ac57749.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/aIIf6nyjsDjMvKNOlTcwq/_buildManifest.js"
+      src="/_next/static/NTRE_jUvoNlTaaNRD5rPF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/aIIf6nyjsDjMvKNOlTcwq/_ssgManifest.js"
+      src="/_next/static/NTRE_jUvoNlTaaNRD5rPF/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-919a887b944fe535a634.js"
+      href="/_next/static/chunks/main-4dcb26b973301ac57749.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "aIIf6nyjsDjMvKNOlTcwq",
+        "buildId": "NTRE_jUvoNlTaaNRD5rPF",
         "isFallback": false,
         "gip": true
       }
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-919a887b944fe535a634.js"
+      src="/_next/static/chunks/main-4dcb26b973301ac57749.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/aIIf6nyjsDjMvKNOlTcwq/_buildManifest.js"
+      src="/_next/static/NTRE_jUvoNlTaaNRD5rPF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/aIIf6nyjsDjMvKNOlTcwq/_ssgManifest.js"
+      src="/_next/static/NTRE_jUvoNlTaaNRD5rPF/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-919a887b944fe535a634.js"
+      href="/_next/static/chunks/main-4dcb26b973301ac57749.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "aIIf6nyjsDjMvKNOlTcwq",
+        "buildId": "NTRE_jUvoNlTaaNRD5rPF",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-919a887b944fe535a634.js"
+      src="/_next/static/chunks/main-4dcb26b973301ac57749.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/aIIf6nyjsDjMvKNOlTcwq/_buildManifest.js"
+      src="/_next/static/NTRE_jUvoNlTaaNRD5rPF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/aIIf6nyjsDjMvKNOlTcwq/_ssgManifest.js"
+      src="/_next/static/NTRE_jUvoNlTaaNRD5rPF/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: ea3d8a5

ijjk · 2021-02-14T13:27:50Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	12s	12.1s	⚠️ +54ms
nodeModulesSize	69.8 MB	69.8 MB	⚠️ +109 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.233	2.274	⚠️ +0.04
/ avg req/sec	1119.34	1099.37	⚠️ -19.97
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.62	1.652	⚠️ +0.03
/error-in-render avg req/sec	1543.45	1513.08	⚠️ -30.37

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..5cb0.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.64 kB	⚠️ +10 B
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	⚠️ +10 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	614 B	613 B	-1 B
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	-1 B

Diffs

Diff for main-HASH.js

@@ -867,9 +867,11 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         return pageLoader.loadPage("/_error").then(function(_ref5) {
           var ErrorComponent = _ref5.page,
             styleSheets = _ref5.styleSheets;
-          // In production we do a normal render with the `ErrorComponent` as component.
+
+          var _renderErrorProps$pro; // In production we do a normal render with the `ErrorComponent` as component.
           // If we've gotten here upon initial render, we can use the props from the server.
           // Otherwise, we need to call `getInitialProps` on `App` before mounting.
+
           var AppTree = wrapApp(App);
           var appCtx = {
             Component: ErrorComponent,
@@ -884,7 +886,8 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
             }
           };
           return Promise.resolve(
-            renderErrorProps.props
+            (_renderErrorProps$pro = renderErrorProps.props) != null &&
+              _renderErrorProps$pro.err
               ? renderErrorProps.props
               : (0, _utils.loadGetInitialProps)(App, appCtx)
           ).then(function(initProps) {

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c32b83e7292620e90828.js"
+      href="/_next/static/chunks/main-cc2c01e0faac0fac136f.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c32b83e7292620e90828.js"
+      src="/_next/static/chunks/main-cc2c01e0faac0fac136f.js"
       async=""
     ></script>
     <script

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c32b83e7292620e90828.js"
+      href="/_next/static/chunks/main-cc2c01e0faac0fac136f.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c32b83e7292620e90828.js"
+      src="/_next/static/chunks/main-cc2c01e0faac0fac136f.js"
       async=""
     ></script>
     <script

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c32b83e7292620e90828.js"
+      href="/_next/static/chunks/main-cc2c01e0faac0fac136f.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c32b83e7292620e90828.js"
+      src="/_next/static/chunks/main-cc2c01e0faac0fac136f.js"
       async=""
     ></script>
     <script

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	14.6s	14.6s	⚠️ +6ms
nodeModulesSize	69.8 MB	69.8 MB	⚠️ +109 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..5cb0.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.64 kB	⚠️ +10 B
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	⚠️ +10 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_error.js	1.01 MB	1.01 MB	✓
404.html	2.67 kB	2.67 kB	✓
amp.amp.html	10.4 kB	10.4 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.01 MB	1.01 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	14.5s	14.6s	⚠️ +154ms
nodeModulesSize	69.8 MB	69.8 MB	⚠️ +109 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.237	2.302	⚠️ +0.06
/ avg req/sec	1117.59	1086.06	⚠️ -31.53
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.614	1.588	-0.03
/error-in-render avg req/sec	1548.47	1574.62	+26.15

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
597-d08f5fe5..d690.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.59 kB	⚠️ +11 B
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.9 kB	59.9 kB	⚠️ +11 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-6e0a903..b885.js gzip	1.26 kB	1.26 kB	✓
_error-9e190..f9d6.js gzip	3.38 kB	3.38 kB	✓
amp-7fd79cc4..99ee.js gzip	538 B	538 B	✓
hooks-f7e199..11b9.js gzip	904 B	904 B	✓
index-3dc22c..ffbb.js gzip	232 B	232 B	✓
link-7cc9e62..ef27.js gzip	1.66 kB	1.66 kB	✓
routerDirect..323a.js gzip	308 B	308 B	✓
withRouter-a..2ef8.js gzip	304 B	304 B	✓
Overall change	8.59 kB	8.59 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	322 B	322 B	✓
Overall change	322 B	322 B	✓

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	586 B	586 B	✓
link.html gzip	593 B	594 B	⚠️ +1 B
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	⚠️ +1 B

Diffs

Diff for main-HASH.js

@@ -540,23 +540,26 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
         return (
           console.error(r),
           U.loadPage("/_error").then(function(n) {
-            var o = n.page,
-              a = n.styleSheets,
-              i = de(t),
-              u = {
-                Component: o,
-                AppTree: i,
+            var o,
+              a = n.page,
+              i = n.styleSheets,
+              u = de(t),
+              c = {
+                Component: a,
+                AppTree: u,
                 router: z,
-                ctx: { err: r, pathname: R, query: F, asPath: J, AppTree: i }
+                ctx: { err: r, pathname: R, query: F, asPath: J, AppTree: u }
               };
             return Promise.resolve(
-              e.props ? e.props : (0, x.loadGetInitialProps)(t, u)
+              null != (o = e.props) && o.err
+                ? e.props
+                : (0, x.loadGetInitialProps)(t, c)
             ).then(function(t) {
               return me(
                 (0, m.default)({}, e, {
                   err: r,
-                  Component: o,
-                  styleSheets: a,
+                  Component: a,
+                  styleSheets: i,
                   props: t
                 })
               );

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-919a887b944fe535a634.js"
+      href="/_next/static/chunks/main-4dcb26b973301ac57749.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "XjaKLgpo6eV4MKNRya7mz",
+        "buildId": "019D6ZacjmrjkkcFvtUWy",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-919a887b944fe535a634.js"
+      src="/_next/static/chunks/main-4dcb26b973301ac57749.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/XjaKLgpo6eV4MKNRya7mz/_buildManifest.js"
+      src="/_next/static/019D6ZacjmrjkkcFvtUWy/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/XjaKLgpo6eV4MKNRya7mz/_ssgManifest.js"
+      src="/_next/static/019D6ZacjmrjkkcFvtUWy/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-919a887b944fe535a634.js"
+      href="/_next/static/chunks/main-4dcb26b973301ac57749.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "XjaKLgpo6eV4MKNRya7mz",
+        "buildId": "019D6ZacjmrjkkcFvtUWy",
         "isFallback": false,
         "gip": true
       }
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-919a887b944fe535a634.js"
+      src="/_next/static/chunks/main-4dcb26b973301ac57749.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/XjaKLgpo6eV4MKNRya7mz/_buildManifest.js"
+      src="/_next/static/019D6ZacjmrjkkcFvtUWy/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/XjaKLgpo6eV4MKNRya7mz/_ssgManifest.js"
+      src="/_next/static/019D6ZacjmrjkkcFvtUWy/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-919a887b944fe535a634.js"
+      href="/_next/static/chunks/main-4dcb26b973301ac57749.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "XjaKLgpo6eV4MKNRya7mz",
+        "buildId": "019D6ZacjmrjkkcFvtUWy",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-919a887b944fe535a634.js"
+      src="/_next/static/chunks/main-4dcb26b973301ac57749.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/XjaKLgpo6eV4MKNRya7mz/_buildManifest.js"
+      src="/_next/static/019D6ZacjmrjkkcFvtUWy/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/XjaKLgpo6eV4MKNRya7mz/_ssgManifest.js"
+      src="/_next/static/019D6ZacjmrjkkcFvtUWy/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 0777eb2

This reverts commit 81fa0c3.

…rops-not-called

ijjk · 2021-02-20T14:13:07Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	9.5s	9.5s	-49ms
nodeModulesSize	42.6 MB	42.6 MB	⚠️ +109 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.732	1.74	⚠️ +0.01
/ avg req/sec	1443.23	1436.66	⚠️ -6.57
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.075	1.122	⚠️ +0.05
/error-in-render avg req/sec	2325.61	2227.9	⚠️ -97.71

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..854c.js gzip	13.2 kB	13.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.66 kB	⚠️ +12 B
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.6 kB	59.6 kB	⚠️ +12 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	615 B	613 B	-2 B
link.html gzip	621 B	619 B	-2 B
withRouter.html gzip	608 B	607 B	-1 B
Overall change	1.84 kB	1.84 kB	-5 B

Diffs

Diff for main-HASH.js

@@ -869,9 +869,11 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         return pageLoader.loadPage("/_error").then(function(_ref5) {
           var ErrorComponent = _ref5.page,
             styleSheets = _ref5.styleSheets;
-          // In production we do a normal render with the `ErrorComponent` as component.
+
+          var _renderErrorProps$pro; // In production we do a normal render with the `ErrorComponent` as component.
           // If we've gotten here upon initial render, we can use the props from the server.
           // Otherwise, we need to call `getInitialProps` on `App` before mounting.
+
           var AppTree = wrapApp(App);
           var appCtx = {
             Component: ErrorComponent,
@@ -886,7 +888,8 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
             }
           };
           return Promise.resolve(
-            renderErrorProps.props
+            (_renderErrorProps$pro = renderErrorProps.props) != null &&
+              _renderErrorProps$pro.err
               ? renderErrorProps.props
               : (0, _utils.loadGetInitialProps)(App, appCtx)
           ).then(function(initProps) {

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-bd7fc65eb8900cc46ee9.js"
+      href="/_next/static/chunks/main-2f04a9ebbb44f0e17e8a.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-bd7fc65eb8900cc46ee9.js"
+      src="/_next/static/chunks/main-2f04a9ebbb44f0e17e8a.js"
       async=""
     ></script>
     <script

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-bd7fc65eb8900cc46ee9.js"
+      href="/_next/static/chunks/main-2f04a9ebbb44f0e17e8a.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-bd7fc65eb8900cc46ee9.js"
+      src="/_next/static/chunks/main-2f04a9ebbb44f0e17e8a.js"
       async=""
     ></script>
     <script

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-bd7fc65eb8900cc46ee9.js"
+      href="/_next/static/chunks/main-2f04a9ebbb44f0e17e8a.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-bd7fc65eb8900cc46ee9.js"
+      src="/_next/static/chunks/main-2f04a9ebbb44f0e17e8a.js"
       async=""
     ></script>
     <script

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	11.4s	11.1s	-253ms
nodeModulesSize	42.6 MB	42.6 MB	⚠️ +109 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..854c.js gzip	13.2 kB	13.2 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.66 kB	⚠️ +12 B
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.6 kB	59.6 kB	⚠️ +12 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_error.js	1.01 MB	1.01 MB	✓
404.html	2.67 kB	2.67 kB	✓
amp.amp.html	10.4 kB	10.4 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.01 MB	1.01 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.2 MB	5.2 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	11s	11.1s	⚠️ +59ms
nodeModulesSize	42.6 MB	42.6 MB	⚠️ +109 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.698	1.694	0
/ avg req/sec	1472.72	1475.42	+2.7
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.043	1.057	⚠️ +0.01
/error-in-render avg req/sec	2397.57	2364.78	⚠️ -32.79

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
597-dc8125e2..ef24.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.59 kB	6.61 kB	⚠️ +12 B
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	60 kB	60 kB	⚠️ +12 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-aedc815..1421.js gzip	1.26 kB	1.26 kB	✓
_error-71ec2..1a96.js gzip	3.38 kB	3.38 kB	✓
amp-33a09cb0..6745.js gzip	536 B	536 B	✓
hooks-4e968a..f870.js gzip	902 B	902 B	✓
index-5c6845..f75c.js gzip	230 B	230 B	✓
link-99f0c6c..b84a.js gzip	1.65 kB	1.65 kB	✓
routerDirect..bb56.js gzip	306 B	306 B	✓
withRouter-7..2133.js gzip	302 B	302 B	✓
Overall change	8.57 kB	8.57 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	326 B	326 B	✓
Overall change	326 B	326 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	586 B	586 B	✓
link.html gzip	593 B	592 B	-1 B
withRouter.html gzip	582 B	580 B	-2 B
Overall change	1.76 kB	1.76 kB	-3 B

Diffs

Diff for main-HASH.js

@@ -542,23 +542,26 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
         return (
           console.error(r),
           Y.loadPage("/_error").then(function(n) {
-            var o = n.page,
-              a = n.styleSheets,
-              i = me(t),
-              u = {
-                Component: o,
-                AppTree: i,
+            var o,
+              a = n.page,
+              i = n.styleSheets,
+              u = me(t),
+              c = {
+                Component: a,
+                AppTree: u,
                 router: Q,
-                ctx: { err: r, pathname: R, query: F, asPath: U, AppTree: i }
+                ctx: { err: r, pathname: R, query: F, asPath: U, AppTree: u }
               };
             return Promise.resolve(
-              e.props ? e.props : (0, x.loadGetInitialProps)(t, u)
+              null != (o = e.props) && o.err
+                ? e.props
+                : (0, x.loadGetInitialProps)(t, c)
             ).then(function(t) {
               return he(
                 (0, m.default)({}, e, {
                   err: r,
-                  Component: o,
-                  styleSheets: a,
+                  Component: a,
+                  styleSheets: i,
                   props: t
                 })
               );

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-ae4383e4693667bc0687.js"
+      href="/_next/static/chunks/main-0fa02565a0262f889afb.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "efnwzXIB_HZV_h9uQlfd7",
+        "buildId": "2EQbHKnCg4NcjZ3myxrE_",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-ae4383e4693667bc0687.js"
+      src="/_next/static/chunks/main-0fa02565a0262f889afb.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/efnwzXIB_HZV_h9uQlfd7/_buildManifest.js"
+      src="/_next/static/2EQbHKnCg4NcjZ3myxrE_/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/efnwzXIB_HZV_h9uQlfd7/_ssgManifest.js"
+      src="/_next/static/2EQbHKnCg4NcjZ3myxrE_/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-ae4383e4693667bc0687.js"
+      href="/_next/static/chunks/main-0fa02565a0262f889afb.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "efnwzXIB_HZV_h9uQlfd7",
+        "buildId": "2EQbHKnCg4NcjZ3myxrE_",
         "isFallback": false,
         "gip": true
       }
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-ae4383e4693667bc0687.js"
+      src="/_next/static/chunks/main-0fa02565a0262f889afb.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/efnwzXIB_HZV_h9uQlfd7/_buildManifest.js"
+      src="/_next/static/2EQbHKnCg4NcjZ3myxrE_/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/efnwzXIB_HZV_h9uQlfd7/_ssgManifest.js"
+      src="/_next/static/2EQbHKnCg4NcjZ3myxrE_/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-ae4383e4693667bc0687.js"
+      href="/_next/static/chunks/main-0fa02565a0262f889afb.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "efnwzXIB_HZV_h9uQlfd7",
+        "buildId": "2EQbHKnCg4NcjZ3myxrE_",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-ae4383e4693667bc0687.js"
+      src="/_next/static/chunks/main-0fa02565a0262f889afb.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/efnwzXIB_HZV_h9uQlfd7/_buildManifest.js"
+      src="/_next/static/2EQbHKnCg4NcjZ3myxrE_/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/efnwzXIB_HZV_h9uQlfd7/_ssgManifest.js"
+      src="/_next/static/2EQbHKnCg4NcjZ3myxrE_/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: e48826c

ijjk · 2021-02-20T14:19:05Z

Failing test suites

Commit: e48826c

test/integration/render-error-on-top-level-error/with-get-initial-props/test/index.test.js

Top Level Error > should render error page with getInitialProps

Expand output

● Top Level Error › should render error page with getInitialProps

command failed with code 1

  138 |         code !== 0
  139 |       ) {
> 140 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  141 |       }
  142 | 
  143 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:140:23)

● Test suite failed to run

TypeError: Cannot read property '__app' of undefined

  316 | 
  317 | export async function stopApp(server) {
> 318 |   if (server.__app) {
      |              ^
  319 |     await server.__app.close()
  320 |   }
  321 |   await promiseCall(server, 'close')

  at stopApp (lib/next-test-utils.js:318:14)
  at integration/render-error-on-top-level-error/with-get-initial-props/test/index.test.js:26:18

ijjk · 2021-02-27T11:59:19Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	12.9s	13s	⚠️ +134ms
nodeModulesSize	42.7 MB	42.7 MB	⚠️ +109 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.229	2.165	-0.06
/ avg req/sec	1121.51	1154.76	+33.25
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.548	1.397	-0.15
/error-in-render avg req/sec	1614.71	1789.22	+174.51

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..e7a0.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.66 kB	⚠️ +11 B
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.7 kB	59.7 kB	⚠️ +11 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	613 B	612 B	-1 B
link.html gzip	620 B	619 B	-1 B
withRouter.html gzip	608 B	607 B	-1 B
Overall change	1.84 kB	1.84 kB	-3 B

Diffs

Diff for main-HASH.js

@@ -869,9 +869,11 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         return pageLoader.loadPage("/_error").then(function(_ref5) {
           var ErrorComponent = _ref5.page,
             styleSheets = _ref5.styleSheets;
-          // In production we do a normal render with the `ErrorComponent` as component.
+
+          var _renderErrorProps$pro; // In production we do a normal render with the `ErrorComponent` as component.
           // If we've gotten here upon initial render, we can use the props from the server.
           // Otherwise, we need to call `getInitialProps` on `App` before mounting.
+
           var AppTree = wrapApp(App);
           var appCtx = {
             Component: ErrorComponent,
@@ -886,7 +888,8 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
             }
           };
           return Promise.resolve(
-            renderErrorProps.props
+            (_renderErrorProps$pro = renderErrorProps.props) != null &&
+              _renderErrorProps$pro.err
               ? renderErrorProps.props
               : (0, _utils.loadGetInitialProps)(App, appCtx)
           ).then(function(initProps) {

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c1a0dcfc5ed545772d83.js"
+      href="/_next/static/chunks/main-d3f6a354cd3de114c451.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c1a0dcfc5ed545772d83.js"
+      src="/_next/static/chunks/main-d3f6a354cd3de114c451.js"
       async=""
     ></script>
     <script

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c1a0dcfc5ed545772d83.js"
+      href="/_next/static/chunks/main-d3f6a354cd3de114c451.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c1a0dcfc5ed545772d83.js"
+      src="/_next/static/chunks/main-d3f6a354cd3de114c451.js"
       async=""
     ></script>
     <script

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c1a0dcfc5ed545772d83.js"
+      href="/_next/static/chunks/main-d3f6a354cd3de114c451.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c1a0dcfc5ed545772d83.js"
+      src="/_next/static/chunks/main-d3f6a354cd3de114c451.js"
       async=""
     ></script>
     <script

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	15.1s	15s	-54ms
nodeModulesSize	42.7 MB	42.7 MB	⚠️ +109 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..e7a0.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.66 kB	⚠️ +11 B
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.7 kB	59.7 kB	⚠️ +11 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_error.js	1.01 MB	1.01 MB	✓
404.html	2.67 kB	2.67 kB	✓
500.html	2.65 kB	2.65 kB	✓
amp.amp.html	10.4 kB	10.4 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.01 MB	1.01 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.21 MB	5.21 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	15.1s	14.8s	-277ms
nodeModulesSize	42.7 MB	42.7 MB	⚠️ +109 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.202	2.273	⚠️ +0.07
/ avg req/sec	1135.5	1099.74	⚠️ -35.76
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.55	1.524	-0.03
/error-in-render avg req/sec	1612.72	1640.36	+27.64

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
597-74632e79..1d47.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.59 kB	6.61 kB	⚠️ +12 B
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	60.1 kB	60.2 kB	⚠️ +12 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-aedc815..1421.js gzip	1.26 kB	1.26 kB	✓
_error-71ec2..1a96.js gzip	3.38 kB	3.38 kB	✓
amp-33a09cb0..6745.js gzip	536 B	536 B	✓
hooks-4e968a..f870.js gzip	902 B	902 B	✓
index-5c6845..f75c.js gzip	230 B	230 B	✓
link-99f0c6c..b84a.js gzip	1.65 kB	1.65 kB	✓
routerDirect..bb56.js gzip	306 B	306 B	✓
withRouter-7..2133.js gzip	302 B	302 B	✓
Overall change	8.57 kB	8.57 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	326 B	326 B	✓
Overall change	326 B	326 B	✓

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	586 B	587 B	⚠️ +1 B
link.html gzip	593 B	594 B	⚠️ +1 B
withRouter.html gzip	581 B	583 B	⚠️ +2 B
Overall change	1.76 kB	1.76 kB	⚠️ +4 B

Diffs

Diff for main-HASH.js

@@ -542,23 +542,26 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
         return (
           console.error(r),
           Y.loadPage("/_error").then(function(n) {
-            var o = n.page,
-              a = n.styleSheets,
-              i = me(t),
-              u = {
-                Component: o,
-                AppTree: i,
+            var o,
+              a = n.page,
+              i = n.styleSheets,
+              u = me(t),
+              c = {
+                Component: a,
+                AppTree: u,
                 router: Q,
-                ctx: { err: r, pathname: R, query: F, asPath: U, AppTree: i }
+                ctx: { err: r, pathname: R, query: F, asPath: U, AppTree: u }
               };
             return Promise.resolve(
-              e.props ? e.props : (0, x.loadGetInitialProps)(t, u)
+              null != (o = e.props) && o.err
+                ? e.props
+                : (0, x.loadGetInitialProps)(t, c)
             ).then(function(t) {
               return he(
                 (0, m.default)({}, e, {
                   err: r,
-                  Component: o,
-                  styleSheets: a,
+                  Component: a,
+                  styleSheets: i,
                   props: t
                 })
               );

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-64db1875672aa3f9880d.js"
+      href="/_next/static/chunks/main-cebbd08d299ec4ea2b34.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "XVZxd_tR0mLQN8g39WhSC",
+        "buildId": "jDYnXMgDY8634QQmGHd34",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-64db1875672aa3f9880d.js"
+      src="/_next/static/chunks/main-cebbd08d299ec4ea2b34.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/XVZxd_tR0mLQN8g39WhSC/_buildManifest.js"
+      src="/_next/static/jDYnXMgDY8634QQmGHd34/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/XVZxd_tR0mLQN8g39WhSC/_ssgManifest.js"
+      src="/_next/static/jDYnXMgDY8634QQmGHd34/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-64db1875672aa3f9880d.js"
+      href="/_next/static/chunks/main-cebbd08d299ec4ea2b34.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "XVZxd_tR0mLQN8g39WhSC",
+        "buildId": "jDYnXMgDY8634QQmGHd34",
         "isFallback": false,
         "gip": true
       }
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-64db1875672aa3f9880d.js"
+      src="/_next/static/chunks/main-cebbd08d299ec4ea2b34.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/XVZxd_tR0mLQN8g39WhSC/_buildManifest.js"
+      src="/_next/static/jDYnXMgDY8634QQmGHd34/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/XVZxd_tR0mLQN8g39WhSC/_ssgManifest.js"
+      src="/_next/static/jDYnXMgDY8634QQmGHd34/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-64db1875672aa3f9880d.js"
+      href="/_next/static/chunks/main-cebbd08d299ec4ea2b34.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "XVZxd_tR0mLQN8g39WhSC",
+        "buildId": "jDYnXMgDY8634QQmGHd34",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-64db1875672aa3f9880d.js"
+      src="/_next/static/chunks/main-cebbd08d299ec4ea2b34.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/XVZxd_tR0mLQN8g39WhSC/_buildManifest.js"
+      src="/_next/static/jDYnXMgDY8634QQmGHd34/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/XVZxd_tR0mLQN8g39WhSC/_ssgManifest.js"
+      src="/_next/static/jDYnXMgDY8634QQmGHd34/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: d9ce0bc

ijjk · 2021-02-27T12:04:31Z

Failing test suites

Commit: d9ce0bc

test/integration/render-error-on-top-level-error/with-get-initial-props/test/index.test.js

Top Level Error > should render error page with getInitialProps

Expand output

● Top Level Error › should render error page with getInitialProps

command failed with code 1

  139 |         code !== 0
  140 |       ) {
> 141 |         return reject(new Error(`command failed with code ${code}`))
      |                       ^
  142 |       }
  143 | 
  144 |       resolve({

  at ChildProcess.<anonymous> (lib/next-test-utils.js:141:23)

● Test suite failed to run

TypeError: Cannot read property '__app' of undefined

  317 | 
  318 | export async function stopApp(server) {
> 319 |   if (server.__app) {
      |              ^
  320 |     await server.__app.close()
  321 |   }
  322 |   await promiseCall(server, 'close')

  at stopApp (lib/next-test-utils.js:319:14)
  at integration/render-error-on-top-level-error/with-get-initial-props/test/index.test.js:26:18

ijjk · 2021-02-27T13:49:58Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	13s	13.3s	⚠️ +251ms
nodeModulesSize	42.7 MB	42.7 MB	⚠️ +109 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.378	2.394	⚠️ +0.02
/ avg req/sec	1051.51	1044.14	⚠️ -7.37
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.607	1.664	⚠️ +0.06
/error-in-render avg req/sec	1555.21	1502.2	⚠️ -53.01

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..e7a0.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.66 kB	⚠️ +11 B
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.7 kB	59.7 kB	⚠️ +11 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	613 B	612 B	-1 B
link.html gzip	620 B	619 B	-1 B
withRouter.html gzip	608 B	607 B	-1 B
Overall change	1.84 kB	1.84 kB	-3 B

Diffs

Diff for main-HASH.js

@@ -869,9 +869,11 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         return pageLoader.loadPage("/_error").then(function(_ref5) {
           var ErrorComponent = _ref5.page,
             styleSheets = _ref5.styleSheets;
-          // In production we do a normal render with the `ErrorComponent` as component.
+
+          var _renderErrorProps$pro; // In production we do a normal render with the `ErrorComponent` as component.
           // If we've gotten here upon initial render, we can use the props from the server.
           // Otherwise, we need to call `getInitialProps` on `App` before mounting.
+
           var AppTree = wrapApp(App);
           var appCtx = {
             Component: ErrorComponent,
@@ -886,7 +888,8 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
             }
           };
           return Promise.resolve(
-            renderErrorProps.props
+            (_renderErrorProps$pro = renderErrorProps.props) != null &&
+              _renderErrorProps$pro.err
               ? renderErrorProps.props
               : (0, _utils.loadGetInitialProps)(App, appCtx)
           ).then(function(initProps) {

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c1a0dcfc5ed545772d83.js"
+      href="/_next/static/chunks/main-d3f6a354cd3de114c451.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c1a0dcfc5ed545772d83.js"
+      src="/_next/static/chunks/main-d3f6a354cd3de114c451.js"
       async=""
     ></script>
     <script

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c1a0dcfc5ed545772d83.js"
+      href="/_next/static/chunks/main-d3f6a354cd3de114c451.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c1a0dcfc5ed545772d83.js"
+      src="/_next/static/chunks/main-d3f6a354cd3de114c451.js"
       async=""
     ></script>
     <script

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c1a0dcfc5ed545772d83.js"
+      href="/_next/static/chunks/main-d3f6a354cd3de114c451.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c1a0dcfc5ed545772d83.js"
+      src="/_next/static/chunks/main-d3f6a354cd3de114c451.js"
       async=""
     ></script>
     <script

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	15.6s	15.1s	-496ms
nodeModulesSize	42.7 MB	42.7 MB	⚠️ +109 B

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..e7a0.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.66 kB	⚠️ +11 B
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.7 kB	59.7 kB	⚠️ +11 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_error.js	1.01 MB	1.01 MB	✓
404.html	2.67 kB	2.67 kB	✓
500.html	2.65 kB	2.65 kB	✓
amp.amp.html	10.4 kB	10.4 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.01 MB	1.01 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.21 MB	5.21 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	15.2s	15.3s	⚠️ +104ms
nodeModulesSize	42.7 MB	42.7 MB	⚠️ +109 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.429	2.301	-0.13
/ avg req/sec	1029.33	1086.53	+57.2
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.705	1.633	-0.07
/error-in-render avg req/sec	1466.26	1531.06	+64.8

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
597-74632e79..1d47.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.59 kB	6.61 kB	⚠️ +12 B
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	60.1 kB	60.2 kB	⚠️ +12 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-aedc815..1421.js gzip	1.26 kB	1.26 kB	✓
_error-71ec2..1a96.js gzip	3.38 kB	3.38 kB	✓
amp-33a09cb0..6745.js gzip	536 B	536 B	✓
hooks-4e968a..f870.js gzip	902 B	902 B	✓
index-5c6845..f75c.js gzip	230 B	230 B	✓
link-99f0c6c..b84a.js gzip	1.65 kB	1.65 kB	✓
routerDirect..bb56.js gzip	306 B	306 B	✓
withRouter-7..2133.js gzip	302 B	302 B	✓
Overall change	8.57 kB	8.57 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	326 B	326 B	✓
Overall change	326 B	326 B	✓

Rendered Page Sizes Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	586 B	587 B	⚠️ +1 B
link.html gzip	593 B	594 B	⚠️ +1 B
withRouter.html gzip	581 B	583 B	⚠️ +2 B
Overall change	1.76 kB	1.76 kB	⚠️ +4 B

Diffs

Diff for main-HASH.js

@@ -542,23 +542,26 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
         return (
           console.error(r),
           Y.loadPage("/_error").then(function(n) {
-            var o = n.page,
-              a = n.styleSheets,
-              i = me(t),
-              u = {
-                Component: o,
-                AppTree: i,
+            var o,
+              a = n.page,
+              i = n.styleSheets,
+              u = me(t),
+              c = {
+                Component: a,
+                AppTree: u,
                 router: Q,
-                ctx: { err: r, pathname: R, query: F, asPath: U, AppTree: i }
+                ctx: { err: r, pathname: R, query: F, asPath: U, AppTree: u }
               };
             return Promise.resolve(
-              e.props ? e.props : (0, x.loadGetInitialProps)(t, u)
+              null != (o = e.props) && o.err
+                ? e.props
+                : (0, x.loadGetInitialProps)(t, c)
             ).then(function(t) {
               return he(
                 (0, m.default)({}, e, {
                   err: r,
-                  Component: o,
-                  styleSheets: a,
+                  Component: a,
+                  styleSheets: i,
                   props: t
                 })
               );

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-64db1875672aa3f9880d.js"
+      href="/_next/static/chunks/main-cebbd08d299ec4ea2b34.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "n3dEuzY9JRZ8cp8J6XRiq",
+        "buildId": "XBYYxpngbplXBXMddraiX",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-64db1875672aa3f9880d.js"
+      src="/_next/static/chunks/main-cebbd08d299ec4ea2b34.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/n3dEuzY9JRZ8cp8J6XRiq/_buildManifest.js"
+      src="/_next/static/XBYYxpngbplXBXMddraiX/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/n3dEuzY9JRZ8cp8J6XRiq/_ssgManifest.js"
+      src="/_next/static/XBYYxpngbplXBXMddraiX/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-64db1875672aa3f9880d.js"
+      href="/_next/static/chunks/main-cebbd08d299ec4ea2b34.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "n3dEuzY9JRZ8cp8J6XRiq",
+        "buildId": "XBYYxpngbplXBXMddraiX",
         "isFallback": false,
         "gip": true
       }
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-64db1875672aa3f9880d.js"
+      src="/_next/static/chunks/main-cebbd08d299ec4ea2b34.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/n3dEuzY9JRZ8cp8J6XRiq/_buildManifest.js"
+      src="/_next/static/XBYYxpngbplXBXMddraiX/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/n3dEuzY9JRZ8cp8J6XRiq/_ssgManifest.js"
+      src="/_next/static/XBYYxpngbplXBXMddraiX/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-64db1875672aa3f9880d.js"
+      href="/_next/static/chunks/main-cebbd08d299ec4ea2b34.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "n3dEuzY9JRZ8cp8J6XRiq",
+        "buildId": "XBYYxpngbplXBXMddraiX",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-64db1875672aa3f9880d.js"
+      src="/_next/static/chunks/main-cebbd08d299ec4ea2b34.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/n3dEuzY9JRZ8cp8J6XRiq/_buildManifest.js"
+      src="/_next/static/XBYYxpngbplXBXMddraiX/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/n3dEuzY9JRZ8cp8J6XRiq/_ssgManifest.js"
+      src="/_next/static/XBYYxpngbplXBXMddraiX/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 9ae24fd

ijjk · 2021-02-27T14:11:28Z

Failing test suites

Commit: 9ae24fd

test/integration/script-loader/test/index.test.js

Script Loader > priority lazy

Expand output

● Script Loader › priority lazy

thrown: "Exceeded timeout of 300000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  66 |   })
  67 | 
> 68 |   it('priority lazy', async () => {
     |   ^
  69 |     let browser
  70 |     try {
  71 |       browser = await webdriver(appPort, '/page3')

  at integration/script-loader/test/index.test.js:68:3
  at Object.<anonymous> (integration/script-loader/test/index.test.js:21:1)

ijjk · 2021-03-02T13:37:45Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	12.6s	12.6s	-14ms
nodeModulesSize	42.6 MB	42.7 MB	⚠️ +89.8 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.272	2.309	⚠️ +0.04
/ avg req/sec	1100.34	1082.65	⚠️ -17.69
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.569	1.567	0
/error-in-render avg req/sec	1593.55	1594.97	+1.42

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..e7a0.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.66 kB	⚠️ +11 B
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.7 kB	59.8 kB	⚠️ +11 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	613 B	612 B	-1 B
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	-1 B

Diffs

Diff for main-HASH.js

@@ -869,9 +869,11 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
         return pageLoader.loadPage("/_error").then(function(_ref5) {
           var ErrorComponent = _ref5.page,
             styleSheets = _ref5.styleSheets;
-          // In production we do a normal render with the `ErrorComponent` as component.
+
+          var _renderErrorProps$pro; // In production we do a normal render with the `ErrorComponent` as component.
           // If we've gotten here upon initial render, we can use the props from the server.
           // Otherwise, we need to call `getInitialProps` on `App` before mounting.
+
           var AppTree = wrapApp(App);
           var appCtx = {
             Component: ErrorComponent,
@@ -886,7 +888,8 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
             }
           };
           return Promise.resolve(
-            renderErrorProps.props
+            (_renderErrorProps$pro = renderErrorProps.props) != null &&
+              _renderErrorProps$pro.err
               ? renderErrorProps.props
               : (0, _utils.loadGetInitialProps)(App, appCtx)
           ).then(function(initProps) {

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c4806f8dd086f24f4ac1.js"
+      href="/_next/static/chunks/main-40751e7ca5182405a4f1.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c4806f8dd086f24f4ac1.js"
+      src="/_next/static/chunks/main-40751e7ca5182405a4f1.js"
       async=""
     ></script>
     <script

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c4806f8dd086f24f4ac1.js"
+      href="/_next/static/chunks/main-40751e7ca5182405a4f1.js"
       as="script"
     />
     <link
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c4806f8dd086f24f4ac1.js"
+      src="/_next/static/chunks/main-40751e7ca5182405a4f1.js"
       async=""
     ></script>
     <script

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-c4806f8dd086f24f4ac1.js"
+      href="/_next/static/chunks/main-40751e7ca5182405a4f1.js"
       as="script"
     />
     <link
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-020d2be99297a5eb71a0.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-c4806f8dd086f24f4ac1.js"
+      src="/_next/static/chunks/main-40751e7ca5182405a4f1.js"
       async=""
     ></script>
     <script

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	14.3s	14.6s	⚠️ +273ms
nodeModulesSize	42.6 MB	42.7 MB	⚠️ +89.8 kB

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
677f882d2ed8..e7a0.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.65 kB	6.66 kB	⚠️ +11 B
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.7 kB	59.8 kB	⚠️ +11 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
amp-e3e9bc99..932c.js gzip	536 B	536 B	✓
hooks-5023ef..3670.js gzip	888 B	888 B	✓
index-3a2b03..c677.js gzip	227 B	227 B	✓
link-177412b..043e.js gzip	1.67 kB	1.67 kB	✓
routerDirect..1a66.js gzip	303 B	303 B	✓
withRouter-9..1b7d.js gzip	302 B	302 B	✓
Overall change	8.66 kB	8.66 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	347 B	347 B	✓
Overall change	347 B	347 B	✓

Serverless bundles

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_error.js	1.01 MB	1.01 MB	✓
404.html	2.67 kB	2.67 kB	✓
500.html	2.65 kB	2.65 kB	✓
amp.amp.html	10.4 kB	10.4 kB	✓
amp.html	1.86 kB	1.86 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1.01 MB	1.01 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.21 MB	5.21 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
buildDuration	14.5s	14.4s	-128ms
nodeModulesSize	42.6 MB	42.7 MB	⚠️ +89.8 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.253	2.247	-0.01
/ avg req/sec	1109.57	1112.79	+3.22
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.583	1.523	-0.06
/error-in-render avg req/sec	1579.28	1641.42	+62.14

Client Bundles (main, webpack, commons) Overall increase ⚠️

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
597-74632e79..1d47.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.6 kB	6.61 kB	⚠️ +11 B
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	60.1 kB	60.2 kB	⚠️ +11 B

Legacy Client Bundles (polyfills)

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_app-aedc815..1421.js gzip	1.26 kB	1.26 kB	✓
_error-71ec2..1a96.js gzip	3.38 kB	3.38 kB	✓
amp-33a09cb0..6745.js gzip	536 B	536 B	✓
hooks-4e968a..f870.js gzip	902 B	902 B	✓
index-5c6845..f75c.js gzip	230 B	230 B	✓
link-99f0c6c..b84a.js gzip	1.65 kB	1.65 kB	✓
routerDirect..bb56.js gzip	306 B	306 B	✓
withRouter-7..2133.js gzip	302 B	302 B	✓
Overall change	8.57 kB	8.57 kB	✓

Client Build Manifests

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
_buildManifest.js gzip	326 B	326 B	✓
Overall change	326 B	326 B	✓

Rendered Page Sizes Overall decrease ✓

	vercel/next.js canary	okmttdhr/next.js fix/get-initial-props-not-called	Change
index.html gzip	586 B	585 B	-1 B
link.html gzip	594 B	592 B	-2 B
withRouter.html gzip	581 B	580 B	-1 B
Overall change	1.76 kB	1.76 kB	-4 B

Diffs

Diff for main-HASH.js

@@ -542,23 +542,26 @@ _N_E = (window.webpackJsonp_N_E = window.webpackJsonp_N_E || []).push([
         return (
           console.error(r),
           Y.loadPage("/_error").then(function(n) {
-            var o = n.page,
-              a = n.styleSheets,
-              i = me(t),
-              u = {
-                Component: o,
-                AppTree: i,
+            var o,
+              a = n.page,
+              i = n.styleSheets,
+              u = me(t),
+              c = {
+                Component: a,
+                AppTree: u,
                 router: Q,
-                ctx: { err: r, pathname: R, query: F, asPath: U, AppTree: i }
+                ctx: { err: r, pathname: R, query: F, asPath: U, AppTree: u }
               };
             return Promise.resolve(
-              e.props ? e.props : (0, x.loadGetInitialProps)(t, u)
+              null != (o = e.props) && o.err
+                ? e.props
+                : (0, x.loadGetInitialProps)(t, c)
             ).then(function(t) {
               return he(
                 (0, m.default)({}, e, {
                   err: r,
-                  Component: o,
-                  styleSheets: a,
+                  Component: a,
+                  styleSheets: i,
                   props: t
                 })
               );

Diff for index.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-3a8689b2a46bc4c4085d.js"
+      href="/_next/static/chunks/main-78a3677c4c0fd23d28c0.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "Yz0kKgFZm9iMJjyp5zULd",
+        "buildId": "5vpHNCjK_02tGsRQZaK_3",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-3a8689b2a46bc4c4085d.js"
+      src="/_next/static/chunks/main-78a3677c4c0fd23d28c0.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Yz0kKgFZm9iMJjyp5zULd/_buildManifest.js"
+      src="/_next/static/5vpHNCjK_02tGsRQZaK_3/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Yz0kKgFZm9iMJjyp5zULd/_ssgManifest.js"
+      src="/_next/static/5vpHNCjK_02tGsRQZaK_3/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-3a8689b2a46bc4c4085d.js"
+      href="/_next/static/chunks/main-78a3677c4c0fd23d28c0.js"
       as="script"
     />
     <link
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "Yz0kKgFZm9iMJjyp5zULd",
+        "buildId": "5vpHNCjK_02tGsRQZaK_3",
         "isFallback": false,
         "gip": true
       }
@@ -58,7 +58,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-3a8689b2a46bc4c4085d.js"
+      src="/_next/static/chunks/main-78a3677c4c0fd23d28c0.js"
       async=""
     ></script>
     <script
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Yz0kKgFZm9iMJjyp5zULd/_buildManifest.js"
+      src="/_next/static/5vpHNCjK_02tGsRQZaK_3/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Yz0kKgFZm9iMJjyp5zULd/_ssgManifest.js"
+      src="/_next/static/5vpHNCjK_02tGsRQZaK_3/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -7,7 +7,7 @@
     <noscript data-n-css=""></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-3a8689b2a46bc4c4085d.js"
+      href="/_next/static/chunks/main-78a3677c4c0fd23d28c0.js"
       as="script"
     />
     <link
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "Yz0kKgFZm9iMJjyp5zULd",
+        "buildId": "5vpHNCjK_02tGsRQZaK_3",
         "isFallback": false,
         "gip": true
       }
@@ -53,7 +53,7 @@
       src="/_next/static/chunks/polyfills-ff94e68042added27a93.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-3a8689b2a46bc4c4085d.js"
+      src="/_next/static/chunks/main-78a3677c4c0fd23d28c0.js"
       async=""
     ></script>
     <script
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Yz0kKgFZm9iMJjyp5zULd/_buildManifest.js"
+      src="/_next/static/5vpHNCjK_02tGsRQZaK_3/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Yz0kKgFZm9iMJjyp5zULd/_ssgManifest.js"
+      src="/_next/static/5vpHNCjK_02tGsRQZaK_3/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: acb7e03

lobsterkatie · 2022-06-07T04:54:33Z

Bumping this, as it'd be helpful for @sentry/nextjs to get this fixed.

@timneutkens @ijjk, i s there anything we can do to help move this forward? Can you confirm that this does in fact solve #8592 and therefore obviate the need for the workaround here?

ijjk · 2022-07-06T18:18:39Z

The change here does appear to remove the need for the linked workaround.

ijjk

Change and added tests look good, thanks!

fix: Call Error.getInitialProps to pass err

2886241

ijjk added the type: next label Jan 17, 2021

okmttdhr changed the title ~~fix: Call Error.getInitialProps to pass err~~ fix: Call Error.getInitialProps for the top level error Jan 17, 2021

okmttdhr changed the title ~~fix: Call Error.getInitialProps for the top level error~~ Call Error.getInitialProps for the top level error Jan 17, 2021

test: Call Error.getInitialPropsfoe the top level error

81fa0c3

okmttdhr marked this pull request as ready for review January 17, 2021 05:57

okmttdhr requested review from ijjk, lfades, Timer and timneutkens as code owners January 17, 2021 05:57

Merge branch 'canary' into fix/get-initial-props-not-called

ea3d8a5

test: Update build output limit

0777eb2

okmttdhr added 2 commits February 20, 2021 22:55

test: Add tests for top level error

252abc5

Revert "test: Call Error.getInitialPropsfoe the top level error"

c9ef055

This reverts commit 81fa0c3.

okmttdhr requested a review from divmain as a code owner February 20, 2021 13:56

Merge remote-tracking branch 'upstream/canary' into fix/get-initial-p…

e48826c

…rops-not-called

Merge branch 'canary' into fix/get-initial-props-not-called

d9ce0bc

test: Fix failing test

9ae24fd

Merge branch 'canary' into fix/get-initial-props-not-called

acb7e03

okmttdhr requested review from huozhi, padmaia, shuding and styfle as code owners October 26, 2021 15:29

Timer removed request for Timer, lfades and divmain December 10, 2021 02:57

ijjk added 2 commits July 6, 2022 13:17

Merge branch 'canary' into fix/get-initial-props-not-called

c4fb748

Merge branch 'canary' into fix/get-initial-props-not-called

c3cbf46

ijjk approved these changes Jul 6, 2022

View reviewed changes

ijjk merged commit 69f8024 into vercel:canary Jul 6, 2022

lobsterkatie mentioned this pull request Jul 6, 2022

feat(examples): Use helper function in with-sentry example _error.js #37866

Merged

2 tasks

okmttdhr deleted the fix/get-initial-props-not-called branch July 8, 2022 08:53

github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Call Error.getInitialProps for the top level error #21240

Call Error.getInitialProps for the top level error #21240

okmttdhr commented Jan 17, 2021 •

edited

ijjk commented Jan 17, 2021

Diffs

ijjk commented Jan 17, 2021

Diffs

Janpot commented Jan 28, 2021

ijjk commented Feb 14, 2021

ijjk commented Feb 14, 2021

Diffs

Diffs

ijjk commented Feb 14, 2021

Diffs

Diffs

ijjk commented Feb 20, 2021

Diffs

Diffs

ijjk commented Feb 20, 2021

ijjk commented Feb 27, 2021

Diffs

Diffs

ijjk commented Feb 27, 2021

ijjk commented Feb 27, 2021

Diffs

Diffs

ijjk commented Feb 27, 2021

ijjk commented Mar 2, 2021

Diffs

Diffs

lobsterkatie commented Jun 7, 2022 •

edited

ijjk commented Jul 6, 2022

ijjk left a comment

Call Error.getInitialProps for the top level error #21240

Call Error.getInitialProps for the top level error #21240

Conversation

okmttdhr commented Jan 17, 2021 • edited

ijjk commented Jan 17, 2021

Stats from current PR

Diffs

ijjk commented Jan 17, 2021

Stats from current PR

Diffs

Janpot commented Jan 28, 2021

ijjk commented Feb 14, 2021

Failing test suites

ijjk commented Feb 14, 2021

Stats from current PR

Diffs

Diffs

ijjk commented Feb 14, 2021

Stats from current PR

Diffs

Diffs

ijjk commented Feb 20, 2021

Stats from current PR

Diffs

Diffs

ijjk commented Feb 20, 2021

Failing test suites

ijjk commented Feb 27, 2021

Stats from current PR

Diffs

Diffs

ijjk commented Feb 27, 2021

Failing test suites

ijjk commented Feb 27, 2021

Stats from current PR

Diffs

Diffs

ijjk commented Feb 27, 2021

Failing test suites

ijjk commented Mar 2, 2021

Stats from current PR

Diffs

Diffs

lobsterkatie commented Jun 7, 2022 • edited

ijjk commented Jul 6, 2022

ijjk left a comment

Choose a reason for hiding this comment

okmttdhr commented Jan 17, 2021 •

edited

lobsterkatie commented Jun 7, 2022 •

edited