Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Note to i18n-routing Docs for Subdomains for Locale Domains #21387

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Add Note to i18n-routing Docs for Subdomains for Locale Domains #21387

merged 2 commits into from
Jan 20, 2021

Conversation

davidspiessens
Copy link
Contributor

No description provided.

@ijjk ijjk changed the title Update i18n-routing.md Add Note to i18n-routing Docs for Subdomains for Locale Domains Jan 20, 2021
ijjk
ijjk approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Jan 20, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary davidspiessens/next.js patch-1 Change
buildDuration 9.1s 9.1s -20ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary davidspiessens/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.745 1.776 ⚠️ +0.03
/ avg req/sec 1432.9 1407.53 ⚠️ -25.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.102 1.118 ⚠️ +0.02
/error-in-render avg req/sec 2268.93 2236.96 ⚠️ -31.97
Client Bundles (main, webpack, commons)
vercel/next.js canary davidspiessens/next.js patch-1 Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary davidspiessens/next.js patch-1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary davidspiessens/next.js patch-1 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary davidspiessens/next.js patch-1 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary davidspiessens/next.js patch-1 Change
index.html gzip 616 B 616 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General
vercel/next.js canary davidspiessens/next.js patch-1 Change
buildDuration 10.6s 10.5s -108ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary davidspiessens/next.js patch-1 Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary davidspiessens/next.js patch-1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary davidspiessens/next.js patch-1 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary davidspiessens/next.js patch-1 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary davidspiessens/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary davidspiessens/next.js patch-1 Change
buildDuration 10.6s 10.9s ⚠️ +238ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary davidspiessens/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.746 1.747 0
/ avg req/sec 1431.69 1431.11 ⚠️ -0.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.117 1.098 -0.02
/error-in-render avg req/sec 2237.42 2277.21 +39.79
Client Bundles (main, webpack, commons)
vercel/next.js canary davidspiessens/next.js patch-1 Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary davidspiessens/next.js patch-1 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary davidspiessens/next.js patch-1 Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary davidspiessens/next.js patch-1 Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary davidspiessens/next.js patch-1 Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 579 B 579 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "Cufh2XUxhUxHdB4mRhpeW",
+        "buildId": "wuc8GwopPG-ZBUvNFvuFE",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Cufh2XUxhUxHdB4mRhpeW/_buildManifest.js"
+      src="/_next/static/wuc8GwopPG-ZBUvNFvuFE/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Cufh2XUxhUxHdB4mRhpeW/_ssgManifest.js"
+      src="/_next/static/wuc8GwopPG-ZBUvNFvuFE/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "Cufh2XUxhUxHdB4mRhpeW",
+        "buildId": "wuc8GwopPG-ZBUvNFvuFE",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Cufh2XUxhUxHdB4mRhpeW/_buildManifest.js"
+      src="/_next/static/wuc8GwopPG-ZBUvNFvuFE/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Cufh2XUxhUxHdB4mRhpeW/_ssgManifest.js"
+      src="/_next/static/wuc8GwopPG-ZBUvNFvuFE/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "Cufh2XUxhUxHdB4mRhpeW",
+        "buildId": "wuc8GwopPG-ZBUvNFvuFE",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Cufh2XUxhUxHdB4mRhpeW/_buildManifest.js"
+      src="/_next/static/wuc8GwopPG-ZBUvNFvuFE/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Cufh2XUxhUxHdB4mRhpeW/_ssgManifest.js"
+      src="/_next/static/wuc8GwopPG-ZBUvNFvuFE/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: ccd8846

@kodiakhq kodiakhq bot merged commit 0fc46d0 into vercel:canary Jan 20, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidspiessens @ijjk