Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade webpack5 #21563

Merged
merged 2 commits into from
Jan 26, 2021
Merged

chore: upgrade webpack5 #21563

merged 2 commits into from
Jan 26, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Jan 26, 2021

No description provided.

@ijjk
Copy link
Member

ijjk commented Jan 26, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
buildDuration 8.9s 8.8s -99ms
nodeModulesSize 74.9 MB 75 MB ⚠️ +38.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.761 1.747 -0.01
/ avg req/sec 1419.77 1431.12 +11.35
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.105 1.153 ⚠️ +0.05
/error-in-render avg req/sec 2262.15 2168.31 ⚠️ -93.84
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
buildDuration 10.5s 10.7s ⚠️ +214ms
nodeModulesSize 74.9 MB 75 MB ⚠️ +38.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
buildDuration 10.7s 10.6s -137ms
nodeModulesSize 74.9 MB 75 MB ⚠️ +38.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.767 1.809 ⚠️ +0.04
/ avg req/sec 1415.02 1382.29 ⚠️ -32.73
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.103 1.123 ⚠️ +0.02
/error-in-render avg req/sec 2266.82 2226.77 ⚠️ -40.05
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
597-c48889ef..1870.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary Timer/next.js upgrade/webpack-5 Change
index.html gzip 587 B 586 B -1 B
link.html gzip 591 B 592 B ⚠️ +1 B
withRouter.html gzip 580 B 579 B -1 B
Overall change 1.76 kB 1.76 kB -1 B

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "COSH2y3QpIrYEyZkVBqEm",
+        "buildId": "o3-mq3tXON9zUwuZq2DDj",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/COSH2y3QpIrYEyZkVBqEm/_buildManifest.js"
+      src="/_next/static/o3-mq3tXON9zUwuZq2DDj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/COSH2y3QpIrYEyZkVBqEm/_ssgManifest.js"
+      src="/_next/static/o3-mq3tXON9zUwuZq2DDj/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "COSH2y3QpIrYEyZkVBqEm",
+        "buildId": "o3-mq3tXON9zUwuZq2DDj",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/COSH2y3QpIrYEyZkVBqEm/_buildManifest.js"
+      src="/_next/static/o3-mq3tXON9zUwuZq2DDj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/COSH2y3QpIrYEyZkVBqEm/_ssgManifest.js"
+      src="/_next/static/o3-mq3tXON9zUwuZq2DDj/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "COSH2y3QpIrYEyZkVBqEm",
+        "buildId": "o3-mq3tXON9zUwuZq2DDj",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/COSH2y3QpIrYEyZkVBqEm/_buildManifest.js"
+      src="/_next/static/o3-mq3tXON9zUwuZq2DDj/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/COSH2y3QpIrYEyZkVBqEm/_ssgManifest.js"
+      src="/_next/static/o3-mq3tXON9zUwuZq2DDj/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: acaff0b

@kodiakhq kodiakhq bot merged commit b785fbc into vercel:canary Jan 26, 2021
@Timer Timer deleted the upgrade/webpack-5 branch January 26, 2021 21:06
This was referenced Jan 29, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 14, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Aug 3, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Aug 31, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 15, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 9, 2021
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 16, 2021
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Timer @ijjk