feat: add type to previewData #21574

tarunama · 2021-01-27T04:38:43Z

previewData was already typed declare variable.
So I have defined PreviewData type, and adapt for avoiding error by type safe.

ijjk · 2021-01-27T04:47:47Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	8.5s	8.6s	⚠️ +180ms
nodeModulesSize	75 MB	75 MB	⚠️ +189 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.701	1.695	-0.01
/ avg req/sec	1469.33	1474.7	+5.37
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.049	1.073	⚠️ +0.02
/error-in-render avg req/sec	2382.87	2329.79	⚠️ -53.08

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	10s	10.1s	⚠️ +131ms
nodeModulesSize	75 MB	75 MB	⚠️ +189 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	10.4s	10.2s	-201ms
nodeModulesSize	75 MB	75 MB	⚠️ +189 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.675	1.692	⚠️ +0.02
/ avg req/sec	1492.48	1477.75	⚠️ -14.73
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.084	1.052	-0.03
/error-in-render avg req/sec	2307.05	2376.65	+69.6

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
597-7c719119..27b6.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-6e0a903..b885.js gzip	1.26 kB	1.26 kB	✓
_error-7a100..a392.js gzip	3.38 kB	3.38 kB	✓
hooks-f7e199..11b9.js gzip	904 B	904 B	✓
index-3dc22c..ffbb.js gzip	232 B	232 B	✓
link-c010d28..b60a.js gzip	1.63 kB	1.63 kB	✓
routerDirect..323a.js gzip	308 B	308 B	✓
withRouter-a..2ef8.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
index.html gzip	586 B	586 B	✓
link.html gzip	592 B	592 B	✓
withRouter.html gzip	579 B	579 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "A1yjs3-hkkuzGLBzOjzT2",
+        "buildId": "IM15J6ay0weJK7QxNtfXF",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/A1yjs3-hkkuzGLBzOjzT2/_buildManifest.js"
+      src="/_next/static/IM15J6ay0weJK7QxNtfXF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/A1yjs3-hkkuzGLBzOjzT2/_ssgManifest.js"
+      src="/_next/static/IM15J6ay0weJK7QxNtfXF/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "A1yjs3-hkkuzGLBzOjzT2",
+        "buildId": "IM15J6ay0weJK7QxNtfXF",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/A1yjs3-hkkuzGLBzOjzT2/_buildManifest.js"
+      src="/_next/static/IM15J6ay0weJK7QxNtfXF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/A1yjs3-hkkuzGLBzOjzT2/_ssgManifest.js"
+      src="/_next/static/IM15J6ay0weJK7QxNtfXF/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "A1yjs3-hkkuzGLBzOjzT2",
+        "buildId": "IM15J6ay0weJK7QxNtfXF",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/A1yjs3-hkkuzGLBzOjzT2/_buildManifest.js"
+      src="/_next/static/IM15J6ay0weJK7QxNtfXF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/A1yjs3-hkkuzGLBzOjzT2/_ssgManifest.js"
+      src="/_next/static/IM15J6ay0weJK7QxNtfXF/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 08c0c52

ijjk · 2021-01-27T05:01:22Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	8.8s	9s	⚠️ +200ms
nodeModulesSize	75 MB	75 MB	⚠️ +189 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.727	1.871	⚠️ +0.14
/ avg req/sec	1447.81	1335.86	⚠️ -111.95
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.068	1.118	⚠️ +0.05
/error-in-render avg req/sec	2341.28	2235.19	⚠️ -106.09

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	10.4s	10.4s	-85ms
nodeModulesSize	75 MB	75 MB	⚠️ +189 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	10.7s	10.6s	-85ms
nodeModulesSize	75 MB	75 MB	⚠️ +189 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.816	1.705	-0.11
/ avg req/sec	1376.71	1466.67	+89.96
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.131	1.082	-0.05
/error-in-render avg req/sec	2210.53	2311.4	+100.87

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
597-7c719119..27b6.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-6e0a903..b885.js gzip	1.26 kB	1.26 kB	✓
_error-7a100..a392.js gzip	3.38 kB	3.38 kB	✓
hooks-f7e199..11b9.js gzip	904 B	904 B	✓
index-3dc22c..ffbb.js gzip	232 B	232 B	✓
link-c010d28..b60a.js gzip	1.63 kB	1.63 kB	✓
routerDirect..323a.js gzip	308 B	308 B	✓
withRouter-a..2ef8.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
index.html gzip	586 B	586 B	✓
link.html gzip	592 B	592 B	✓
withRouter.html gzip	579 B	579 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "rtrQrnPCBMNh800TAffD-",
+        "buildId": "2Bp_-eRea98vcnTRsJ4CX",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/rtrQrnPCBMNh800TAffD-/_buildManifest.js"
+      src="/_next/static/2Bp_-eRea98vcnTRsJ4CX/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/rtrQrnPCBMNh800TAffD-/_ssgManifest.js"
+      src="/_next/static/2Bp_-eRea98vcnTRsJ4CX/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "rtrQrnPCBMNh800TAffD-",
+        "buildId": "2Bp_-eRea98vcnTRsJ4CX",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/rtrQrnPCBMNh800TAffD-/_buildManifest.js"
+      src="/_next/static/2Bp_-eRea98vcnTRsJ4CX/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/rtrQrnPCBMNh800TAffD-/_ssgManifest.js"
+      src="/_next/static/2Bp_-eRea98vcnTRsJ4CX/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "rtrQrnPCBMNh800TAffD-",
+        "buildId": "2Bp_-eRea98vcnTRsJ4CX",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/rtrQrnPCBMNh800TAffD-/_buildManifest.js"
+      src="/_next/static/2Bp_-eRea98vcnTRsJ4CX/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/rtrQrnPCBMNh800TAffD-/_ssgManifest.js"
+      src="/_next/static/2Bp_-eRea98vcnTRsJ4CX/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 347b91b

ijjk · 2021-01-30T13:53:17Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	10.5s	10.5s	⚠️ +45ms
nodeModulesSize	75 MB	75 MB	⚠️ +215 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.035	2.029	-0.01
/ avg req/sec	1228.31	1232.31	+4
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.288	1.271	-0.02
/error-in-render avg req/sec	1940.81	1966.38	+25.57

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
677f882d2ed8..49c4.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
index.html gzip	613 B	613 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	12.2s	12.1s	-121ms
nodeModulesSize	75 MB	75 MB	⚠️ +215 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
677f882d2ed8..49c4.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	12.4s	12.4s	⚠️ +3ms
nodeModulesSize	75 MB	75 MB	⚠️ +215 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.047	2.026	-0.02
/ avg req/sec	1221.21	1233.94	+12.73
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.266	1.296	⚠️ +0.03
/error-in-render avg req/sec	1975.31	1929.02	⚠️ -46.29

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
597-6c246419..806f.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.57 kB	6.57 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-6e0a903..b885.js gzip	1.26 kB	1.26 kB	✓
_error-7a100..a392.js gzip	3.38 kB	3.38 kB	✓
hooks-f7e199..11b9.js gzip	904 B	904 B	✓
index-3dc22c..ffbb.js gzip	232 B	232 B	✓
link-c010d28..b60a.js gzip	1.63 kB	1.63 kB	✓
routerDirect..323a.js gzip	308 B	308 B	✓
withRouter-a..2ef8.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
index.html gzip	584 B	584 B	✓
link.html gzip	592 B	592 B	✓
withRouter.html gzip	577 B	577 B	✓
Overall change	1.75 kB	1.75 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "ojLEEK37NZg2M5m0oi5IJ",
+        "buildId": "jQ_bQQIUDxFeRcjP3CohP",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ojLEEK37NZg2M5m0oi5IJ/_buildManifest.js"
+      src="/_next/static/jQ_bQQIUDxFeRcjP3CohP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ojLEEK37NZg2M5m0oi5IJ/_ssgManifest.js"
+      src="/_next/static/jQ_bQQIUDxFeRcjP3CohP/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "ojLEEK37NZg2M5m0oi5IJ",
+        "buildId": "jQ_bQQIUDxFeRcjP3CohP",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ojLEEK37NZg2M5m0oi5IJ/_buildManifest.js"
+      src="/_next/static/jQ_bQQIUDxFeRcjP3CohP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ojLEEK37NZg2M5m0oi5IJ/_ssgManifest.js"
+      src="/_next/static/jQ_bQQIUDxFeRcjP3CohP/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "ojLEEK37NZg2M5m0oi5IJ",
+        "buildId": "jQ_bQQIUDxFeRcjP3CohP",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ojLEEK37NZg2M5m0oi5IJ/_buildManifest.js"
+      src="/_next/static/jQ_bQQIUDxFeRcjP3CohP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ojLEEK37NZg2M5m0oi5IJ/_ssgManifest.js"
+      src="/_next/static/jQ_bQQIUDxFeRcjP3CohP/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 9801b44

ijjk · 2021-02-05T06:02:23Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	10.5s	10.4s	-141ms
nodeModulesSize	75.3 MB	75.3 MB	⚠️ +215 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.028	2.016	-0.01
/ avg req/sec	1232.51	1239.97	+7.46
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.369	1.248	-0.12
/error-in-render avg req/sec	1825.67	2002.55	+176.88

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
677f882d2ed8..49c4.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
index.html gzip	615 B	615 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	12.3s	12.2s	-126ms
nodeModulesSize	75.3 MB	75.3 MB	⚠️ +215 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
677f882d2ed8..49c4.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.5 kB	59.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.06 MB	1.06 MB	✓
withRouter.js	1.06 MB	1.06 MB	✓
Overall change	5.19 MB	5.19 MB	✓

Webpack 5 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	12.6s	12.7s	⚠️ +160ms
nodeModulesSize	75.3 MB	75.3 MB	⚠️ +215 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.041	2.024	-0.02
/ avg req/sec	1225.04	1235.07	+10.03
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.27	1.344	⚠️ +0.07
/error-in-render avg req/sec	1968.55	1860.33	⚠️ -108.22

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
597-6c246419..806f.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.9 kB	59.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-6e0a903..b885.js gzip	1.26 kB	1.26 kB	✓
_error-7a100..a392.js gzip	3.38 kB	3.38 kB	✓
hooks-f7e199..11b9.js gzip	904 B	904 B	✓
index-3dc22c..ffbb.js gzip	232 B	232 B	✓
link-c010d28..b60a.js gzip	1.63 kB	1.63 kB	✓
routerDirect..323a.js gzip	308 B	308 B	✓
withRouter-a..2ef8.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
index.html gzip	585 B	585 B	✓
link.html gzip	592 B	592 B	✓
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "41IyA_Ih4N2EZYFLDDkuy",
+        "buildId": "F1_i2HmhiZi9zTB-PwV7g",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/41IyA_Ih4N2EZYFLDDkuy/_buildManifest.js"
+      src="/_next/static/F1_i2HmhiZi9zTB-PwV7g/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/41IyA_Ih4N2EZYFLDDkuy/_ssgManifest.js"
+      src="/_next/static/F1_i2HmhiZi9zTB-PwV7g/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "41IyA_Ih4N2EZYFLDDkuy",
+        "buildId": "F1_i2HmhiZi9zTB-PwV7g",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/41IyA_Ih4N2EZYFLDDkuy/_buildManifest.js"
+      src="/_next/static/F1_i2HmhiZi9zTB-PwV7g/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/41IyA_Ih4N2EZYFLDDkuy/_ssgManifest.js"
+      src="/_next/static/F1_i2HmhiZi9zTB-PwV7g/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "41IyA_Ih4N2EZYFLDDkuy",
+        "buildId": "F1_i2HmhiZi9zTB-PwV7g",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/41IyA_Ih4N2EZYFLDDkuy/_buildManifest.js"
+      src="/_next/static/F1_i2HmhiZi9zTB-PwV7g/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/41IyA_Ih4N2EZYFLDDkuy/_ssgManifest.js"
+      src="/_next/static/F1_i2HmhiZi9zTB-PwV7g/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 1e9f099

errors/invalid-getstaticprops-value.md

# Conflicts: # packages/next/next-server/server/render.tsx

ijjk · 2021-04-20T17:57:36Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	15.5s	15.3s	-273ms
buildDurationCached	5s	4.5s	-508ms
nodeModulesSize	46.6 MB	46.6 MB	⚠️ +215 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.651	2.688	⚠️ +0.04
/ avg req/sec	942.9	929.99	⚠️ -12.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.465	1.528	⚠️ +0.06
/error-in-render avg req/sec	1706.59	1636.03	⚠️ -70.56

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.12 kB	7.12 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
css-HASH.js gzip	363 B	363 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	9.52 kB	9.52 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Rendered Page Sizes

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
index.html gzip	611 B	611 B	✓
link.html gzip	616 B	616 B	✓
withRouter.html gzip	605 B	605 B	✓
Overall change	1.83 kB	1.83 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	19s	18.8s	-159ms
buildDurationCached	7s	7.2s	⚠️ +193ms
nodeModulesSize	46.6 MB	46.6 MB	⚠️ +215 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
597-HASH.js gzip	13.3 kB	13.3 kB	✓
778-HASH.js gzip	7.12 kB	7.12 kB	✓
framework-HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	151 B	151 B	✓
webpack-HASH.js gzip	993 B	993 B	✓
Overall change	60.8 kB	60.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-HASH.js gzip	1.3 kB	1.3 kB	✓
_error-HASH.js gzip	3.68 kB	3.68 kB	✓
amp-HASH.js gzip	558 B	558 B	✓
css-HASH.js gzip	363 B	363 B	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	243 B	243 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	336 B	336 B	✓
withRouter-HASH.js gzip	334 B	334 B	✓
99a142a5cfae..804.css gzip	125 B	125 B	✓
Overall change	9.52 kB	9.52 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	390 B	390 B	✓
Overall change	390 B	390 B	✓

Serverless bundles

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_error.js	1.39 MB	1.39 MB	✓
404.html	2.76 kB	2.76 kB	✓
500.html	2.75 kB	2.75 kB	✓
amp.amp.html	10.7 kB	10.7 kB	✓
amp.html	1.96 kB	1.96 kB	✓
css.html	2.13 kB	2.13 kB	✓
hooks.html	2.01 kB	2.01 kB	✓
index.js	1.39 MB	1.39 MB	✓
link.js	1.45 MB	1.45 MB	✓
routerDirect.js	1.44 MB	1.44 MB	✓
withRouter.js	1.44 MB	1.44 MB	✓
Overall change	7.15 MB	7.15 MB	✓

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
buildDuration	12.9s	12.6s	-356ms
buildDurationCached	5.3s	5.3s	⚠️ +40ms
nodeModulesSize	46.6 MB	46.6 MB	⚠️ +215 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.759	2.655	-0.1
/ avg req/sec	906.11	941.64	+35.53
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.542	1.487	-0.05
/error-in-render avg req/sec	1621.56	1681.1	+59.54

Client Bundles (main, webpack, commons)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	7.2 kB	7.2 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	60.3 kB	60.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_app-HASH.js gzip	1.28 kB	1.28 kB	✓
_error-HASH.js gzip	3.71 kB	3.71 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	339 B	339 B	✓
hooks-HASH.js gzip	887 B	887 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	303 B	303 B	✓
withRouter-HASH.js gzip	302 B	302 B	✓
21c68fa65a48..217.css gzip	125 B	125 B	✓
Overall change	9.36 kB	9.36 kB	✓

Client Build Manifests

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
_buildManifest.js gzip	419 B	419 B	✓
Overall change	419 B	419 B	✓

Rendered Page Sizes

	vercel/next.js canary	tarunama/next.js feature/remove-any1	Change
index.html gzip	613 B	613 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	606 B	606 B	✓
Overall change	1.84 kB	1.84 kB	✓

Commit: 63ffabf

`previewData` was already [typed declare variable](https://github.com/vercel/next.js/compare/canary...tarunama:feature/remove-any1?expand=1#diff-bd7baf53ff559d84461af8b2fd62cade7e2d8eb203f489e24a27c5b83a79a9d3L1380). So I have defined `PreviewData` type, and adapt for avoiding error by type safe.

afenton90 · 2021-04-29T11:07:24Z

For anyone coming to this PR trying to figure out type issues because previewData was being used as an object in a previous version, a workaround is to cast with as:

interface PreviewContent {
   ref: string;
}

export const getServerSideProps: GetServerSideProps = async ({
  query,
  preview,
  previewData: nextPreviewData,
}) => {
  // For preview capability
  const previewData: PreviewContent =  nextPreviewData as PreviewContent;
}

howells · 2021-04-29T21:25:58Z

I'm running into this problem whereby I'm setting:

  res.setPreviewData({
    uid: req.query.sourceUid,
    token: req.query.token ?? null,
  });

And then getting the error Type error: Property 'token' does not exist on type 'PreviewData'. - not sure why? previewData should be an object, no, as per the docs?

afenton90 · 2021-04-30T08:11:42Z

@howells your usage of setPreviewData is correct. The problem has come about from the change in this PR to type the previewData prop without giving the option to customise it. The workaround I mentioned above ☝️ should work for you.

howells · 2021-04-30T13:16:49Z

@afenton90 got it, thanks

espipj · 2021-08-24T13:03:11Z

I think this previewData type needs to use Typescript Generics in at least GetServerSidePropsContext (may be affecting others)
https://github.com/vercel/next.js/pull/21574/files#diff-f1cccfe490138be7dae0d63562f6a2834af92d21130e0ff10d6de7ad30613f6bR136-R149

Otherwise it makes it non flexible at all and throws errors when upgrading from NextJS 9 to 10+...

A workaround that we've found is to extend the type but it is not ideal...

type GetServerSidePropsCtx = GetServerSidePropsContext<{
	id: string;
}> & { previewData: { someData: string; someOtherData: number } };

What do you think? @ijjk Im happy to work on it :)

espipj · 2021-08-24T13:05:26Z

packages/next/types/index.d.ts

 export type GetStaticPropsContext<Q extends ParsedUrlQuery = ParsedUrlQuery> = {
  params?: Q
  preview?: boolean
-  previewData?: any
+  previewData?: PreviewData


Changes would be in here and on GetServerSideProps

ijjk · 2021-08-24T14:44:24Z

Hi @espipj, yeah feel free to send a PR adding this!

espipj · 2021-08-31T16:52:25Z

Just opened the PR above @ijjk 😃

on GetServerSidePropsContext and GetStaticPropsContext As discussed on #21574 having a generic type will give it more flexibility and remove linting errors. ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using #21574 - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md`

feat: add type to previewData

08c0c52

tarunama requested review from ijjk, lfades, Timer and timneutkens as code owners January 27, 2021 04:38

ijjk added the type: next label Jan 27, 2021

run prettier

347b91b

tarunama added 4 commits January 30, 2021 22:24

doc: update about previewData

036dcf4

chore: add return type

50988ea

fix: import from next/types

06d05d1

Merge branch 'canary' into feature/remove-any1

9801b44

ijjk added the type: documentation label Jan 30, 2021

Merge branch 'canary' into feature/remove-any1

1e9f099

ijjk reviewed Apr 20, 2021

View reviewed changes

errors/invalid-getstaticprops-value.md Outdated Show resolved Hide resolved

ijjk reviewed Apr 20, 2021

View reviewed changes

errors/invalid-getstaticprops-value.md Outdated Show resolved Hide resolved

ijjk requested review from divmain and shuding as code owners April 20, 2021 17:39

Apply suggestions from code review

1fe3294

ijjk previously approved these changes Apr 20, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/canary' into feature/remove-any1

63ffabf

# Conflicts: # packages/next/next-server/server/render.tsx

ijjk dismissed their stale review via 63ffabf April 20, 2021 17:45

ijjk approved these changes Apr 20, 2021

View reviewed changes

kodiakhq bot merged commit 7fd5a24 into vercel:canary Apr 20, 2021

This comment has been minimized.

Sign in to view

tarunama deleted the feature/remove-any1 branch April 21, 2021 01:39

sync-by-unito bot mentioned this pull request May 18, 2021

chore(deps): bump next from 10.0.7 to 10.2.0 filecoin-project/slate#736

Closed

espipj reviewed Aug 24, 2021

View reviewed changes

espipj mentioned this pull request Aug 31, 2021

feat: Adding generic typing for previewData #28668

Merged

6 tasks

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add type to previewData #21574

feat: add type to previewData #21574

tarunama commented Jan 27, 2021 •

edited

ijjk commented Jan 27, 2021

Diffs

ijjk commented Jan 27, 2021

Diffs

ijjk commented Jan 30, 2021

Diffs

ijjk commented Feb 5, 2021

Diffs

ijjk commented Apr 20, 2021

This comment has been minimized.

afenton90 commented Apr 29, 2021

howells commented Apr 29, 2021

afenton90 commented Apr 30, 2021

howells commented Apr 30, 2021

espipj commented Aug 24, 2021

espipj Aug 24, 2021

ijjk commented Aug 24, 2021

espipj commented Aug 31, 2021 •

edited

feat: add type to previewData #21574

feat: add type to previewData #21574

Conversation

tarunama commented Jan 27, 2021 • edited

ijjk commented Jan 27, 2021

Stats from current PR

Diffs

ijjk commented Jan 27, 2021

Stats from current PR

Diffs

ijjk commented Jan 30, 2021

Stats from current PR

Diffs

ijjk commented Feb 5, 2021

Stats from current PR

Diffs

ijjk commented Apr 20, 2021

Stats from current PR

This comment has been minimized.

afenton90 commented Apr 29, 2021

howells commented Apr 29, 2021

afenton90 commented Apr 30, 2021

howells commented Apr 30, 2021

espipj commented Aug 24, 2021

espipj Aug 24, 2021

Choose a reason for hiding this comment

ijjk commented Aug 24, 2021

espipj commented Aug 31, 2021 • edited

tarunama commented Jan 27, 2021 •

edited

espipj commented Aug 31, 2021 •

edited