Upgrade @hapi/accept to 5.0.2 #23142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilpriverrc
requested review from
divmain,
ijjk,
lfades,
Timer and
timneutkens
as code owners
|
Thanks for the PR! For some reason a lot of deps were added, I'll close this in favor of #24283 |
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 1, 2021
Updates to the latest version of `@hapi/accept`, opening this one instead of vercel#23142 since it has unrelated changes and is stale. Close: vercel#23142 Fixes vercel#20488
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Authors of @hapi/accept have fixes issue when a user's browser is not adding the base locale, ex: "en" in the accept-language header.
Safari for example don't add "se" to my Accept-language header:
Accept-Language: sv-seCompaired to Chrome which add:
Accept-Language: sv-SE,sv;q=0.9,en-US;q=0.8,en;q=0.7This should fix the issue where some users which use ex Safari don't get redirected to correct language.