cache Mongoose connections between hot reloads #23321
Merged
+54
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
leerob
previously approved these changes
Mar 23, 2021
lfades
reviewed
Mar 23, 2021
lfades
requested changes
Mar 23, 2021
There was a problem hiding this comment.
Thank you @vkarpov15 for the PR! Requesting changes based on my suggestion above 🙏
lfades
previously approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Took the opportunity to update the readme because the deploy button is broken and it now looks good to me. Thank you @vkarpov15 !
ijjk
approved these changes
Apr 19, 2021
SokratisVidros
pushed a commit
to SokratisVidros/next.js
that referenced
this pull request
Apr 20, 2021
## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [ ] Make sure the linting passes - No, I get hundreds of unrelated errors like: ``` build/babel/plugins/next-page-config.ts(8,28): error TS2307: Cannot find module 'next/types'. build/entries.ts(11,32): error TS2307: Cannot find module '@next/env'. build/index.ts(1,31): error TS2307: Cannot find module '@next/env'. build/index.ts(9,10): error TS2305: Module '"next/dist/compiled/nanoid/index.cjs"' has no exported member 'nanoid'. ``` Re: Automattic/mongoose#9987, the current Mongoose example doesn't do a good job of persisting state between hot reloads. Not sure why Lambda doesn't keep the same `import mongoose` between reloads, but it doesn't seem to. This approach lines up more closely with [Mongoose's Lambda docs](https://mongoosejs.com/docs/lambda.html) and the existing `with-mongodb` example.
|
For some reason I'm not quite sure of, the caching code in this PR makes my lambda functions unpredictably fail around 50% lf the time on AWS using nextjs-serverless. Unfortunately, I don't have error logs (because I couldn't find a reliable logging solution). It took me about 2 hours of guessing to isolate the root cause. Sorry for the lack of details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
fixes #numberFeature
fixes #numberDocumentation / Examples
Re: Automattic/mongoose#9987, the current Mongoose example doesn't do a good job of persisting state between hot reloads. Not sure why Lambda doesn't keep the same
import mongoosebetween reloads, but it doesn't seem to. This approach lines up more closely with Mongoose's Lambda docs and the existingwith-mongodbexample.