Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade webpack to 5.28.0 #23350

Merged
merged 2 commits into from
Mar 24, 2021
Merged

upgrade webpack to 5.28.0 #23350

merged 2 commits into from
Mar 24, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 24, 2021

fixes some bugs and improves performance

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Mar 24, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 12.9s 12.8s -78ms
nodeModulesSize 61.3 MB 61.3 MB ⚠️ +3.2 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.157 2.195 ⚠️ +0.04
/ avg req/sec 1159.18 1138.96 ⚠️ -20.22
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.448 1.447 0
/error-in-render avg req/sec 1726.02 1728.02 +2
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/upgrade Change
index.html gzip 613 B 613 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 14.9s 14.7s -128ms
nodeModulesSize 61.3 MB 61.3 MB ⚠️ +3.2 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary vercel/next.js webpack/upgrade Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 15.8s 15.9s ⚠️ +53ms
nodeModulesSize 61.3 MB 61.3 MB ⚠️ +3.2 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.256 2.299 ⚠️ +0.04
/ avg req/sec 1108.21 1087.32 ⚠️ -20.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.548 1.529 -0.02
/error-in-render avg req/sec 1615.23 1635.04 +19.81
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-b5edc60..e5c2.js gzip 1.29 kB 1.29 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-3631090..4cab.js gzip 1.65 kB 1.65 kB ✓
routerDirect..20d7.js gzip 328 B 328 B ✓
withRouter-b..a4b9.js gzip 326 B 326 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 325 B 325 B ✓
Overall change 325 B 325 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/upgrade Change
index.html gzip 584 B 584 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "UgwNn9upjDM5sxNM3re7w",
+        "buildId": "hXfBMJrXQfzeLOMYqNtZT",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/UgwNn9upjDM5sxNM3re7w/_buildManifest.js"
+      src="/_next/static/hXfBMJrXQfzeLOMYqNtZT/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/UgwNn9upjDM5sxNM3re7w/_ssgManifest.js"
+      src="/_next/static/hXfBMJrXQfzeLOMYqNtZT/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "UgwNn9upjDM5sxNM3re7w",
+        "buildId": "hXfBMJrXQfzeLOMYqNtZT",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/UgwNn9upjDM5sxNM3re7w/_buildManifest.js"
+      src="/_next/static/hXfBMJrXQfzeLOMYqNtZT/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/UgwNn9upjDM5sxNM3re7w/_ssgManifest.js"
+      src="/_next/static/hXfBMJrXQfzeLOMYqNtZT/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "UgwNn9upjDM5sxNM3re7w",
+        "buildId": "hXfBMJrXQfzeLOMYqNtZT",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/UgwNn9upjDM5sxNM3re7w/_buildManifest.js"
+      src="/_next/static/hXfBMJrXQfzeLOMYqNtZT/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/UgwNn9upjDM5sxNM3re7w/_ssgManifest.js"
+      src="/_next/static/hXfBMJrXQfzeLOMYqNtZT/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: ba90391

@ijjk
Copy link
Member

ijjk commented Mar 24, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 16.8s 16.7s -31ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +3.2 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/upgrade Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.301 2.252 -0.05
/ avg req/sec 1086.5 1110.03 +23.53
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.602 1.576 -0.03
/error-in-render avg req/sec 1560.65 1586 +25.35
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-b5b29537..169f.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/upgrade Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 20.5s 20.8s ⚠️ +331ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +3.2 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-b5b29537..169f.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
_error.js 1.34 MB 1.34 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.34 MB 1.34 MB ✓
link.js 1.4 MB 1.4 MB ⚠️ +2 B
routerDirect.js 1.39 MB 1.39 MB ✓
withRouter.js 1.39 MB 1.39 MB ✓
Overall change 6.87 MB 6.87 MB ⚠️ +2 B
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
buildDuration 16.9s 17s ⚠️ +69ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +3.2 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/upgrade Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.36 2.301 -0.06
/ avg req/sec 1059.47 1086.58 +27.11
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.538 1.599 ⚠️ +0.06
/error-in-render avg req/sec 1625.32 1563.07 ⚠️ -62.25
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/upgrade Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-b5b29537..169f.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/upgrade Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/upgrade Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/upgrade Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/upgrade Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "vnMNfQLrBMgHPvidPo2ge",
+        "buildId": "3l27HrN5O5jDtUqXNxpDm",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/vnMNfQLrBMgHPvidPo2ge/_buildManifest.js"
+      src="/_next/static/3l27HrN5O5jDtUqXNxpDm/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/vnMNfQLrBMgHPvidPo2ge/_ssgManifest.js"
+      src="/_next/static/3l27HrN5O5jDtUqXNxpDm/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "vnMNfQLrBMgHPvidPo2ge",
+        "buildId": "3l27HrN5O5jDtUqXNxpDm",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/vnMNfQLrBMgHPvidPo2ge/_buildManifest.js"
+      src="/_next/static/3l27HrN5O5jDtUqXNxpDm/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/vnMNfQLrBMgHPvidPo2ge/_ssgManifest.js"
+      src="/_next/static/3l27HrN5O5jDtUqXNxpDm/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "vnMNfQLrBMgHPvidPo2ge",
+        "buildId": "3l27HrN5O5jDtUqXNxpDm",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/vnMNfQLrBMgHPvidPo2ge/_buildManifest.js"
+      src="/_next/static/3l27HrN5O5jDtUqXNxpDm/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/vnMNfQLrBMgHPvidPo2ge/_ssgManifest.js"
+      src="/_next/static/3l27HrN5O5jDtUqXNxpDm/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 991aed6

@kodiakhq kodiakhq bot merged commit 1383bbf into canary Mar 24, 2021
@kodiakhq kodiakhq bot deleted the webpack/upgrade branch March 24, 2021 13:47
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@sokra @SokratisVidros
upgrade webpack to 5.28.0 (vercel#23350)
51f2332 
fixes some bugs and improves performance

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Apr 29, 2021
@sokra
upgrade webpack to 5.28.0 (vercel#23350)
55995fc 
fixes some bugs and improves performance

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sokra @ijjk @timneutkens