Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint Plugin: Image rules #23402

Merged
merged 21 commits into from
May 17, 2021
Merged

ESLint Plugin: Image rules #23402

merged 21 commits into from
May 17, 2021

Conversation

housseindjirdeh
Copy link
Collaborator

@housseindjirdeh housseindjirdeh commented Mar 25, 2021 •
edited

Adds a new image rule to eslint-plugin-next:

Do not use `<img>`. Use Image from `next/image` instead

@ijjk

This comment has been minimized.

Sign in to view
shuding
shuding previously approved these changes Mar 26, 2021
View reviewed changes
@ijjk

This comment has been minimized.

Sign in to view
@housseindjirdeh housseindjirdeh changed the title Adds Image rules to Next.js ESLint Plugin [WIP] ESLint Plugin: Image rules May 4, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented May 6, 2021

Failing test suites

Commit: 2857d35

test/eslint-plugin-next/image-domain.unit.test.js

  • image-domain > valid external image with loader specified
  • image-domain > valid external image with domain specified
  • image-domain > invalid external image without domain specified
Expand output

● image-domain › valid external image with loader specified

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/eslint-plugin-next/custom-image/next.config1.js'

● image-domain › valid external image with domain specified

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/eslint-plugin-next/custom-image/next.config1.js'

● image-domain › invalid external image without domain specified

ENOENT: no such file or directory, open '/home/runner/work/next.js/next.js/test/eslint-plugin-next/custom-image/next.config2.js'

This was referenced May 19, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@housseindjirdeh
ESLint Plugin: Image rules (vercel#23402)
a121dd3 
Adds a new image rule to `eslint-plugin-next`:

```
Do not use `<img>`. Use Image from `next/image` instead
```
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@shuding shuding shuding left review comments

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@atcastle atcastle Awaiting requested review from atcastle

Assignees
No one assigned
Labels
type: chrome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@housseindjirdeh @ijjk @prateekbh @shuding @timneutkens @atcastle