Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ESLint with default rule-set #23702

Merged
merged 54 commits into from
Apr 30, 2021
Merged

Adds ESLint with default rule-set #23702

merged 54 commits into from
Apr 30, 2021

Conversation

housseindjirdeh
Copy link
Collaborator

@housseindjirdeh housseindjirdeh commented Apr 5, 2021 •
edited

This PR re-includes ESLint with some notable changes, namely a guided setup similar to how TypeScript is instantiated in a Next.js application.

To add ESLint to a project, developers will have to create an .eslintrc file in the root of their project or add an empty eslintConfig object to their package.json file.

touch .eslintrc

Then running next build will show instructions to install the required packages needed:

Screen Shot 2021-04-19 at 7 38 27 PM

Once installed and next build is run again, .eslintrc will be automatically configured to include the default config:

{
  "extends": "next"
}

In addition to this change:

  • The feature is now under the experimental flag and requires opt-in. After testing and feedback, it will be switched to the top-level namespace and turned on by default.
  • A new ESLint shareable configuration package is included that can be extended in any application with { extends: 'next' }
  • All rules in eslint-plugin-next have been modified to include actionable links that show more information to help resolve each issue

@ijjk ijjk added the type: next label Apr 5, 2021
@ijjk
Copy link
Member

ijjk commented Apr 5, 2021

Failing test suites

Commit: 6f28cb6

test/integration/eslint/test/index.test.js

  • ESLint > missing dependencies
Expand output

● ESLint › missing dependencies

expect(received).toContain(expected) // indexOf

Expected substring: "It looks like you're trying to use ESLint but do not have the required package(s) installed."
Received string:    "warn  - You have enabled experimental feature(s).
warn  - Experimental features are not covered by semver, and may cause unexpected or broken application behavior. Use them at your own risk.·
It looks like you're trying to use ESLint but do not have the following required package(s) installed:·
	@babel/eslint-parser·
Please install all required dependencies by running:·
	npx install-peerdeps --dev @next/eslint-config·
If you are not trying to use ESLint, please remove the .eslintrc file from your application.·
Learn more: https://nextjs.org/docs/basic-features/eslint·
"

  14 |     })
  15 |
> 16 |     expect(stderr).toContain(
     |                    ^
  17 |       `It looks like you're trying to use ESLint but do not have the required package(s) installed.`
  18 |     )
  19 |     expect(stderr).toContain('Please install all missing dependencies by running:')

  at Object.<anonymous> (integration/eslint/test/index.test.js:16:20)

@ijjk
Copy link
Member

ijjk commented Apr 5, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 12.6s 12.6s ⚠️ +33ms
nodeModulesSize 45.9 MB 46.6 MB ⚠️ +619 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.285 2.296 ⚠️ +0.01
/ avg req/sec 1094.15 1088.81 ⚠️ -5.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.444 1.474 ⚠️ +0.03
/error-in-render avg req/sec 1731.09 1696.08 ⚠️ -35.01
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 370 B 370 B ✓
Overall change 370 B 370 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 15.4s 14.5s -849ms
nodeModulesSize 45.9 MB 46.6 MB ⚠️ +619 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 370 B 370 B ✓
Overall change 370 B 370 B ✓
Serverless bundles
vercel/next.js canary housseindjirdeh/next.js eslint Change
_error.js 1.36 MB 1.36 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.36 MB 1.36 MB ✓
link.js 1.42 MB 1.42 MB ✓
routerDirect.js 1.41 MB 1.41 MB ✓
withRouter.js 1.41 MB 1.41 MB ✓
Overall change 6.99 MB 6.99 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 14.9s 15.1s ⚠️ +172ms
nodeModulesSize 45.9 MB 46.6 MB ⚠️ +619 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.302 2.27 -0.03
/ avg req/sec 1085.87 1101.54 +15.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.581 1.541 -0.04
/error-in-render avg req/sec 1581.39 1622.09 +40.7
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-e27c5352..db8c.js gzip 13.3 kB 13.3 kB ✓
778-a8e7432f..6391.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 610 B 610 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "_DdzZVjuNbMkMw3iaRgTt",
+        "buildId": "X0CCtQTCLsd0YpNjz_8Qv",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/_DdzZVjuNbMkMw3iaRgTt/_buildManifest.js"
+      src="/_next/static/X0CCtQTCLsd0YpNjz_8Qv/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/_DdzZVjuNbMkMw3iaRgTt/_ssgManifest.js"
+      src="/_next/static/X0CCtQTCLsd0YpNjz_8Qv/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "_DdzZVjuNbMkMw3iaRgTt",
+        "buildId": "X0CCtQTCLsd0YpNjz_8Qv",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/_DdzZVjuNbMkMw3iaRgTt/_buildManifest.js"
+      src="/_next/static/X0CCtQTCLsd0YpNjz_8Qv/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/_DdzZVjuNbMkMw3iaRgTt/_ssgManifest.js"
+      src="/_next/static/X0CCtQTCLsd0YpNjz_8Qv/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "_DdzZVjuNbMkMw3iaRgTt",
+        "buildId": "X0CCtQTCLsd0YpNjz_8Qv",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/_DdzZVjuNbMkMw3iaRgTt/_buildManifest.js"
+      src="/_next/static/X0CCtQTCLsd0YpNjz_8Qv/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/_DdzZVjuNbMkMw3iaRgTt/_ssgManifest.js"
+      src="/_next/static/X0CCtQTCLsd0YpNjz_8Qv/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 6f28cb6

@ijjk
Copy link
Member

ijjk commented Apr 5, 2021

Failing test suites

Commit: a7d3c5d

test/integration/eslint/test/index.test.js

  • ESLint > missing dependencies
Expand output

● ESLint › missing dependencies

expect(received).toContain(expected) // indexOf

Expected substring: "It looks like you're trying to use ESLint but do not have the required package(s) installed."
Received string:    "warn  - You have enabled experimental feature(s).
warn  - Experimental features are not covered by semver, and may cause unexpected or broken application behavior. Use them at your own risk.·
It looks like you're trying to use ESLint but do not have the following required package(s) installed:·
	@babel/eslint-parser·
Please install all required dependencies by running:·
	npx install-peerdeps --dev @next/eslint-config·
If you are not trying to use ESLint, please remove the .eslintrc file from your application.·
Learn more: https://nextjs.org/docs/basic-features/eslint·
"

  14 |     })
  15 |
> 16 |     expect(stderr).toContain(
     |                    ^
  17 |       `It looks like you're trying to use ESLint but do not have the required package(s) installed.`
  18 |     )
  19 |     expect(stderr).toContain('Please install all missing dependencies by running:')

  at Object.<anonymous> (integration/eslint/test/index.test.js:16:20)

@ijjk
Copy link
Member

ijjk commented Apr 5, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 12.7s 12.9s ⚠️ +221ms
nodeModulesSize 45.9 MB 46.6 MB ⚠️ +619 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.783 2.776 -0.01
/ avg req/sec 898.22 900.43 +2.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.649 1.61 -0.04
/error-in-render avg req/sec 1516.48 1552.82 +36.34
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 14.7s 14.4s -225ms
nodeModulesSize 45.9 MB 46.6 MB ⚠️ +619 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Serverless bundles
vercel/next.js canary housseindjirdeh/next.js eslint Change
_error.js 1.37 MB 1.37 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.37 MB 1.37 MB ✓
link.js 1.42 MB 1.42 MB ✓
routerDirect.js 1.42 MB 1.42 MB ✓
withRouter.js 1.42 MB 1.42 MB ✓
Overall change 7 MB 7 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 15.1s 15.6s ⚠️ +441ms
nodeModulesSize 45.9 MB 46.6 MB ⚠️ +619 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.76 2.824 ⚠️ +0.06
/ avg req/sec 905.71 885.11 ⚠️ -20.6
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.584 1.538 -0.05
/error-in-render avg req/sec 1578.04 1625.77 +47.73
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-e27c5352..db8c.js gzip 13.3 kB 13.3 kB ✓
778-a8e7432f..6391.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "2JNCI9lWIhde5mUr6tmvd",
+        "buildId": "77HCjWofzyX2N08Qj30lM",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/2JNCI9lWIhde5mUr6tmvd/_buildManifest.js"
+      src="/_next/static/77HCjWofzyX2N08Qj30lM/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/2JNCI9lWIhde5mUr6tmvd/_ssgManifest.js"
+      src="/_next/static/77HCjWofzyX2N08Qj30lM/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "2JNCI9lWIhde5mUr6tmvd",
+        "buildId": "77HCjWofzyX2N08Qj30lM",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/2JNCI9lWIhde5mUr6tmvd/_buildManifest.js"
+      src="/_next/static/77HCjWofzyX2N08Qj30lM/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/2JNCI9lWIhde5mUr6tmvd/_ssgManifest.js"
+      src="/_next/static/77HCjWofzyX2N08Qj30lM/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "2JNCI9lWIhde5mUr6tmvd",
+        "buildId": "77HCjWofzyX2N08Qj30lM",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/2JNCI9lWIhde5mUr6tmvd/_buildManifest.js"
+      src="/_next/static/77HCjWofzyX2N08Qj30lM/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/2JNCI9lWIhde5mUr6tmvd/_ssgManifest.js"
+      src="/_next/static/77HCjWofzyX2N08Qj30lM/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: a7d3c5d

@ijjk
Copy link
Member

ijjk commented Apr 5, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 12.3s 12.4s ⚠️ +38ms
nodeModulesSize 45.9 MB 46 MB ⚠️ +39 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.52 2.584 ⚠️ +0.06
/ avg req/sec 992.16 967.46 ⚠️ -24.7
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.349 1.407 ⚠️ +0.06
/error-in-render avg req/sec 1853.11 1777.04 ⚠️ -76.07
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 613 B 613 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 14.3s 14.4s ⚠️ +47ms
nodeModulesSize 45.9 MB 46 MB ⚠️ +39 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Serverless bundles
vercel/next.js canary housseindjirdeh/next.js eslint Change
_error.js 1.37 MB 1.37 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.37 MB 1.37 MB ✓
link.js 1.42 MB 1.42 MB ✓
routerDirect.js 1.42 MB 1.42 MB ✓
withRouter.js 1.42 MB 1.42 MB ✓
Overall change 7 MB 7 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 14.5s 15s ⚠️ +481ms
nodeModulesSize 45.9 MB 46 MB ⚠️ +39 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.594 2.635 ⚠️ +0.04
/ avg req/sec 963.82 948.92 ⚠️ -14.9
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.366 1.379 ⚠️ +0.01
/error-in-render avg req/sec 1830.27 1813.1 ⚠️ -17.17
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-e27c5352..db8c.js gzip 13.3 kB 13.3 kB ✓
778-2fdd7b63..cd87.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 609 B 609 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "J0gPfe72Xr0CiIERcywPi",
+        "buildId": "voxNruY-mheGHMYEPVkAV",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/J0gPfe72Xr0CiIERcywPi/_buildManifest.js"
+      src="/_next/static/voxNruY-mheGHMYEPVkAV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/J0gPfe72Xr0CiIERcywPi/_ssgManifest.js"
+      src="/_next/static/voxNruY-mheGHMYEPVkAV/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "J0gPfe72Xr0CiIERcywPi",
+        "buildId": "voxNruY-mheGHMYEPVkAV",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/J0gPfe72Xr0CiIERcywPi/_buildManifest.js"
+      src="/_next/static/voxNruY-mheGHMYEPVkAV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/J0gPfe72Xr0CiIERcywPi/_ssgManifest.js"
+      src="/_next/static/voxNruY-mheGHMYEPVkAV/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "J0gPfe72Xr0CiIERcywPi",
+        "buildId": "voxNruY-mheGHMYEPVkAV",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/J0gPfe72Xr0CiIERcywPi/_buildManifest.js"
+      src="/_next/static/voxNruY-mheGHMYEPVkAV/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/J0gPfe72Xr0CiIERcywPi/_ssgManifest.js"
+      src="/_next/static/voxNruY-mheGHMYEPVkAV/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 80808a0

@ijjk
Copy link
Member

ijjk commented Apr 22, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 17.4s 17.7s ⚠️ +350ms
buildDurationCached 5.7s 5.3s -391ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.938 2.896 -0.04
/ avg req/sec 851.05 863.22 +12.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.84 1.847 ⚠️ +0.01
/error-in-render avg req/sec 1358.38 1353.41 ⚠️ -4.97
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 610 B 610 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 22.2s 22.5s ⚠️ +280ms
buildDurationCached 8s 7.9s -108ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
_error.js 1.39 MB 1.39 MB ⚠️ +2 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ⚠️ +2 B
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB ⚠️ +4 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 14.7s 14.8s ⚠️ +153ms
buildDurationCached 6.3s 6.1s -284ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.938 2.894 -0.04
/ avg req/sec 850.96 863.95 +12.99
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.876 1.85 -0.03
/error-in-render avg req/sec 1332.71 1351.7 +18.99
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: e1bdcb7

@ijjk
Copy link
Member

ijjk commented Apr 22, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 14.2s 14s -123ms
buildDurationCached 4.6s 4.2s -379ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.423 2.384 -0.04
/ avg req/sec 1031.94 1048.87 +16.93
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.268 1.243 -0.02
/error-in-render avg req/sec 1971.92 2010.83 +38.91
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 610 B 610 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 17s 16.1s -919ms
buildDurationCached 6.1s 6s -45ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles
vercel/next.js canary housseindjirdeh/next.js eslint Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB ✓
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 10.9s 11.3s ⚠️ +357ms
buildDurationCached 4.5s 4.5s ⚠️ +13ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.241 2.216 -0.02
/ avg req/sec 1115.44 1127.9 +12.46
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.178 1.158 -0.02
/error-in-render avg req/sec 2123.09 2158.37 +35.28
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: df68057

@ijjk
Copy link
Member

ijjk commented Apr 23, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 15.1s 15.3s ⚠️ +193ms
buildDurationCached 5s 4.6s -404ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.691 2.689 0
/ avg req/sec 929.18 929.69 +0.51
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.425 1.518 ⚠️ +0.09
/error-in-render avg req/sec 1754.93 1646.4 ⚠️ -108.53
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 610 B 610 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 18.8s 19s ⚠️ +227ms
buildDurationCached 6.9s 7.3s ⚠️ +325ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ⚠️ +2 B
Overall change 7.14 MB 7.14 MB ⚠️ +2 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 13.3s 13.8s ⚠️ +494ms
buildDurationCached 5.9s 5.4s -462ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.766 2.674 -0.09
/ avg req/sec 903.8 934.92 +31.12
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.59 1.609 ⚠️ +0.02
/error-in-render avg req/sec 1572.64 1553.75 ⚠️ -18.89
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 5b7f42e

@ijjk
Copy link
Member

ijjk commented Apr 26, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 16.6s 15.8s -790ms
buildDurationCached 5.5s 5.1s -444ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.965 2.813 -0.15
/ avg req/sec 843.18 888.65 +45.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.67 1.638 -0.03
/error-in-render avg req/sec 1497.42 1526.58 +29.16
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 611 B 611 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 19.7s 19.9s ⚠️ +194ms
buildDurationCached 7.5s 7.5s -21ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ⚠️ +2 B
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB ⚠️ +2 B
Webpack 4 Mode
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 14s 13.7s -334ms
buildDurationCached 5.5s 5.7s ⚠️ +166ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.849 2.874 ⚠️ +0.02
/ avg req/sec 877.42 869.97 ⚠️ -7.45
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.663 1.654 -0.01
/error-in-render avg req/sec 1503.47 1511.27 +7.8
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: f0954de

@ijjk
Copy link
Member

ijjk commented Apr 26, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 13.8s 14s ⚠️ +166ms
buildDurationCached 4.6s 4.4s -243ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.405 2.389 -0.02
/ avg req/sec 1039.32 1046.61 +7.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.227 1.233 ⚠️ +0.01
/error-in-render avg req/sec 2036.93 2027.44 ⚠️ -9.49
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 611 B 611 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 17.1s 17.3s ⚠️ +165ms
buildDurationCached 6.5s 6.5s -49ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB -2 B
link.js 1.45 MB 1.45 MB -2 B
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ✓
Overall change 7.14 MB 7.14 MB -4 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 12s 12s -19ms
buildDurationCached 4.9s 5s ⚠️ +64ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.374 2.363 -0.01
/ avg req/sec 1053.04 1057.94 +4.9
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.2 1.218 ⚠️ +0.02
/error-in-render avg req/sec 2082.7 2052.53 ⚠️ -30.17
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 1f12e96

@ijjk
Copy link
Member

ijjk commented Apr 29, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 15.5s 15.8s ⚠️ +271ms
buildDurationCached 5.1s 4.8s -263ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.683 2.731 ⚠️ +0.05
/ avg req/sec 931.81 915.39 ⚠️ -16.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.539 1.577 ⚠️ +0.04
/error-in-render avg req/sec 1624.55 1585.29 ⚠️ -39.26
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.11 kB 7.11 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 19.6s 19.2s -485ms
buildDurationCached 7.1s 7.2s ⚠️ +89ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.11 kB 7.11 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
_error.js 1.35 MB 1.35 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.35 MB 1.35 MB -2 B
link.js 1.4 MB 1.4 MB ⚠️ +2 B
routerDirect.js 1.4 MB 1.4 MB -4 B
withRouter.js 1.4 MB 1.4 MB ✓
Overall change 6.91 MB 6.91 MB -4 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 13.3s 13.3s ⚠️ +43ms
buildDurationCached 5.6s 5.5s -149ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.767 2.732 -0.03
/ avg req/sec 903.37 914.97 +11.6
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.568 1.632 ⚠️ +0.06
/error-in-render avg req/sec 1594.82 1531.96 ⚠️ -62.86
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.18 kB 7.18 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 613 B 613 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: c3195e0

@ijjk
Copy link
Member

ijjk commented Apr 29, 2021

Failing test suites

Commit: c3195e0

test/integration/eslint/test/index.test.js

  • ESLint > shows warnings and errors
Expand output

● ESLint › shows warnings and errors

expect(received).toContain(expected) // indexOf

Expected substring: "Warning: In order to use external stylesheets use @import in the root stylesheet compiled with Next"
Received string:    "info  - Using webpack 5. Reason: no custom webpack configuration in next.config.js https://nextjs.org/docs/messages/webpack5
info  - Checking validity of types...
warn  - You have enabled experimental feature(s).
warn  - Experimental features are not covered by semver, and may cause unexpected or broken application behavior. Use them at your own risk.··
Failed to compile.·
./pages/index.js
3:16  Error: Comments inside children section of tag should be placed inside braces  react/jsx-no-comment-textnodes
5:5  Warning: Do not include stylesheets manually. See: https://nextjs.org/docs/messages/no-css-tags.  @next/next/no-css-tags·
"

  61 |     } else {
  62 |       expect(output).toContain('Failed to compile')
> 63 |       expect(output).toContain(
     |                      ^
  64 |         `Warning: In order to use external stylesheets use @import in the root stylesheet compiled with Next`
  65 |       )
  66 |       expect(output).toContain(

  at Object.<anonymous> (integration/eslint/test/index.test.js:63:22)

@ijjk
Copy link
Member

ijjk commented Apr 29, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 11.4s 11.6s ⚠️ +279ms
buildDurationCached 3.8s 3.5s -237ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.7 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.048 1.939 -0.11
/ avg req/sec 1220.8 1289.08 +68.28
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.075 1.026 -0.05
/error-in-render avg req/sec 2324.67 2436.49 +111.82
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 608 B 608 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 14.5s 14.1s -314ms
buildDurationCached 6s 5.3s -669ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
_error.js 1.35 MB 1.35 MB ⚠️ +4 B
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.35 MB 1.35 MB ✓
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.4 MB 1.4 MB ✓
withRouter.js 1.4 MB 1.4 MB ✓
Overall change 6.91 MB 6.91 MB ⚠️ +4 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 10.1s 9.6s -515ms
buildDurationCached 4s 4.5s ⚠️ +492ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.857 1.993 ⚠️ +0.14
/ avg req/sec 1346.11 1254.49 ⚠️ -91.62
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 0.974 1.141 ⚠️ +0.17
/error-in-render avg req/sec 2565.73 2191.49 ⚠️ -374.24
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 51c8aa9

@ijjk
Copy link
Member

ijjk commented Apr 29, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 16.7s 16.5s -201ms
buildDurationCached 5.3s 5s -262ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.908 2.849 -0.06
/ avg req/sec 859.78 877.4 +17.62
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.696 1.729 ⚠️ +0.03
/error-in-render avg req/sec 1473.79 1446.26 ⚠️ -27.53
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 608 B 608 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 20.2s 20.7s ⚠️ +483ms
buildDurationCached 7.4s 7.5s ⚠️ +80ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles
vercel/next.js canary housseindjirdeh/next.js eslint Change
_error.js 1.35 MB 1.35 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.35 MB 1.35 MB ✓
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.4 MB 1.4 MB ✓
withRouter.js 1.4 MB 1.4 MB ✓
Overall change 6.91 MB 6.91 MB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 13.8s 13.8s ⚠️ +28ms
buildDurationCached 5.9s 5.5s -337ms
nodeModulesSize 46.6 MB 46.7 MB ⚠️ +97.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.891 2.873 -0.02
/ avg req/sec 864.73 870.16 +5.43
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.645 1.719 ⚠️ +0.07
/error-in-render avg req/sec 1519.49 1454.4 ⚠️ -65.09
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 2a81a5c

@ijjk
Copy link
Member

ijjk commented Apr 30, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 12.8s 12.6s -170ms
buildDurationCached 4.4s 3.9s -507ms
nodeModulesSize 46.5 MB 46.6 MB ⚠️ +97.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.234 2.242 ⚠️ +0.01
/ avg req/sec 1118.89 1115.16 ⚠️ -3.73
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.164 1.228 ⚠️ +0.06
/error-in-render avg req/sec 2147.61 2035.52 ⚠️ -112.09
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 611 B 611 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 16s 15.8s -250ms
buildDurationCached 5.9s 6.4s ⚠️ +553ms
nodeModulesSize 46.5 MB 46.6 MB ⚠️ +97.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
597-HASH.js gzip 13.2 kB 13.2 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles
vercel/next.js canary housseindjirdeh/next.js eslint Change
_error.js 1.35 MB 1.35 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.35 MB 1.35 MB ✓
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.4 MB 1.4 MB ✓
withRouter.js 1.4 MB 1.4 MB ✓
Overall change 6.91 MB 6.91 MB ✓
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary housseindjirdeh/next.js eslint Change
buildDuration 11.8s 11.9s ⚠️ +62ms
buildDurationCached 5s 4.8s -180ms
nodeModulesSize 46.5 MB 46.6 MB ⚠️ +97.7 kB
Page Load Tests Overall increase ✓
vercel/next.js canary housseindjirdeh/next.js eslint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.414 2.424 ⚠️ +0.01
/ avg req/sec 1035.83 1031.47 ⚠️ -4.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.314 1.274 -0.04
/error-in-render avg req/sec 1902.41 1962.49 +60.08
Client Bundles (main, webpack, commons)
vercel/next.js canary housseindjirdeh/next.js eslint Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary housseindjirdeh/next.js eslint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary housseindjirdeh/next.js eslint Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary housseindjirdeh/next.js eslint Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary housseindjirdeh/next.js eslint Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 01462a1

@kodiakhq kodiakhq bot merged commit e783b0a into vercel:canary Apr 30, 2021
@glenarama
Copy link

When following the instructions the wrong dependancy gets installed:
yarn add --dev eslint eslint-config-next

installs: https://www.npmjs.com/package/eslint-config-nextjs which is outdated.

rather than @next/eslint-plugin-next

Which i believe is the correct one.
Installing @next/eslint-plugin-next instead fails and does not lint.

I'll close the issue on the main repository - this seems the correct place to discuss.

@timneutkens
Copy link
Member

It's https://npmjs.com/eslint-config-next which is correctly published on the canary tag currently (see versions tab).

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@housseindjirdeh
Adds ESLint with default rule-set (vercel#23702)
4139c1d 
This PR re-includes ESLint with some notable changes, namely a guided setup similar to how TypeScript is instantiated in a Next.js application.

To add ESLint to a project, developers will have to create an `.eslintrc` file in the root of their project or add an empty `eslintConfig` object to their `package.json` file.

```js
touch .eslintrc
```

Then running `next build` will show instructions to install the required packages needed:

<img width="862" alt="Screen Shot 2021-04-19 at 7 38 27 PM" src="https://user-images.githubusercontent.com/12476932/115316182-dfd51b00-a146-11eb-830c-90bad20ed151.png">

Once installed and `next build` is run again, `.eslintrc` will be automatically configured to include the default config:

```json
{
  "extends": "next"
}
```

In addition to this change:

- The feature is now under the experimental flag and requires opt-in. After testing and feedback, it will be switched to the top-level namespace and turned on by default.
- A new ESLint shareable configuration package is included that can be extended in any application with `{ extends: 'next' }`
  - This default config extends recommended rule sets from [`eslint-plugin-react`](https://www.npmjs.com/package/eslint-plugin-react), [`eslint-plugin-react-hooks`](https://www.npmjs.com/package/eslint-plugin-react-hooks), and [`eslint-plugin-next`](https://www.npmjs.com/package/@next/eslint-plugin-next)
- All rules in [`eslint-plugin-next`](https://www.npmjs.com/package/@next/eslint-plugin-next) have been modified to include actionable links that show more information to help resolve each issue
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@merceyz merceyz merceyz requested changes

@ijjk ijjk ijjk left review comments

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@Timer Timer Awaiting requested review from Timer

@leerob leerob Awaiting requested review from leerob leerob is a code owner

Assignees
No one assigned
Labels
examples Issue/PR related to examples type: chrome type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@housseindjirdeh @ijjk @merceyz @timneutkens @glenarama