Fix typescript types. #23771
Merged
Fix typescript types. #23771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typescript type for cache and null check in mutation result.
sahilrajput03
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
|
What is the status of this PR? |
leerob
previously approved these changes
Apr 15, 2021
|
@leerob , I fixed the formatting in a new commit, please review it so this can be merged finally. |
leerob
approved these changes
Apr 15, 2021
|
Great!! Thats real fast merge, the ci is developed in a pretty efficient and powerful way! |
SokratisVidros
pushed a commit
to SokratisVidros/next.js
that referenced
this pull request
Apr 20, 2021
Fix typescript type for cache and null check in mutation result. ## Bug - fixes : vercel#23770 **That issue deals with -** - Return the codeflow if data is not returned from the mutation, and that fixes this warning.  - Supply typescript typings for the target cache object.  Thanks.!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typescript type for cache and null check in mutation result.
Bug
That issue deals with -
Return the codeflow if data is not returned from the mutation, and that fixes this warning.
Supply typescript typings for the target cache object.
Thanks.!