Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade webpack to 5.31.2 #23861

Merged
merged 2 commits into from
Apr 9, 2021
Merged

upgrade webpack to 5.31.2 #23861

merged 2 commits into from
Apr 9, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 9, 2021 •
edited

https://github.com/webpack/webpack/releases/tag/v5.31.1

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the type: next label Apr 9, 2021
@ijjk
Copy link
Member

ijjk commented Apr 9, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
buildDuration 10.3s 10.3s ⚠️ +24ms
nodeModulesSize 46.7 MB 46.7 MB -13.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.096 2.105 ⚠️ +0.01
/ avg req/sec 1192.69 1187.66 ⚠️ -5.03
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.101 1.125 ⚠️ +0.02
/error-in-render avg req/sec 2269.96 2221.81 ⚠️ -48.15
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
677f882d2ed8..e6c6.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
buildDuration 12.1s 11.9s -200ms
nodeModulesSize 46.7 MB 46.7 MB -13.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
677f882d2ed8..e6c6.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Serverless bundles
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_error.js 1.37 MB 1.37 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.37 MB 1.37 MB ✓
link.js 1.42 MB 1.42 MB ✓
routerDirect.js 1.42 MB 1.42 MB ✓
withRouter.js 1.42 MB 1.42 MB ✓
Overall change 7.01 MB 7.01 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
buildDuration 12.2s 12.3s ⚠️ +142ms
nodeModulesSize 46.7 MB 46.7 MB -13.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.142 2.142 ✓
/ avg req/sec 1167.12 1167.32 +0.2
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.142 1.146 0
/error-in-render avg req/sec 2189.91 2182.34 ⚠️ -7.57
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9356d64c..e712.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "vqdbpjOSLm6Cr3e1zFN0F",
+        "buildId": "SLcuq1P7dqQPHPenjK6tD",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/vqdbpjOSLm6Cr3e1zFN0F/_buildManifest.js"
+      src="/_next/static/SLcuq1P7dqQPHPenjK6tD/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/vqdbpjOSLm6Cr3e1zFN0F/_ssgManifest.js"
+      src="/_next/static/SLcuq1P7dqQPHPenjK6tD/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "vqdbpjOSLm6Cr3e1zFN0F",
+        "buildId": "SLcuq1P7dqQPHPenjK6tD",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/vqdbpjOSLm6Cr3e1zFN0F/_buildManifest.js"
+      src="/_next/static/SLcuq1P7dqQPHPenjK6tD/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/vqdbpjOSLm6Cr3e1zFN0F/_ssgManifest.js"
+      src="/_next/static/SLcuq1P7dqQPHPenjK6tD/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "vqdbpjOSLm6Cr3e1zFN0F",
+        "buildId": "SLcuq1P7dqQPHPenjK6tD",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/vqdbpjOSLm6Cr3e1zFN0F/_buildManifest.js"
+      src="/_next/static/SLcuq1P7dqQPHPenjK6tD/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/vqdbpjOSLm6Cr3e1zFN0F/_ssgManifest.js"
+      src="/_next/static/SLcuq1P7dqQPHPenjK6tD/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 8ef52f3

timneutkens
timneutkens previously approved these changes Apr 9, 2021
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Apr 9, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
buildDuration 12.3s 12.1s -181ms
nodeModulesSize 46.7 MB 46.7 MB -14.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.426 2.449 ⚠️ +0.02
/ avg req/sec 1030.57 1021.02 ⚠️ -9.55
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.229 1.263 ⚠️ +0.03
/error-in-render avg req/sec 2034.06 1979.23 ⚠️ -54.83
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
677f882d2ed8..e6c6.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
buildDuration 14.1s 14.2s ⚠️ +85ms
nodeModulesSize 46.7 MB 46.7 MB -14.1 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
677f882d2ed8..e6c6.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.12 kB 7.12 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-d07ca..ef4d.js gzip 3.71 kB 3.71 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.89 kB 8.89 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_buildManifest.js gzip 371 B 371 B ✓
Overall change 371 B 371 B ✓
Serverless bundles
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_error.js 1.37 MB 1.37 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.7 kB 10.7 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.37 MB 1.37 MB ✓
link.js 1.42 MB 1.42 MB ✓
routerDirect.js 1.42 MB 1.42 MB ✓
withRouter.js 1.42 MB 1.42 MB ✓
Overall change 7.01 MB 7.01 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
buildDuration 14s 14.3s ⚠️ +314ms
nodeModulesSize 46.7 MB 46.7 MB -14.1 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.476 2.478 0
/ avg req/sec 1009.86 1008.69 ⚠️ -1.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.321 1.283 -0.04
/error-in-render avg req/sec 1892.35 1947.96 +55.61
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
597-3f457946..288d.js gzip 13.3 kB 13.3 kB ✓
778-9356d64c..e712.js gzip 7.05 kB 7.05 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-55112..054d.js gzip 3.68 kB 3.68 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 9.03 kB 9.03 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js webpack/5.31.1 Change
index.html gzip 610 B 610 B ✓
link.html gzip 616 B 616 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "XK-YIIf56n6fnXUe-t2V3",
+        "buildId": "XRUNMK4mrb6ivemLxHQ9P",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/XK-YIIf56n6fnXUe-t2V3/_buildManifest.js"
+      src="/_next/static/XRUNMK4mrb6ivemLxHQ9P/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/XK-YIIf56n6fnXUe-t2V3/_ssgManifest.js"
+      src="/_next/static/XRUNMK4mrb6ivemLxHQ9P/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "XK-YIIf56n6fnXUe-t2V3",
+        "buildId": "XRUNMK4mrb6ivemLxHQ9P",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/XK-YIIf56n6fnXUe-t2V3/_buildManifest.js"
+      src="/_next/static/XRUNMK4mrb6ivemLxHQ9P/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/XK-YIIf56n6fnXUe-t2V3/_ssgManifest.js"
+      src="/_next/static/XRUNMK4mrb6ivemLxHQ9P/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "XK-YIIf56n6fnXUe-t2V3",
+        "buildId": "XRUNMK4mrb6ivemLxHQ9P",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/XK-YIIf56n6fnXUe-t2V3/_buildManifest.js"
+      src="/_next/static/XRUNMK4mrb6ivemLxHQ9P/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/XK-YIIf56n6fnXUe-t2V3/_ssgManifest.js"
+      src="/_next/static/XRUNMK4mrb6ivemLxHQ9P/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 26e9714

@sokra sokra changed the title upgrade webpack to 5.31.1 upgrade webpack to 5.31.2 Apr 9, 2021
@kodiakhq kodiakhq bot merged commit 1258d13 into canary Apr 9, 2021
@kodiakhq kodiakhq bot deleted the webpack/5.31.1 branch April 9, 2021 18:31
SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@sokra @SokratisVidros
upgrade webpack to 5.31.2 (vercel#23861)
798c477 
https://github.com/webpack/webpack/releases/tag/v5.31.1

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@sync-by-unito sync-by-unito bot mentioned this pull request May 18, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens timneutkens left review comments

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sokra @ijjk @timneutkens