Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for with-clerk example #24324

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Fix for with-clerk example #24324

merged 1 commit into from
Apr 21, 2021

Conversation

SokratisVidros
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

The predev npm script assumes that vercel cli is installed. It's better for the example to run without it.

@SokratisVidros
Remove predev npm script from with-clerk example
3369300 
The predev npm script assumes that vercel cli is installed. It's better for the example to run without it.
@ijjk ijjk added the examples Issue/PR related to examples label Apr 21, 2021
leerob
leerob approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kodiakhq kodiakhq bot merged commit e89a080 into vercel:canary Apr 21, 2021
@SokratisVidros SokratisVidros deleted the fix_for_with_clerk_example branch April 21, 2021 19:28
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SokratisVidros @leerob @ijjk