Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not exposing server errors in hot reloader #24331

Merged
merged 3 commits into from Apr 22, 2021
Merged

Fix not exposing server errors in hot reloader #24331

merged 3 commits into from Apr 22, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Apr 21, 2021

Fixes #24056.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Apr 21, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
buildDuration 16.2s 16.2s ⚠️ +59ms
buildDurationCached 5.3s 5s -340ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +1.38 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.895 2.936 ⚠️ +0.04
/ avg req/sec 863.7 851.49 ⚠️ -12.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.757 1.693 -0.06
/error-in-render avg req/sec 1423.11 1476.69 +53.58
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
index.html gzip 610 B 610 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
buildDuration 20.3s 19.9s -358ms
buildDurationCached 7.5s 7.4s -106ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +1.38 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB -2 B
Overall change 7.15 MB 7.15 MB -2 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
buildDuration 13.7s 13.3s -351ms
buildDurationCached 5.9s 5.7s -212ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +1.38 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.861 2.851 -0.01
/ avg req/sec 873.7 876.84 +3.14
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.726 1.763 ⚠️ +0.04
/error-in-render avg req/sec 1448.53 1417.86 ⚠️ -30.67
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.2 kB 7.2 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
index.html gzip 612 B 612 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 144bb4f

@shuding shuding marked this pull request as ready for review April 22, 2021 10:45
timneutkens
timneutkens previously approved these changes Apr 22, 2021
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Apr 22, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
buildDuration 14.2s 14.2s -17ms
buildDurationCached 4.6s 4.4s -226ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +1.38 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.369 2.426 ⚠️ +0.06
/ avg req/sec 1055.24 1030.31 ⚠️ -24.93
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.214 1.262 ⚠️ +0.05
/error-in-render avg req/sec 2059.18 1980.33 ⚠️ -78.85
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
buildDuration 17.3s 17.3s -26ms
buildDurationCached 6.6s 6.6s -54ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +1.38 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
597-HASH.js gzip 13.3 kB 13.3 kB ✓
778-HASH.js gzip 7.12 kB 7.12 kB ✓
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_app-HASH.js gzip 1.3 kB 1.3 kB ✓
_error-HASH.js gzip 3.68 kB 3.68 kB ✓
amp-HASH.js gzip 558 B 558 B ✓
css-HASH.js gzip 363 B 363 B ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 243 B 243 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 336 B 336 B ✓
withRouter-HASH.js gzip 334 B 334 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 9.52 kB 9.52 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_buildManifest.js gzip 390 B 390 B ✓
Overall change 390 B 390 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_error.js 1.39 MB 1.39 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.96 kB 1.96 kB ✓
css.html 2.13 kB 2.13 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.39 MB 1.39 MB ✓
link.js 1.45 MB 1.45 MB ✓
routerDirect.js 1.44 MB 1.44 MB ✓
withRouter.js 1.44 MB 1.44 MB ⚠️ +2 B
Overall change 7.15 MB 7.15 MB ⚠️ +2 B
Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
buildDuration 12s 12.2s ⚠️ +177ms
buildDurationCached 5s 4.9s -92ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +1.38 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.376 2.444 ⚠️ +0.07
/ avg req/sec 1052.21 1022.87 ⚠️ -29.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.265 1.22 -0.04
/error-in-render avg req/sec 1976.29 2048.38 +72.09
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
677f882d2ed8..HASH.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.2 kB 7.2 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
_buildManifest.js gzip 419 B 419 B ✓
Overall change 419 B 419 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js fix-not-exposing-server-errors Change
index.html gzip 611 B 611 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 605 B 605 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: adbe457

@kodiakhq kodiakhq bot merged commit 6cd1c87 into vercel:canary Apr 22, 2021
@shuding shuding deleted the fix-not-exposing-server-errors branch April 22, 2021 12:18
@shuding shuding mentioned this pull request Apr 22, 2021
Closed
8 tasks
This was referenced Apr 28, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 28, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in server compilation result in a 404 instead of showing the error overlay
3 participants
@shuding @ijjk @timneutkens