Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type checking events #24595

Merged
merged 2 commits into from
May 4, 2021
Merged

Add type checking events #24595

merged 2 commits into from
May 4, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 29, 2021

Will send events like this:

[telemetry] {
  "eventName": "NEXT_TYPE_CHECK_COMPLETED",
  "payload": {
    "durationInSeconds": 2,
    "typescriptVersion": "3.8.3",
    "inputFilesCount": 16,
    "totalFilesCount": 289,
    "incremental": false
  }
}

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk

This comment has been minimized.

Sign in to view
@timneutkens timneutkens changed the title add telemetry to type checking Add type checking events Apr 29, 2021
@sokra
Copy link
Member Author

sokra commented May 3, 2021 •
edited

https://github.com/vercel/next-telemetry/pull/44 has been merged. Could we merge this one now? @Timer

@ijjk
Copy link
Member

ijjk commented May 3, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/trace-type-check Change
buildDuration 12.4s 12.4s -39ms
buildDurationCached 4.1s 3.8s -269ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +4.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feature/trace-type-check Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.053 2.051 0
/ avg req/sec 1217.92 1219.03 +1.11
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.083 1.107 ⚠️ +0.02
/error-in-render avg req/sec 2307.85 2258.27 ⚠️ -49.58
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/trace-type-check Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.3 kB 19.3 kB ✓
webpack-HASH.js gzip 996 B 996 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/trace-type-check Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feature/trace-type-check Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.04 kB 3.04 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.51 kB 8.51 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feature/trace-type-check Change
_buildManifest.js gzip 393 B 393 B ✓
Overall change 393 B 393 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js feature/trace-type-check Change
index.html gzip 561 B 561 B ✓
link.html gzip 570 B 570 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/trace-type-check Change
buildDuration 15.2s 15.2s -43ms
buildDurationCached 5.8s 5.8s -76ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +4.1 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/trace-type-check Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.3 kB 19.3 kB ✓
webpack-HASH.js gzip 996 B 996 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/trace-type-check Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feature/trace-type-check Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.04 kB 3.04 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.51 kB 8.51 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feature/trace-type-check Change
_buildManifest.js gzip 393 B 393 B ✓
Overall change 393 B 393 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary vercel/next.js feature/trace-type-check Change
_error.js 1.34 MB 1.34 MB -2 B
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 1.34 MB 1.34 MB -4 B
link.js 1.4 MB 1.4 MB ⚠️ +2 B
routerDirect.js 1.39 MB 1.39 MB ⚠️ +2 B
withRouter.js 1.39 MB 1.39 MB ✓
Overall change 6.9 MB 6.9 MB -2 B
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/trace-type-check Change
buildDuration 10.6s 10.7s ⚠️ +99ms
buildDurationCached 4.5s 4.4s -98ms
nodeModulesSize 46.6 MB 46.6 MB ⚠️ +4.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feature/trace-type-check Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.078 2.089 ⚠️ +0.01
/ avg req/sec 1202.94 1196.65 ⚠️ -6.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.099 1.127 ⚠️ +0.03
/error-in-render avg req/sec 2274.65 2217.85 ⚠️ -56.8
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/trace-type-check Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/trace-type-check Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js feature/trace-type-check Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js feature/trace-type-check Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js feature/trace-type-check Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 74b1e0f

@Timer
Copy link
Member

Timer commented May 3, 2021

Yea, this lgtm.

@kodiakhq kodiakhq bot merged commit 3a78ccd into canary May 4, 2021
@kodiakhq kodiakhq bot deleted the feature/trace-type-check branch May 4, 2021 08:41
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@sokra
Add type checking events (vercel#24595)
f03f5f9 
Will send events like this:

```
[telemetry] {
  "eventName": "NEXT_TYPE_CHECK_COMPLETED",
  "payload": {
    "durationInSeconds": 2,
    "typescriptVersion": "3.8.3",
    "inputFilesCount": 16,
    "totalFilesCount": 289,
    "incremental": false
  }
}
```

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.

## Documentation / Examples

- [ ] Make sure the linting passes
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sokra @ijjk @Timer @timneutkens