Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental babel flag #24776

Merged
merged 3 commits into from
May 7, 2021
Merged

Remove experimental babel flag #24776

merged 3 commits into from
May 7, 2021

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented May 4, 2021 •
edited

Removes one of the experimental flags that didn't make it to production as it did not have the intended impact. It's also conflicting with the faster Babel mode.

Fixes #24767

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the type: next label May 4, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented May 4, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
buildDuration 13.9s 13.6s -330ms
buildDurationCached 4.4s 4.2s -174ms
nodeModulesSize 46.6 MB 46.5 MB -147 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.374 2.411 ⚠️ +0.04
/ avg req/sec 1053.08 1036.81 ⚠️ -16.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.403 1.346 -0.06
/error-in-render avg req/sec 1781.83 1856.86 +75.03
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.3 kB 19.3 kB ✓
webpack-HASH.js gzip 996 B 996 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.04 kB 3.04 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.51 kB 8.51 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
_buildManifest.js gzip 393 B 393 B ✓
Overall change 393 B 393 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
index.html gzip 561 B 561 B ✓
link.html gzip 570 B 570 B ✓
withRouter.html gzip 557 B 557 B ✓
Overall change 1.69 kB 1.69 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
buildDuration 16.9s 17.3s ⚠️ +425ms
buildDurationCached 6.1s 6.2s ⚠️ +68ms
nodeModulesSize 46.6 MB 46.5 MB -147 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
framework-HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 19.3 kB 19.3 kB ✓
webpack-HASH.js gzip 996 B 996 B ✓
Overall change 59.6 kB 59.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
_app-HASH.js gzip 1.02 kB 1.02 kB ✓
_error-HASH.js gzip 3.04 kB 3.04 kB ✓
amp-HASH.js gzip 526 B 526 B ✓
css-HASH.js gzip 334 B 334 B ✓
hooks-HASH.js gzip 890 B 890 B ✓
index-HASH.js gzip 262 B 262 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 331 B 331 B ✓
withRouter-HASH.js gzip 329 B 329 B ✓
99a142a5cfae..804.css gzip 125 B 125 B ✓
Overall change 8.51 kB 8.51 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
_buildManifest.js gzip 393 B 393 B ✓
Overall change 393 B 393 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
_error.js 1.34 MB 1.34 MB ✓
404.html 2.42 kB 2.42 kB ✓
500.html 2.41 kB 2.41 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.61 kB 1.61 kB ✓
css.html 1.79 kB 1.79 kB ✓
hooks.html 1.67 kB 1.67 kB ✓
index.js 1.34 MB 1.34 MB ✓
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.39 MB 1.39 MB ✓
withRouter.js 1.39 MB 1.39 MB ✓
Overall change 6.9 MB 6.9 MB ✓
Webpack 4 Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
buildDuration 12.2s 11.5s -648ms
buildDurationCached 4.9s 4.7s -220ms
nodeModulesSize 46.6 MB 46.5 MB -147 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.478 2.401 -0.08
/ avg req/sec 1008.9 1041.36 +32.46
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.464 1.355 -0.11
/error-in-render avg req/sec 1707.11 1845.16 +138.05
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.19 kB 7.19 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
_app-HASH.js gzip 1.28 kB 1.28 kB ✓
_error-HASH.js gzip 3.71 kB 3.71 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 339 B 339 B ✓
hooks-HASH.js gzip 887 B 887 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 303 B 303 B ✓
withRouter-HASH.js gzip 302 B 302 B ✓
21c68fa65a48..217.css gzip 125 B 125 B ✓
Overall change 9.36 kB 9.36 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/remove-experimental-flag Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 606 B 606 B ✓
Overall change 1.84 kB 1.84 kB ✓
Commit: 9ee5e49

@timneutkens timneutkens merged commit 42c4743 into vercel:canary May 7, 2021
@timneutkens timneutkens deleted the fix/remove-experimental-flag branch May 7, 2021 17:17
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 1, 2021
@timneutkens
Remove experimental babel flag (vercel#24776)
10791f7
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

turboMode and babelMultiThread experimentals can't be used at the same time
2 participants
@timneutkens @ijjk