fix regex for pages that end with index #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridays
commented
Jul 8, 2017
| @@ -18,7 +18,7 @@ export default class PageLoader { | |||
| if (route[0] !== '/') { | |||
| throw new Error('Route name should start with a "/"') | |||
| } | |||
| route = route.replace(/index$/, '') | |||
| route = route.replace(/\/index$/, '/') | |||
There was a problem hiding this comment.
Before this received /abcindex and produced /abc
Now it only matches /index or /abc/index
fridays
commented
Jul 8, 2017
| @@ -26,6 +26,8 @@ export default class PagesPlugin { | |||
| routeName = routeName.replace(/\\/g, '/') | |||
| } | |||
|
|
|||
| routeName = `/${routeName.replace(/(^|\/)index$/, '')}` | |||
There was a problem hiding this comment.
Before this receiced abcindex and produced /abc
Now it only matches index or abc/index
And it does that after the windows slash conversion
|
This fix looks solid. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client navigation currently fails if the filename of a page ends with *index
It happens in both v2 and v3
Reproduce the issue:
/This PR fixes it by changing two regular expressions.